User access requests on LDAP synced groups causes 403
Summary
If you try to approve users who request access to an LDAP synced group, GitLab will throw a 403 & then a 404 on reload.
Steps to reproduce
- Setup a project with LDAP group sync
- Ask user without access to the group to request access
- Try to approve that access request
Expected behavior
User should be allowed access
Actual behavior
GitLab throws a 403
Relevant logs and/or screenshots
Started POST "/groups/ansible-roles/group_members/383/approve_access_request" for 10.76.1.170 at 2017-02-10 06:46:38 +0000
Processing by Groups::GroupMembersController#approve_access_request as HTML
Parameters: {"authenticity_token"=>"0MrEam7ACO0E7mC1RoQi8xs4CBhcbF17Yk0djIxC28w0/iBjc+l4y3wT6/PYSHcO5ssHbAjoXQVxwHeru5546w==", "group_id"=>"ansible-roles", "id"=>"383"}
Filter chain halted as :authorize_admin_group_member! rendered or redirected
Completed 403 Forbidden in 27ms (ActiveRecord: 8.6ms)
Output of checks
Results of GitLab application Check
Checking GitLab Shell ...
GitLab Shell version >= 4.1.1 ? ... OK (4.1.1)
Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by git:git?
default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ...
4/1 ... ok
4/2 ... ok
2/3 ... repository is empty
4/4 ... ok
4/5 ... ok
4/6 ... ok
4/7 ... ok
4/8 ... ok
4/9 ... ok
4/10 ... ok
4/21 ... ok
4/22 ... ok
10/23 ... ok
10/48 ... ok
10/49 ... ok
38/50 ... ok
28/51 ... ok
29/52 ... repository is empty
29/53 ... repository is empty
29/54 ... repository is empty
30/55 ... repository is empty
30/57 ... repository is empty
30/58 ... repository is empty
30/59 ... repository is empty
10/63 ... ok
28/65 ... ok
10/66 ... ok
10/69 ... ok
4/71 ... ok
38/72 ... ok
10/73 ... ok
4/74 ... ok
40/80 ... ok
40/81 ... ok
3/82 ... repository is empty
28/83 ... ok
2/84 ... ok
4/87 ... ok
4/88 ... ok
10/90 ... ok
10/91 ... ok
11/93 ... ok
36/94 ... repository is empty
4/96 ... ok
11/98 ... ok
4/99 ... ok
11/100 ... ok
11/101 ... ok
11/102 ... ok
11/103 ... ok
11/104 ... ok
3/105 ... ok
3/106 ... ok
6/108 ... ok
38/118 ... ok
37/120 ... ok
38/121 ... ok
10/123 ... ok
68/124 ... ok
11/125 ... ok
11/126 ... ok
11/127 ... ok
11/128 ... ok
11/129 ... ok
11/130 ... ok
11/131 ... ok
11/132 ... ok
11/133 ... ok
11/134 ... ok
11/135 ... ok
11/136 ... ok
11/137 ... ok
11/138 ... ok
11/139 ... ok
11/140 ... ok
11/141 ... ok
11/142 ... ok
11/143 ... ok
68/144 ... ok
68/145 ... ok
4/146 ... ok
11/147 ... repository is empty
11/148 ... repository is empty
11/150 ... repository is empty
4/151 ... ok
29/153 ... repository is empty
29/154 ... repository is empty
29/155 ... repository is empty
27/156 ... repository is empty
4/157 ... ok
26/158 ... repository is empty
11/159 ... ok
11/160 ... ok
11/161 ... ok
72/162 ... ok
71/166 ... ok
11/167 ... ok
11/168 ... ok
11/169 ... ok
11/170 ... ok
25/171 ... ok
11/172 ... ok
11/173 ... ok
11/174 ... ok
11/175 ... ok
11/176 ... ok
66/177 ... ok
11/178 ... ok
11/179 ... ok
40/180 ... ok
40/181 ... ok
40/182 ... ok
40/183 ... ok
40/184 ... ok
40/185 ... ok
40/186 ... ok
40/187 ... ok
40/188 ... ok
40/189 ... ok
40/190 ... ok
40/191 ... ok
19/192 ... ok
40/194 ... ok
87/195 ... ok
26/196 ... ok
71/197 ... ok
87/198 ... ok
11/199 ... ok
11/200 ... ok
80/202 ... ok
57/203 ... ok
19/207 ... ok
19/211 ... ok
40/213 ... ok
40/214 ... ok
10/215 ... ok
10/216 ... ok
40/218 ... ok
40/219 ... ok
86/220 ... repository is empty
11/221 ... ok
11/225 ... ok
94/229 ... repository is empty
88/230 ... repository is empty
61/231 ... ok
11/233 ... ok
10/234 ... ok
11/235 ... ok
11/236 ... ok
11/238 ... ok
4/239 ... ok
4/240 ... ok
4/241 ... ok
4/242 ... ok
4/243 ... ok
4/244 ... ok
103/245 ... ok
16/246 ... ok
16/248 ... ok
16/250 ... repository is empty
87/253 ... ok
87/255 ... ok
87/256 ... ok
87/257 ... ok
87/258 ... ok
87/259 ... ok
87/260 ... ok
87/261 ... ok
71/262 ... ok
89/263 ... repository is empty
4/264 ... ok
11/265 ... ok
116/266 ... ok
116/267 ... ok
116/268 ... ok
116/269 ... ok
116/270 ... ok
116/271 ... ok
116/272 ... ok
116/273 ... ok
116/274 ... ok
116/275 ... ok
116/276 ... ok
116/277 ... ok
116/278 ... ok
116/279 ... ok
116/280 ... ok
116/281 ... ok
116/282 ... ok
116/283 ... ok
116/284 ... ok
116/285 ... ok
116/286 ... ok
116/287 ... ok
116/288 ... ok
116/289 ... ok
116/290 ... ok
116/291 ... ok
116/292 ... ok
116/293 ... ok
116/294 ... ok
116/295 ... ok
116/296 ... ok
116/297 ... ok
116/298 ... ok
116/299 ... ok
116/300 ... ok
116/301 ... ok
116/302 ... ok
116/303 ... ok
116/304 ... ok
116/305 ... ok
5/307 ... ok
5/308 ... ok
5/309 ... ok
5/310 ... ok
5/311 ... ok
5/312 ... ok
5/313 ... ok
5/314 ... ok
40/315 ... ok
40/316 ... ok
40/317 ... ok
29/318 ... ok
29/319 ... ok
40/320 ... ok
40/321 ... ok
40/322 ... ok
11/323 ... ok
116/324 ... ok
116/325 ... ok
28/326 ... ok
116/327 ... ok
29/328 ... ok
116/329 ... ok
11/331 ... ok
40/332 ... ok
38/333 ... ok
11/334 ... ok
28/336 ... ok
28/337 ... ok
116/338 ... ok
74/340 ... ok
74/341 ... ok
74/342 ... ok
74/343 ... ok
74/344 ... ok
74/345 ... ok
74/346 ... ok
74/347 ... ok
74/348 ... ok
116/349 ... repository is empty
116/350 ... ok
40/353 ... ok
38/354 ... ok
4/355 ... repository is empty
11/356 ... ok
11/357 ... repository is empty
11/358 ... ok
124/359 ... ok
124/360 ... ok
124/361 ... ok
124/362 ... ok
116/363 ... ok
10/364 ... ok
11/365 ... ok
11/366 ... ok
116/367 ... ok
10/368 ... ok
10/369 ... ok
10/370 ... ok
28/371 ... ok
10/372 ... ok
10/373 ... ok
10/374 ... ok
10/375 ... ok
10/376 ... ok
10/377 ... ok
128/378 ... ok
128/379 ... ok
128/380 ... ok
128/381 ... ok
37/382 ... ok
124/383 ... ok
11/384 ... ok
38/385 ... ok
71/386 ... ok
16/387 ... ok
4/388 ... ok
4/389 ... ok
4/390 ... ok
4/391 ... ok
4/392 ... ok
11/394 ... ok
16/396 ... repository is empty
16/408 ... ok
16/409 ... ok
16/412 ... ok
16/413 ... ok
16/415 ... ok
16/416 ... ok
16/417 ... ok
128/418 ... ok
37/419 ... ok
5/420 ... ok
128/421 ... ok
130/422 ... repository is empty
116/423 ... ok
116/424 ... ok
116/425 ... ok
28/427 ... ok
3/428 ... ok
28/429 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Access to /mnt/it-gitlab/.ssh/authorized_keys: OK
Send ping to redis server: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... skipped (omnibus-gitlab has no init script)
MailRoom running? ... can't check because of previous errors
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain
LDAP authentication... Success
LDAP users with access to your GitLab server (only showing the first 100 results)
Dump of LDAP users (Ommited)
Checking LDAP ... Finished
Checking GitLab ...
Git configured with autocrlf=input? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config outdated? ... no
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory setup correctly? ... no
Try fixing it:
sudo chown -R git /mnt/it-gitlab/gitlab-rails/uploads
sudo find /mnt/it-gitlab/gitlab-rails/uploads -type f -exec chmod 0644 {} \;
sudo find /mnt/it-gitlab/gitlab-rails/uploads -type d -not -path /mnt/it-gitlab/gitlab-rails/uploads -exec chmod 0700 {} \;
For more information see:
doc/install/installation.md in section "GitLab"
Please fix the error above and rerun the checks.
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
projects have namespace: ...
4/1 ... yes
4/2 ... yes
2/3 ... yes
4/4 ... yes
4/5 ... yes
4/6 ... yes
4/7 ... yes
4/8 ... yes
4/9 ... yes
4/10 ... yes
4/21 ... yes
4/22 ... yes
10/23 ... yes
10/48 ... yes
10/49 ... yes
38/50 ... yes
28/51 ... yes
29/52 ... yes
29/53 ... yes
29/54 ... yes
30/55 ... yes
30/57 ... yes
30/58 ... yes
30/59 ... yes
10/63 ... yes
28/65 ... yes
10/66 ... yes
10/69 ... yes
4/71 ... yes
38/72 ... yes
10/73 ... yes
4/74 ... yes
40/80 ... yes
40/81 ... yes
3/82 ... yes
28/83 ... yes
2/84 ... yes
4/87 ... yes
4/88 ... yes
10/90 ... yes
10/91 ... yes
11/93 ... yes
36/94 ... yes
4/96 ... yes
11/98 ... yes
4/99 ... yes
11/100 ... yes
11/101 ... yes
11/102 ... yes
11/103 ... yes
11/104 ... yes
3/105 ... yes
3/106 ... yes
6/108 ... yes
38/118 ... yes
37/120 ... yes
38/121 ... yes
10/123 ... yes
68/124 ... yes
11/125 ... yes
11/126 ... yes
11/127 ... yes
11/128 ... yes
11/129 ... yes
11/130 ... yes
11/131 ... yes
11/132 ... yes
11/133 ... yes
11/134 ... yes
11/135 ... yes
11/136 ... yes
11/137 ... yes
11/138 ... yes
11/139 ... yes
11/140 ... yes
11/141 ... yes
11/142 ... yes
11/143 ... yes
68/144 ... yes
68/145 ... yes
4/146 ... yes
11/147 ... yes
11/148 ... yes
11/150 ... yes
4/151 ... yes
29/153 ... yes
29/154 ... yes
29/155 ... yes
27/156 ... yes
4/157 ... yes
26/158 ... yes
11/159 ... yes
11/160 ... yes
11/161 ... yes
72/162 ... yes
71/166 ... yes
11/167 ... yes
11/168 ... yes
11/169 ... yes
11/170 ... yes
25/171 ... yes
11/172 ... yes
11/173 ... yes
11/174 ... yes
11/175 ... yes
11/176 ... yes
66/177 ... yes
11/178 ... yes
11/179 ... yes
40/180 ... yes
40/181 ... yes
40/182 ... yes
40/183 ... yes
40/184 ... yes
40/185 ... yes
40/186 ... yes
40/187 ... yes
40/188 ... yes
40/189 ... yes
40/190 ... yes
40/191 ... yes
19/192 ... yes
40/194 ... yes
87/195 ... yes
26/196 ... yes
71/197 ... yes
87/198 ... yes
11/199 ... yes
11/200 ... yes
80/202 ... yes
57/203 ... yes
19/207 ... yes
19/211 ... yes
40/213 ... yes
40/214 ... yes
10/215 ... yes
10/216 ... yes
40/218 ... yes
40/219 ... yes
86/220 ... yes
11/221 ... yes
11/225 ... yes
94/229 ... yes
88/230 ... yes
61/231 ... yes
11/233 ... yes
10/234 ... yes
11/235 ... yes
11/236 ... yes
11/238 ... yes
4/239 ... yes
4/240 ... yes
4/241 ... yes
4/242 ... yes
4/243 ... yes
4/244 ... yes
103/245 ... yes
16/246 ... yes
16/248 ... yes
16/250 ... yes
87/253 ... yes
87/255 ... yes
87/256 ... yes
87/257 ... yes
87/258 ... yes
87/259 ... yes
87/260 ... yes
87/261 ... yes
71/262 ... yes
89/263 ... yes
4/264 ... yes
11/265 ... yes
116/266 ... yes
116/267 ... yes
116/268 ... yes
116/269 ... yes
116/270 ... yes
116/271 ... yes
116/272 ... yes
116/273 ... yes
116/274 ... yes
116/275 ... yes
116/276 ... yes
116/277 ... yes
116/278 ... yes
116/279 ... yes
116/280 ... yes
116/281 ... yes
116/282 ... yes
116/283 ... yes
116/284 ... yes
116/285 ... yes
116/286 ... yes
116/287 ... yes
116/288 ... yes
116/289 ... yes
116/290 ... yes
116/291 ... yes
116/292 ... yes
116/293 ... yes
116/294 ... yes
116/295 ... yes
116/296 ... yes
116/297 ... yes
116/298 ... yes
116/299 ... yes
116/300 ... yes
116/301 ... yes
116/302 ... yes
116/303 ... yes
116/304 ... yes
116/305 ... yes
5/307 ... yes
5/308 ... yes
5/309 ... yes
5/310 ... yes
5/311 ... yes
5/312 ... yes
5/313 ... yes
5/314 ... yes
40/315 ... yes
40/316 ... yes
40/317 ... yes
29/318 ... yes
29/319 ... yes
40/320 ... yes
40/321 ... yes
40/322 ... yes
11/323 ... yes
116/324 ... yes
116/325 ... yes
28/326 ... yes
116/327 ... yes
29/328 ... yes
116/329 ... yes
11/331 ... yes
40/332 ... yes
38/333 ... yes
11/334 ... yes
28/336 ... yes
28/337 ... yes
116/338 ... yes
74/340 ... yes
74/341 ... yes
74/342 ... yes
74/343 ... yes
74/344 ... yes
74/345 ... yes
74/346 ... yes
74/347 ... yes
74/348 ... yes
116/349 ... yes
116/350 ... yes
40/353 ... yes
38/354 ... yes
4/355 ... yes
11/356 ... yes
11/357 ... yes
11/358 ... yes
124/359 ... yes
124/360 ... yes
124/361 ... yes
124/362 ... yes
116/363 ... yes
10/364 ... yes
11/365 ... yes
11/366 ... yes
116/367 ... yes
10/368 ... yes
10/369 ... yes
10/370 ... yes
28/371 ... yes
10/372 ... yes
10/373 ... yes
10/374 ... yes
10/375 ... yes
10/376 ... yes
10/377 ... yes
128/378 ... yes
128/379 ... yes
128/380 ... yes
128/381 ... yes
37/382 ... yes
124/383 ... yes
11/384 ... yes
38/385 ... yes
71/386 ... yes
16/387 ... yes
4/388 ... yes
4/389 ... yes
4/390 ... yes
4/391 ... yes
4/392 ... yes
11/394 ... yes
16/396 ... yes
16/408 ... yes
16/409 ... yes
16/412 ... yes
16/413 ... yes
16/415 ... yes
16/416 ... yes
16/417 ... yes
128/418 ... yes
37/419 ... yes
5/420 ... yes
128/421 ... yes
130/422 ... yes
116/423 ... yes
116/424 ... yes
116/425 ... yes
28/427 ... yes
3/428 ... yes
28/429 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.1.0 ? ... yes (2.3.3)
Your git bin path is "/opt/gitlab/embedded/bin/git"
Git version >= 2.7.3 ? ... yes (2.8.4)
Active users: 99
Checking GitLab ... Finished
Results of GitLab environment info
System information
System: Ubuntu 14.04
Current User: git
Using RVM: no
Ruby Version: 2.3.3p222
Gem Version: 2.6.6
Bundler Version:1.13.7
Rake Version: 10.5.0
Sidekiq Version:4.2.7
GitLab information
Version: 8.15.4-ee
Revision: e33b0cb
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 9.5.2
URL: (OMMITED)
HTTP Clone URL: (OMMITED)
SSH Clone URL: (OMMITED)
Elasticsearch: no
Geo: no
Using LDAP: yes
Using Omniauth: yes
Omniauth Providers: github
GitLab Shell
Version: 4.1.1
Repository storage paths:
- default: /mnt/it-gitlab/git-data/repositories
Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks/
Git: /opt/gitlab/embedded/bin/git
Possible fixes
Either disable group access requests for groups that are setup to sync with LDAP or allow users to request/manage membership through LDAP & within GitLab.