DelayedMailer Task Fails Due to Missing Note ID
In gitlab v8.6
, I see this error sometimes in the logs:
==> log/sidekiq.log <==
2016-04-29T04:23:52.032Z 26550 TID-owdkfi4v8 Sidekiq::Extensions::DelayedMailer JID-bbf3a560a1c0e45e838e8e03 INFO: start
2016-04-29T04:23:52.045Z 26550 TID-owdkfi4v8 Sidekiq::Extensions::DelayedMailer JID-bbf3a560a1c0e45e838e8e03 INFO: fail: 0.013 sec
2016-04-29T04:23:52.045Z 26550 TID-owdkfi4v8 WARN: {"retry"=>true, "queue"=>"default", "class"=>"Sidekiq::Extensions::DelayedMailer", "args"=>["---\n- !ruby/class 'Notify'\n- :send\n- - :note_commit_email\n - 239\n - 261484\n"], "jid"=>"bbf3a560a1c0e45e838e8e03", "enqueued_at"=>1461903832.0318565, "error_message"=>"undefined method `id' for nil:NilClass", "error_class"=>"NoMethodError", "failed_at"=>1461862387.5957203, "retry_count"=>12, "retried_at"=>1461903832.0454173, "created_at"=>1461878936.7685287}
2016-04-29T04:23:52.046Z 26550 TID-owdkfi4v8 WARN: NoMethodError: undefined method `id' for nil:NilClass
2016-04-29T04:23:52.046Z 26550 TID-owdkfi4v8 WARN: /home/git/gitlabhq/releases/b7c841682db90e6a696ca8b3753160e17fc461c4/app/models/sent_notification.rb:43:in `record'
/home/git/gitlabhq/releases/b7c841682db90e6a696ca8b3753160e17fc461c4/app/models/sent_notification.rb:61:in `record_note'
/home/git/gitlabhq/releases/b7c841682db90e6a696ca8b3753160e17fc461c4/app/mailers/emails/notes.rb:49:in `setup_note_mail'
/home/git/gitlabhq/releases/b7c841682db90e6a696ca8b3753160e17fc461c4/app/mailers/emails/notes.rb:4:in `note_commit_email'
Edited by 🤖 GitLab Bot 🤖