No or approvers required in MR list is incorrect with Multiple Approval Rules
Summary
The number of required approvals on the Merge Request List always display required approvals for the Base approvals rules
even if Multiple approval rules
is used.
This is the number shown in the form of X of Y
approvals on the MR page. The number for Y
always use the Base approval rules which are the settings for All members with Developer role or higher and code owners (if any)
Steps to reproduce
- Edit
All members with Developer role or higher and code owners (if any)
to 2. - Then start adding Multiple approval rules (say add 3 groups with 1 approval each)
- Go to list of merge request page. It will show
X of 2
instead ofX of 3
What is the current bug behavior?
It shows the base approvals rules, regardless if multiple approvals rules is used or not.
What is the expected correct behavior?
If Multiple approvals rules are used, I would expect this to show the total approval required from all the different Multiple approvals rules
Output of checks
This bug happens on GitLab.com
Initially reported by a current paying user (internal only ZD ref https://gitlab.zendesk.com/agent/tickets/127182)