Packages files are not deleted from the storage

Summary

Deleting a package from the UI will only remove DB entries, but not the uploaded files

Steps to reproduce

1. publish a package (npm or mvn)
2. check it is available on disk or object storage
3. delete the package from the UI
4. check the storage again

What is the current bug behavior?

Only database entries get removed

What is the expected correct behavior?

The file should be removed from the storage as well.

Impact

This issue could decrease our Cloud Spend.

Object storage bill is also based on storage occupation, if a user deletes a package, it means that it's no longer needed, but we are still paying for that package

Development log

Status

• backend MR gitlab-org/gitlab-ee!15634

Decisions

• @nolith volunteered to fix the ongoing problem, leaving data integrity to ~"group::package"

The next iteration

• Cleanup orphaned packages on storage gitlab-org/gitlab-ee#14027