Skip to content

Disable self-approval at the Group level

Problem to solve

We'll be introducing the ability for Administrators to disable self-approval at the instance level in %12.7, but this will necessarily need to become available for .com customers as well.

Further details

To ensure at least two people review a merge request other than the author and committers, two settings exist:

  • Prevent approval of merge requests by merge request author
  • Prevent approval of merge requests by merge request committers

But, the maintainer or owner can change these. This makes it possible to bypass this restriction in secure environments where this needs to be the case without exception for every project.

This iteration focuses on solving this problem at the group-level for .com customers.

Proposal

Add MR approval settings to Settings -> General -> Merge request approvals section:

Screen_Shot_2019-12-20_at_9.50.07_AM

When a Group Owner modifies these settings, they apply to all projects and only a Group Owner can change them at the project level.