Approval data can not be loaded in MR when having the root domain dot in the URL
Summary
Approval data can not be loaded when viewing a merge request while having the root domain dot in the URL
Steps to reproduce
- Have a plan supporting merge request approvals.
- Create a merge request.
- View it and make sure the root domain dot is present in the URL (see URL to example project below).
Example Project
I tried creating a example project here: https://gitlab.com./LoPoBo/issue-example-approval-retrieval/merge_requests/1
But since my plan here does not include Approvals the issue was not reproducable in that project.
What is the current bug behavior?
An error ("An error occurred while retrieving approval data for this merge request.") is displayed and the MR cannot be merged.
What is the expected correct behavior?
The approval data is loaded correctly.
Relevant logs and/or screenshots
I inspected the network traffic and saw that the call to the resource approvals
was sent to the domain my.domain.com
even though the page (and all other resources) was loaded from my.domain.com.
. The call resulted in 404.
Output of checks
This bug happens on a local installation of GitLab Enterprise Edition 11.10.4-ee. I do not have admin rights to it and cannot access the output.