Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 23,913
    • Issues 23,913
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 835
    • Merge Requests 835
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #11322

You need to sign in or sign up before continuing.
Closed (moved)
Open
Opened Apr 25, 2019 by Brendan O'Leary 🐢@brendan🦊
  • Report abuse
  • New issue
Report abuse New issue

Support runtime Visual Review configuration

Problem to Solve

The Visual Review apps feature is nice but very difficult to use because you have to hardcode runtime configuration into your branch, which will result in merge conflicts and having to remember to remove the config before it merges, amongst other strangeness.

Proposal

For the next iteration we should prompt the user for the MR number they want to report on if no value is available at runtime. For teams who do have a working flow where they want to hardcode a merge request number per branch they can continue to do so, but if it is not provided it simply prompts.

Design

  • Merge request ID input step
    • Enter your merge request ID
  • Reuses existing UI
  • Link links to documentation explaining why we need the merge request ID.
  • Added in text in last state: Reports to merge request [!12343](URL). You can change that [here](URL)
    • !12343 links to the merge request
    • here links back to merge request id configuration state

image

Note: Modal UI changes have been moved to #12447 (closed)

Reference

  • As a followup to this discussion: https://gitlab.com/gitlab-org/gitlab-ee/issues/10761#note_164273318
Edited Jul 01, 2019 by Dimitrie Hoekstra

Related issues

  • Discussion
  • Designs
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
17
Labels
Category:Usability Testing Deliverable Enterprise Edition GitLab Starter Product Vision FY20 UX ready [DEPRECATED] Verify [DEPRECATED] backend depth devops::verify direction documentation feature frontend maturity::viable missed-deliverable missed:12.0
Assign labels
  • View project labels
Reference: gitlab-org/gitlab#11322