Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/geo_nodes.scss`
Problem
Fix the following style-lint errors and warnings for ee/app/assets/stylesheets/pages/geo_nodes.scss
47:1 ⚠ ".geo-node-unknown" and ".geo-node-disabled (ee/app/assets/stylesheets/pages/geo_nodes.scss -43:1)" have the same properties. stylelint-gitlab/duplicate-selectors
76:7 ⚠ Expected ".geo-node-item .card-body .node-detail-section .btn-show-section" to have no more than 3 compound selectors selector-max-compound-selectors
76:7 ⚠ ".btn-show-section" and ".card-body (ee/app/assets/stylesheets/pages/geo_nodes.scss -64:3)" have the same properties. stylelint-gitlab/duplicate-selectors
101:7 ⚠ Expected ".node-detail-section .detail-section-item .node-detail-title .node-detail-help-text" to have no more than 3 compound selectors selector-max-compound-selectors
101:7 ⚠ Expected ".node-detail-section .section-items-container .node-detail-title .node-detail-help-text" to have no more than 3 compound selectors selector-max-compound-selectors
105:7 ⚠ Expected ".node-detail-section .detail-section-item .node-detail-title .tooltip .tooltip-inner" to have no more than 3 compound selectors selector-max-compound-selectors
105:7 ⚠ Expected ".node-detail-section .section-items-container .node-detail-title .tooltip .tooltip-inner" to have no more than 3 compound selectors selector-max-compound-selectors
122:5 ⚠ ".node-detail-value-error" and ".geo-node-unhealthy (ee/app/assets/stylesheets/pages/geo_nodes.scss -35:1)" have the same properties. stylelint-gitlab/duplicate-selectors
183:5 ⚠ ".header-text-primary, .header-text-secondary" and ".node-detail-help-text (ee/app/assets/stylesheets/pages/geo_nodes.scss -101:7)" stylelint-gitlab/duplicate-selectors
have the same properties.
209:7 ⚠ ".card-expand-icon" and ".card-collapse-icon (ee/app/assets/stylesheets/pages/geo_nodes.scss -203:7)" have the same properties. stylelint-gitlab/duplicate-selectors
226:7 ⚠ "&.status-type-failure" and ".node-detail-value-error (ee/app/assets/stylesheets/pages/geo_nodes.scss -122:5)" have the same properties. stylelint-gitlab/duplicate-selectors
232:7 ⚠ Expected ".geo-admin-projects .card-body .project-status-container + .project-status-container" to have no more than 3 compound selectors selector-max-compound-selectors
232:7 ⚠ Expected ".admin-projects .card-body .project-status-container + .project-status-container" to have no more than 3 compound selectors selector-max-compound-selectors
239:5 ⚠ Expected ".geo-admin-projects .errors-list li + li" to have no more than 3 compound selectors selector-max-compound-selectors
239:5 ⚠ Expected ".admin-projects .errors-list li + li" to have no more than 3 compound selectors selector-max-compound-selectors
243:5 ⚠ ".error-icon, .error-text" and "&.status-type-failure (ee/app/assets/stylesheets/pages/geo_nodes.scss -226:7)" have the same stylelint-gitlab/duplicate-selectors
properties.
What to do
- If possible, replace the CSS class with a utility one, check common.scss and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
- Double check if all the warning have been fixed by running
yarn run stylelint-file ee/app/assets/stylesheets/pages/geo_nodes.scss
- In the MR, add screenshots of the affected areas before and after the changes, check the first MR as a guideline
- If there are a lot of changes, we recommend to break them into smaller MRs
- Double check the usage of each changed class both in CE and EE
- EE changes should either be backported into CE or moved into
ee/
folder. You can read more about how to handle EE code here - Label the MR with CSS cleanup