Add ability to take screenshot in Visual Review Tool
Problem to solve
With #10761 (closed), we added the ability to start a discussion from the Visual Review tool. We should add the ability to add a screenshot of a certain area of the application to the created discussion.
This will bring the Visual Review Tool more in line with the competition in the market we are looking at as related to this feature.
In addition, this issue is part of making ~"Category::Usability Testing" maturity::viable
- Add a "take a screenshot" button to the Visual Review Tool.
- When the user clicks that button, give them a cursor that is a
+that allows them to select one corner as the starting corner and drag to the opposite corner to select the rectangle area they want to screenshot.
- Once the user does that drag action (similar to
4on Mac OS), we save the image and upload as if it had been "pasted" into a comment or description field in GitLab today
- Add in the
![image](/uploads/hash/image.png)automatically to the comment the user is writing.
Example from another tool:
Example of copy/paste of an image (as a Mac screenshot copied to the clipboard) today in GitLab:
Permissions and Security
This issue does not impact permissions or security as they will be the same as the previous permissions and security of the Visual Review Tool.
This will require updated documentation, with careful consideration for any known limitations.
@zeffmorgan this issue is one that would benefit from at least some cross-browser testing as I'm guessing the library our team uses will impact compatibility with different browsers. As a note - if we need to disable this functionality in certain unsupportable browsers, I think that is acceptable as long as "most modern browers" support this functionality.
What does success look like, and how can we measure that?
What is the type of buyer?
Links / references
Out of scope will be annotations to those images https://gitlab.com/gitlab-org/gitlab-ce/issues/58728