Geo: "Recheck" term seems overloaded
On a Geo secondary
On Admin > Geo > Projects:
On Admin > Projects:
The "Recheck" button (in both screenshots above) clears the secondary checksum (so the verification worker picks it up to make a checksum and compare it with the one on the primary).
Problem
The word "check" is a bit vague. "Recheck" has nothing to do with "Trigger repository check", which does git fsck
.
Also, you might think/hope that "Recheck" recalculates the checksum on the primary as well, but you'll be disappointed.
Proposal
Add a tooltip to "Recheck" button that says what it does, e.g. "Recalculates the repository checksum on this Geo node".
IDK if maybe this is only meaningful to Geo devs, or if it would be helpful for customers as well.
Rename Recheck
button to Reverify
or Reverify with primary
and make it do what we expect that to mean.
- Call an endpoint on the primary to mark it for verification
- The secondary will follow the primary's lead, so we don't need to mark anything on the secondary