Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 23,748
    • Issues 23,748
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 814
    • Merge Requests 814
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Issues
  • #10135

Closed
Open
Opened Mar 01, 2019 by Douwe Maan@DouweM
  • Report abuse
  • New issue
Report abuse New issue

Extract EE specific files/lines for Configure spec/lib/gitlab

We have the following files containing EE specific code. We should move them to ee/

spec/lib/gitlab/kubernetes_spec.rb
diff --git a/spec/lib/gitlab/kubernetes_spec.rb b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/lib/gitlab/kubernetes_spec.rb
index f326d57e9c6..21359eab225 100644
--- a/spec/lib/gitlab/kubernetes_spec.rb
+++ b/home/yorickpeterse/Projects/gitlab/gdk-ee/gitlab/spec/lib/gitlab/kubernetes_spec.rb
@@ -40,8 +40,8 @@ describe Gitlab::Kubernetes do
 
   describe '#filter_by_label' do
     it 'returns matching labels' do
-      matching_items = [kube_pod(app: 'foo')]
-      items = matching_items + [kube_pod]
+      matching_items = [kube_pod(app: 'foo'), kube_deployment(app: 'foo')]
+      items = matching_items + [kube_pod, kube_deployment]
 
       expect(filter_by_label(items, app: 'foo')).to eq(matching_items)
     end

Related issues

  • Discussion
  • Designs
Assignee
Assign to
11.10
Milestone
11.10
Assign milestone
Time tracking
None
Due date
None
9
Labels
Configure [DEPRECATED] Deliverable Enterprise Edition Quality backend backstage group::orchestration single codebase test
Assign labels
  • View project labels
Reference: gitlab-org/gitlab#10135