GitLab issueshttps://gitlab.com/gitlab-org/gitlab/-/issues2023-05-15T07:50:33Zhttps://gitlab.com/gitlab-org/gitlab/-/issues/32793Determine if Sentry browser SDK initialization can be optimized2023-05-15T07:50:33ZDennis TangDetermine if Sentry browser SDK initialization can be optimizedThe loading of the Sentry browser SDK is quite performance-intensive. We should take a look if the init can be optimized.
![firefox_2019-01-14_15-25-37](/uploads/978b0344f8989bf982209355e004b7b7/firefox_2019-01-14_15-25-37.png)
As per ...The loading of the Sentry browser SDK is quite performance-intensive. We should take a look if the init can be optimized.
![firefox_2019-01-14_15-25-37](/uploads/978b0344f8989bf982209355e004b7b7/firefox_2019-01-14_15-25-37.png)
As per Sentry's [documentation](https://docs.sentry.io/platforms/javascript/#lazy-loading-sentry), it may be advisable to consider lazy-loading Sentry, which may involve using their wrapper hosted on their CDN. This would require a bit of a change instead of self-hosting the dependency.Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/12000Push rules shows 404 error when you don't have a License installed2019-09-24T09:27:02ZAdriano S. FonsecaPush rules shows 404 error when you don't have a License installed<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label.
For the Community Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ce/issues?...<!---
Please read this!
Before opening a new issue, make sure to search for keywords in the issues
filtered by the "regression" or "bug" label.
For the Community Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=bug
For the Enterprise Edition issue tracker:
- https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=regression
- https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=bug
and verify the issue you're about to submit isn't a duplicate.
--->
### Summary
In a fresh installation of GitLab EE if you navigate to Admin/Push Rules without having a license installed you will get a 404 error. Once I installed a license I was able to see the page.
### Steps to reproduce
In a fresh new Omnibus installation go to admin/push rules:
### Example Project
It is not a project specific bug.
### What is the current *bug* behavior?
You will get 404 error.
### What is the expected *correct* behavior?
If this is a page that the user shouldn't have access without a license. We should give them an appropriated message.
#### Results of GitLab environment info
<details>
<summary>Expand for output related to GitLab environment info</summary>
<pre>
System information
System: Ubuntu 18.04
Proxy: no
Current User: git
Using RVM: no
Ruby Version: 2.5.3p105
Gem Version: 2.7.9
Bundler Version:1.17.3
Rake Version: 12.3.2
Redis Version: 3.2.12
Git Version: 2.21.0
Sidekiq Version:5.2.7
Go Version: unknown
GitLab information
Version: 11.11.2-ee
Revision: cfdecb7c5de
Directory: /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 9.6.11
URL: https://gitlab.example.com
HTTP Clone URL: https://gitlab.example.com/some-group/some-project.git
SSH Clone URL: git@gitlab.example.com:some-group/some-project.git
Elasticsearch: no
Geo: no
Using LDAP: no
Using Omniauth: yes
Omniauth Providers:
GitLab Shell
Version: 9.1.0
Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories
GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell
Git: /opt/gitlab/embedded/bin/git
</pre>
</details>
#### Results of GitLab application Check
<details>
<summary>Expand for output related to the GitLab application check</summary>
<pre>
Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.1.0 ? ... OK (9.1.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet)
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
35/1 ... yes
37/2 ... yes
35/3 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.5.3)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... yes
Active users: ... 3
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished
</pre>
</details>
### Possible fixes
(If you can, link to the line of code that might be responsible for the problem)12.4Dmytro Zaporozhets (DZ)Dmytro Zaporozhets (DZ)https://gitlab.com/gitlab-org/gitlab/-/issues/28577Analysis: Identify parts of the QA framework that need updates to allow paral...2020-06-08T21:59:28ZMark LapierreAnalysis: Identify parts of the QA framework that need updates to allow parallelizationWhen the [QA E2E tests are run in parallel](https://gitlab.com/groups/gitlab-org/-/epics/1276#note_165718083), we need to ensure that each test is isolated from all others.
For example, there was a problem in the past caused by multiple...When the [QA E2E tests are run in parallel](https://gitlab.com/groups/gitlab-org/-/epics/1276#note_165718083), we need to ensure that each test is isolated from all others.
For example, there was a problem in the past caused by multiple tests using the same project name, so when the tests were run on Staging (where there are parallel jobs), they failed when one test changed the project in a way that interfered with another test.
The purpose of this issue is to identify parts of the QA framework that could violate test isolation.Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/28418[QA] Use an admin account to toggle feature flags2019-11-06T04:39:37ZMark Lapierre[QA] Use an admin account to toggle feature flagsThe QA framework uses `Runtime::API::Client` to enable/disable feature flags. The problem with this is that `Runtime::API::Client` authenticates as the current user, or as another user specified via a personal access token.
When running...The QA framework uses `Runtime::API::Client` to enable/disable feature flags. The problem with this is that `Runtime::API::Client` authenticates as the current user, or as another user specified via a personal access token.
When running tests on a clean environment (e.g., a docker container running a nightly image), the default user is an admin user, so we don't need to do anything special to allow it to toggle feature flags.
But when running tests in an environment where we don't usually run the tests as an admin user (e.g., on staging/prod/preprod), we need to be able to provide an admin user's credentials so that we can toggle feature flags. We could simply provide an admin user's personal access token when needed, but the framework should also be flexible enough to create a token when needed.
### Proposal
* Allow the QA framework to use a personal access token to enable/disable feature flags via `Runtime::API::Client`
* If no token is provided, create one using admin user credentials (set via `GITLAB_ADMIN_{USERNAME|PASSWORD}`)
* If no admin credentials are provided, raise an exceptionBackloghttps://gitlab.com/gitlab-org/gitlab/-/issues/28135Make `bug`, `feature`, and `backstage` issue type labels to be scoped labels2021-09-29T09:45:00ZRémy CoutableMake `bug`, `feature`, and `backstage` issue type labels to be scoped labelsPart of https://gitlab.com/gitlab-org/gitlab-ce/issues/60166.
The idea is to migrate:
1. ~bug to `~"type::bug"`
1. ~feature to `~"type::feature"`
1. ~tooling to `~"type::tooling"`
1. ~security to `~"type::security"`
1. ~documentation...Part of https://gitlab.com/gitlab-org/gitlab-ce/issues/60166.
The idea is to migrate:
1. ~bug to `~"type::bug"`
1. ~feature to `~"type::feature"`
1. ~tooling to `~"type::tooling"`
1. ~security to `~"type::security"`
1. ~documentation to `~"type::documentation"`
TODO:
1. [ ] Prepare a MR for https://gitlab.com/gitlab-org/gitlab-ce: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29563
1. [ ] Prepare a MR for https://gitlab.com/gitlab-org/quality/triage-ops: https://gitlab.com/gitlab-org/quality/triage-ops/merge_requests/150
1. [ ] Prepare a MR for https://gitlab.com/gitlab-org/gitlab-insights: https://gitlab.com/gitlab-org/gitlab-insights/merge_requests/114
1. [ ] Prepare a MR for https://gitlab.com/DylanGriffith/knative-bots/blob/master/lib/throughput_labels.rb
1. [ ] Prepare a MR for https://gitlab.com/gitlab-com/www-gitlab-com: https://gitlab.com/gitlab-com/www-gitlab-com/merge_requests/24219
1. [ ] Change the group labels
1. [ ] Announce it on Slack and team callBackloghttps://gitlab.com/gitlab-org/gitlab/-/issues/11169Open Gemnasium Advisories Database2020-03-05T21:37:35ZOlivier GonzalezOpen Gemnasium Advisories Database### Problem to solve
Allow users and customers to access Gemnasium Advisories Database to check its content and contribute.
### Intended users
- ~"Persona: Security Analyst"
- ~"Persona: DevOps Engineer"
- ~"Persona: Software develop...### Problem to solve
Allow users and customers to access Gemnasium Advisories Database to check its content and contribute.
### Intended users
- ~"Persona: Security Analyst"
- ~"Persona: DevOps Engineer"
- ~"Persona: Software developer"
### Further details
For this first iteration, the main goals are to allow users to:
* search for our advisories
* contribute
### Proposal
- [x] Create a new **public** project [`security-products/gemnasium-db`](https://gitlab.com/gitlab-org/security-products/gemnasium-db):
- [x] ~~Which License to use? `EE License` [first suggested](https://gitlab.com/gitlab-org/gitlab-ee/issues/11169#note_161055202)) but doesn't fullfill all our requirements so [discussion is still ongoing](https://gitlab.com/gitlab-org/gitlab-ee/issues/11169#note_163672844)~~ [Specific TERMS have been added](https://gitlab.com/gitlab-org/security-products/gemnasium-db/merge_requests/6) to address this.
- Prepare the Gemnasium DB for the export
- [x] Ensure all advisories have an identifier since this will be used in the exported filename
- Import the full Gemnasium DB into this repo (only one initial import).
- [x] Decide on which format to use (YAML vs JSON). We'll go with YAML ([see discussion here](https://gitlab.com/gitlab-org/gitlab-ee/issues/11169#note_163164960))
- [x] Import all advisories as YAML files in [gemnasium-db](https://gitlab.com/gitlab-org/security-products/gemnasium-db) (see https://gitlab.com/gitlab-org/security-products/gemnasium-db/merge_requests/3)
- ~~[x] Use this repo as SSOT to import/update advisories into Gemnasium DB (so it will stay in sync by design after initial import).~~ Moved to https://gitlab.com/gitlab-org/gitlab-ee/issues/11837. We will periodically resync until this is done.
- Document public workflow to contribute to our advisories db:
> create an issue or an MR to contribute and add an advisory to the DB. Contribution to enriching metadata is open, but merging and publishing to the DB is restricted to maintainers (~Secure team).
- [x] Add `README.md` to gemnasium-db (see https://gitlab.com/gitlab-org/security-products/gemnasium-db/merge_requests/1)
- [x] Add `CONTRIBUTING.md` to gemnasium-db (see https://gitlab.com/gitlab-org/security-products/gemnasium-db/merge_requests/2)
**This allows to achieve our goals:**
- search for our advisories by leveraging the built-in GitLab project's search
- contribute by:
- creating an issue to mention a missing advisory
- creating an MR to Add/Update an advisory
**Known limitations:**
* there is no way to fetch advisories reported by `bundler-audit` and `retire.js`, two other scanners of Dependency Scanning.
* at this point, the creation of new issues/MRs to add advisories to Gemnasium DB is still manual.
### Permissions and Security
- Depending under which License the project is published, the contribution on the DB enrichment could be restricted to EE users (having a EE License).
- Merging and publishing to the Gemnasium DB are restricted to ~Secure team members.
### Documentation
We need to update https://docs.gitlab.com/ee/user/application_security/dependency_scanning/index.html to clearly point to this new created project.
- [ ] Update GitLab CE doc https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/29205
We also need to document clearly how to contribute.
### Testing
Not sure there are things to cover here, except manually going through the published docs and validating the DB filling process.
### What does success look like, and how can we measure that?
People can see and contribute to the Gemnasium Advisories DB.
- How many search are executed in the project? (not sure this is achievable :thinking:)
- How many issues and MRs are created by people outside of the ~Secure team
### What is the type of buyer?
~"GitLab Ultimate"
### Links / references12.0Fabien Catteaufcatteau@gitlab.comFabien Catteaufcatteau@gitlab.comhttps://gitlab.com/gitlab-org/gitlab/-/issues/11098Find a better way to say "merge method, options, and checks"2019-11-06T18:10:30ZNathan Friendhello@nathanfriend.ioFind a better way to say "merge method, options, and checks"This is a follow up issue on this MR/discussion: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10491#note_158473709 to update the text that reads:
```
Choose your merge method, options, checks, and set up a default merge reques...This is a follow up issue on this MR/discussion: https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/10491#note_158473709 to update the text that reads:
```
Choose your merge method, options, checks, and set up a default merge request description template.
```
This text will appear in the project settings page under the **Merge requests** section.
Please use this issue to discuss the best way to express this thought!12.1Nathan Friendhello@nathanfriend.ioNathan Friendhello@nathanfriend.iohttps://gitlab.com/gitlab-org/gitlab/-/issues/27966Flaky spec: "Discussion Comments Issue behaves like discussion comments click...2020-06-16T09:06:33ZRémy CoutableFlaky spec: "Discussion Comments Issue behaves like discussion comments clicking "Comment" will post a comment" / spec/support/features/discussion_comments_shared_example.rb:19Job [#193445260](https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/193445260) failed for gitlab-ee@82522c68ed237e587c56dc0474114b5039cd4b74:
```
1) Discussion Comments Issue behaves like discussion comments clicking "Comment" will post a...Job [#193445260](https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/193445260) failed for gitlab-ee@82522c68ed237e587c56dc0474114b5039cd4b74:
```
1) Discussion Comments Issue behaves like discussion comments clicking "Comment" will post a comment
Failure/Error: find(comments_selector, match: :first)
Capybara::ElementNotFound:
Unable to find visible css ".timeline > .note.timeline-entry"
Shared Example Group: "discussion comments" called from ./spec/features/discussion_comments/issue_spec.rb:15
# ./spec/support/features/discussion_comments_shared_example.rb:19:in `block (2 levels) in <top (required)>'
```Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/11059Dependency List - Preliminary Frontend implementation2019-11-18T15:57:53ZLukas 'ai-pi' Eipertleipert@gitlab.comDependency List - Preliminary Frontend implementationSee https://gitlab.com/gitlab-org/gitlab-ee/issues/10075 for full context.
This issue is to track the Frontend implementation that will happen in %"11.11" to reduce the weight of the final implementation for https://gitlab.com/gitlab-or...See https://gitlab.com/gitlab-org/gitlab-ee/issues/10075 for full context.
This issue is to track the Frontend implementation that will happen in %"11.11" to reduce the weight of the final implementation for https://gitlab.com/gitlab-org/gitlab-ee/issues/10075
### Goals
- Put everything behind a feature flag
- Use Mock Data (either from a mocked JSON or a mocked API, see: https://gitlab.com/gitlab-org/gitlab-ee/issues/11060) to
- Requirement: Work out the data schema and the API with ~backend
- Preliminary design should be implemented:
- Requirement: Get a consensus on the design with ~UX
### Implementation plan
1. Bootstrap the new views behind a feature flag (page bundle entrypoint)
2. Implement the design as it stands with all functionality required by ~UX, mock out the responses12.0Mark Florianmflorian@gitlab.comAndy VolpeMark Florianmflorian@gitlab.comhttps://gitlab.com/gitlab-org/gitlab/-/issues/10996Refactor the security report mutations2019-11-18T15:57:53ZSam Beckhamsbeckham@gitlab.comRefactor the security report mutationsThis is already done in !9443 but we needed an issue to track it properly.
The security reports mutations have a lot of repeated code. This aims to fix some ~"technical debt" by making re-usable utilities and applying them to the mutati...This is already done in !9443 but we needed an issue to track it properly.
The security reports mutations have a lot of repeated code. This aims to fix some ~"technical debt" by making re-usable utilities and applying them to the mutations.
***Note**: The linked 9334 MR was a typo :face\_palm:*12.1Sam Beckhamsbeckham@gitlab.comSam Beckhamsbeckham@gitlab.comhttps://gitlab.com/gitlab-org/gitlab/-/issues/10951Fix the following style-lint errors and warnings for `ee/app/assets/styleshee...2019-08-12T15:02:51ZFilipa LacerdaFix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/projects.scss`## Problem
Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/projects.scss`
```
9:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend ...## Problem
Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/projects.scss`
```
9:3 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
99:7 ⚠ Expected ".security-dashboard .card-header .user-avatar-link .avatar" to have no more than 3 compound selectors selector-max-compound-selectors
127:3 ⚠ ".dropdown-item svg" and "svg (/ee/app/assets/stylesheets/pages/projects.scss -104:5)" have the same properties. stylelint-gitlab/duplicate-selectors
161:7 ⚠ Expected ".project-template .template-group-options .template-option .avatar-container" to have no more than 3 compound selectors selector-max-compound-selectors
175:7 ⚠ ".options-collapsed-icon" and ".options-expanded-icon (ee/app/assets/stylesheets/pages/projects.scss -153:5)" have the same properties. stylelint-gitlab/duplicate-selectors
183:7 ⚠ Expected ".project-template .template-input-group .selected-icon .avatar" to have no more than 3 compound selectors selector-max-compound-selectors
```
## What to do
1. If possible, replace the CSS class with a utility one, check [common.scss](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/framework/common.scss) and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
1. Double check if all the warning have been fixed by running `yarn run stylelint-file ee/app/assets/stylesheets/pages/projects.scss`
1. In the MR, add screenshots of the affected areas before and after the changes, check the [first MR](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26768) as a guideline
1. If there are a lot of changes, we recommend to break them into smaller MRs
1. Double check the usage of each changed class both in CE and EE
1. EE changes should either be backported into CE or moved into `ee/` folder. You can read more about how to handle EE code [here](https://docs.gitlab.com/ee/development/ee_features.html)
1. Label the MR with ~"CSS cleanup"12.2Denys Mishunovdmishunov@gitlab.comDenys Mishunovdmishunov@gitlab.comhttps://gitlab.com/gitlab-org/gitlab/-/issues/10950Fix the following style-lint errors and warnings for `ee/app/assets/styleshee...2021-02-03T19:00:12ZFilipa LacerdaFix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/pipelines.scss`## Problem
Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/pipelines.scss`
```
97:1 ⚠ ".has-linked-pipelines.stage-column-list" and ".linked-pipeline-mini-list (/Users/filipalacerda/Documents/g...## Problem
Fix the following style-lint errors and warnings for `ee/app/assets/stylesheets/pages/pipelines.scss`
```
97:1 ⚠ ".has-linked-pipelines.stage-column-list" and ".linked-pipeline-mini-list (/Users/filipalacerda/Documents/git/gdk-ee/gitlab/ee/app/assets/stylesheets/pages/pipelines.scss -1:1)" have the stylelint-gitlab/duplicate-selectors
same properties.
173:7 ⚠ Expected ".linked-pipelines-column.stage-column .linked-pipeline.build .linked-pipeline-content svg" to have no more than 3 compound selectors selector-max-compound-selectors
180:1 ⚠ ".stage-column.has-upstream" and "&.graph-position-right (/Users/filipalacerda/Documents/git/gdk-ee/gitlab/ee/app/assets/stylesheets/pages/pipelines.scss -120:3)" have the same properties. stylelint-gitlab/duplicate-selectors
```
## What to do
1. If possible, replace the CSS class with a utility one, check [common.scss](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/framework/common.scss) and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
1. Double check if all the warning have been fixed by running `yarn run stylelint-file ee/app/assets/stylesheets/pages/pipelines.scss`
1. In the MR, add screenshots of the affected areas before and after the changes, check the [first MR](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26768) as a guideline
1. If there are a lot of changes, we recommend to break them into smaller MRs
1. Double check the usage of each changed class both in CE and EE
1. EE changes should either be backported into CE or moved into `ee/` folder. You can read more about how to handle EE code [here](https://docs.gitlab.com/ee/development/ee_features.html)
1. Label the MR with ~"CSS cleanup"12.3Payton BurdettePayton Burdettehttps://gitlab.com/gitlab-org/gitlab/-/issues/27870[FE] Add "What's new" menu item in top navigation2020-04-29T19:54:14ZDennis Tang[FE] Add "What's new" menu item in top navigationgitlab-ce~3412464 for https://gitlab.com/gitlab-org/gitlab-ce/issues/25341gitlab-ce~3412464 for https://gitlab.com/gitlab-org/gitlab-ce/issues/25341Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/10925Track clicks on project/group settings pages2023-10-16T20:54:06ZJeremy Watson (ex-GitLab)Track clicks on project/group settings pages### Overview
We'd like to better [understand how users are using settings pages](https://gitlab.com/gitlab-org/gitlab-ce/issues/60020). We need to track activity on individual settings pages, and should add [additional events to Snowplo...### Overview
We'd like to better [understand how users are using settings pages](https://gitlab.com/gitlab-org/gitlab-ce/issues/60020). We need to track activity on individual settings pages, and should add [additional events to Snowplow](https://about.gitlab.com/handbook/product/feature-instrumentation/#adding-events-to-snowplow) to help understand which settings sections may need refactoring.
### Proposal
* Track clicks on "Expand" on all project/group settings pages.
* Track clicks on "Save changes" for each expandable section.Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/27795Fix the following style-lint errors and warnings for `app/assets/stylesheets/...2020-05-22T11:16:58ZFilipa LacerdaFix the following style-lint errors and warnings for `app/assets/stylesheets/pages/pipelines.scss`## Problem
Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/pipelines.scss`
```
68:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn-default" to have no more than 3 compound selectors ...## Problem
Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/pipelines.scss`
```
68:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn-default" to have no more than 3 compound selectors selector-max-compound-selectors
72:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn.btn-retry:hover" to have no more than 3 compound selectors selector-max-compound-selectors
72:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn.btn-retry:focus" to have no more than 3 compound selectors selector-max-compound-selectors
78:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions svg path" to have no more than 3 compound selectors selector-max-compound-selectors
82:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .dropdown-menu" to have no more than 3 compound selectors selector-max-compound-selectors
87:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .dropdown-toggle" to have no more than 3 compound selectors selector-max-compound-selectors
87:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .dropdown-menu" to have no more than 3 compound selectors selector-max-compound-selectors
87:7 ⚠ ".dropdown-toggle, .dropdown-menu" and ".btn-default (app/assets/stylesheets/pages/pipelines.scss -68:7)" have the stylelint-gitlab/duplicate-selectors
same properties.
91:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
91:9 ⚠ Expected ".pipelines .ci-table .pipeline-actions .dropdown-toggle .fa" to have no more than 3 compound selectors selector-max-compound-selectors
91:9 ⚠ Expected ".pipelines .ci-table .pipeline-actions .dropdown-menu .fa" to have no more than 3 compound selectors selector-max-compound-selectors
97:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn-group.open .btn-default" to have no more than 3 compound selectors selector-max-compound-selectors
102:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .btn .text-center" to have no more than 3 compound selectors selector-max-compound-selectors
106:7 ⚠ Expected ".pipelines .ci-table .pipeline-actions .tooltip" to have no more than 3 compound selectors selector-max-compound-selectors
184:7 ⚠ Expected ".ci-table .branch-commit .label-container .badge" to have no more than 3 compound selectors selector-max-compound-selectors
292:5 ⚠ Expected ".stage-cell .stage-container button.has-tooltip + .tooltip" to have no more than 3 compound selectors selector-max-compound-selectors
297:5 ⚠ "a.has-tooltip" and ".tooltip (app/assets/stylesheets/pages/pipelines.scss -106:7)" have the same properties. stylelint-gitlab/duplicate-selectors
319:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
346:5 ⚠ Expected ".tab-pane .ci-table thead th" to have no more than 3 compound selectors selector-max-compound-selectors
487:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
505:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
509:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
513:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
513:9 ⚠ Expected ".pipeline-graph .stage-column:last-child:not(.has-downstream) .build .curve::before" to have no more than 3 compound selectors selector-max-compound-selectors
523:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
527:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
527:9 ⚠ Expected ".pipeline-graph .stage-column:first-child:not(.has-upstream) .build .curve::after" to have no more than 3 compound selectors selector-max-compound-selectors
578:7 ⚠ Expected ".pipeline-graph .build .ci-job-dropdown-container .dropdown-menu li button" to have no more than 3 compound selectors selector-max-compound-selectors
585:5 ⚠ Expected ".pipeline-graph .build .ci-job-dropdown-container:hover .build-content" to have no more than 3 compound selectors selector-max-compound-selectors
586:7 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
589:5 ⚠ Expected ".pipeline-graph .build .ci-status-icon svg" to have no more than 3 compound selectors selector-max-compound-selectors
686:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
698:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
794:4 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
835:3 ⚠ "&.dropdown-menu li button, &.dropdown-menu li a.ci-action-icon-container" and ".dropdown-menu li button stylelint-gitlab/duplicate-selectors
(app/assets/stylesheets/pages/pipelines.scss -578:7)" have the same properties.
859:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
859:9 ⚠ "svg" and "svg (app/assets/stylesheets/pages/pipelines.scss -686:9)" have the same properties. stylelint-gitlab/duplicate-selectors
890:5 ⚠ Expected ".big-pipeline-graph-dropdown-menu li:hover > .ci-job-component > .mini-pipeline-graph-dropdown-item" to have no more than 3 compound selectors selector-max-compound-selectors
890:5 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li:hover > .ci-job-component > .mini-pipeline-graph-dropdown-item" to have no more than 3 compound selectors selector-max-compound-selectors
892:7 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
909:7 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-job-name-component" to have no more than 3 compound selectors selector-max-compound-selectors
909:7 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-job-name-component" to have no more than 3 compound selectors selector-max-compound-selectors
916:7 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-build-text" to have no more than 3 compound selectors selector-max-compound-selectors
916:7 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-build-text" to have no more than 3 compound selectors selector-max-compound-selectors
916:7 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-text" to have no more than 3 compound selectors selector-max-compound-selectors
916:7 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-text" to have no more than 3 compound selectors selector-max-compound-selectors
926:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
926:9 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-build-text::after" to have no more than 3 compound selectors selector-max-compound-selectors
926:9 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-build-text::after" to have no more than 3 compound selectors selector-max-compound-selectors
926:9 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-text::after" to have no more than 3 compound selectors selector-max-compound-selectors
926:9 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-text::after" to have no more than 3 compound selectors selector-max-compound-selectors
936:7 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-icon" to have no more than 3 compound selectors selector-max-compound-selectors
936:7 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-icon" to have no more than 3 compound selectors selector-max-compound-selectors
936:7 ⚠ ".ci-status-icon" and "li (app/assets/stylesheets/pages/pipelines.scss -886:3)" have the same properties. stylelint-gitlab/duplicate-selectors
937:9 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
941:9 ⚠ Expected nesting depth to be no more than 3 max-nesting-depth
941:9 ⚠ Expected ".big-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-icon > svg" to have no more than 3 compound selectors selector-max-compound-selectors
941:9 ⚠ Expected ".mini-pipeline-graph-dropdown-menu li .mini-pipeline-graph-dropdown-item .ci-status-icon > svg" to have no more than 3 compound selectors selector-max-compound-selectors
1054:3 ⚠ ".content-block" and ".pipeline-actions (app/assets/stylesheets/pages/pipelines.scss -336:1)" have the same properties. stylelint-gitlab/duplicate-selectors
1084:1 ⚠ Expected ".pipelines-container .top-area .nav-controls > .btn:last-child" to have no more than 3 compound selectors selector-max-compound-selectors
1093:1 ⚠ ".legend-all" and ".dropdown-toggle, .dropdown-menu (app/assets/stylesheets/pages/pipelines.scss -87:7)" have the stylelint-gitlab/duplicate-selectors
same properties.
```
## What to do
1. If possible, replace the CSS class with a utility one, check [common.scss](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/framework/common.scss) and https://getbootstrap.com/docs/4.3/utilities/ for existing ones
1. Double check if all the warning have been fixed by running `yarn run stylelint-file `app/assets/stylesheets/pages/pipelines.scss`
1. In the MR, add screenshots of the affected areas before and after the changes, check the [first MR](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/26768) as a guideline
1. If there are a lot of changes, we recommend to break them into smaller MRs
1. Double check the usage of each changed class both in CE and EE
1. EE changes should either be backported into CE or moved into `ee/` folder. You can read more about how to handle EE code [here](https://docs.gitlab.com/ee/development/ee_features.html)
1. Label the MR with gitlab-ce~10109752BacklogSarah Groff Hennigh-PalermoSarah Groff Hennigh-Palermohttps://gitlab.com/gitlab-org/gitlab/-/issues/27791Fix the following style-lint errors and warnings for `app/assets/stylesheets/...2022-09-21T18:53:57ZFilipa LacerdaFix the following style-lint errors and warnings for `app/assets/stylesheets/pages/merge_requests.scss`## Problem
Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/merge_requests.scss`
```
239:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-plac...## Problem
Fix the following style-lint errors and warnings for `app/assets/stylesheets/pages/merge_requests.scss`
```
239:5 ⚠ Expected a placeholder selector (e.g. %placeholder) to be used in @extend scss/at-extend-no-missing-placeholder
411:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
412:1 ⚠ Selector should be written in lowercase with hyphens selector-class-pattern
```
## What to do
1. If possible, replace the CSS class with a utility one, check [common.scss](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/assets/stylesheets/framework/common.scss) and https://getbootstrap.com/docs/4.4/utilities/ for existing ones
1. Double check if all the warning have been fixed by running `yarn run stylelint-file app/assets/stylesheets/pages/merge_requests.scss`
1. In the MR, add screenshots of the affected areas before and after the changes, check the [first MR](https://gitlab.com/gitlab-org/gitlab-foss/-/merge_requests/26768) as a guideline
1. If there are a lot of changes, we recommend to break them into smaller MRs
1. Double check the usage of each changed class both in CE and EE
1. EE changes should either be backported into CE or moved into `ee/` folder. You can read more about how to handle EE code [here](https://docs.gitlab.com/ee/development/ee_features.html)
1. Label the MR with ~"CSS cleanup"Backloghttps://gitlab.com/gitlab-org/gitlab/-/issues/10798Get rid of dind for DAST2020-01-21T19:55:20ZPhilippe LafoucrièreGet rid of dind for DASTDAST is only requiring dind since 11.9, and the introduction of the vendored templates: https://docs.gitlab.com/ee/ci/examples/dast.html#prerequisites
We can probably get rid of https://gitlab.com/gitlab-org/gitlab-ee/blob/master/lib/gi...DAST is only requiring dind since 11.9, and the introduction of the vendored templates: https://docs.gitlab.com/ee/ci/examples/dast.html#prerequisites
We can probably get rid of https://gitlab.com/gitlab-org/gitlab-ee/blob/master/lib/gitlab/ci/templates/Security/DAST.gitlab-ci.yml#L35
to pass the variables directly to the `dast` image.
see https://gitlab.com/groups/gitlab-org/-/epics/971 for previous comments12.0Philippe LafoucrièrePhilippe Lafoucrièrehttps://gitlab.com/gitlab-org/gitlab/-/issues/10795View epic tree in epic2022-05-19T16:10:12ZVictor Wuvictor@gitlab.comView epic tree in epic
### Designs
| Discussion tab | Tree tab | Roadmap tab |
| ------ | ------ | ------ |
| ![Artboard_Copy_9](https://gitlab.com/gitlab-org/gitlab/uploads/657aca5a351e64af368954bcbdac7ee9/Artboard_Copy_9.png) | ![Screen_Shot_2019-03-27_at_...
### Designs
| Discussion tab | Tree tab | Roadmap tab |
| ------ | ------ | ------ |
| ![Artboard_Copy_9](https://gitlab.com/gitlab-org/gitlab/uploads/657aca5a351e64af368954bcbdac7ee9/Artboard_Copy_9.png) | ![Screen_Shot_2019-03-27_at_7.26.19_AM](https://gitlab.com/gitlab-org/gitlab/uploads/2bedf2374c75ddcee2167338c5953239/Screen_Shot_2019-03-27_at_7.26.19_AM.png) | ![Screen_Shot_2019-03-27_at_7.29.33_AM](https://gitlab.com/gitlab-org/gitlab/uploads/00c08e7912477235b9566ab24f09b026/Screen_Shot_2019-03-27_at_7.29.33_AM.png) |
* First tab is discussion - comments, threads, and system notes
* Second tab is the tree view. All epics and issues nested under the current epic should be viewable, collapsible, ~~and draggable~~ (see https://gitlab.com/gitlab-org/gitlab-ee/issues/7327#note_151840087)
* Removing an epic also removes all of its nested epics from the _current epic only_ (it doesn't break existing relationships between epics)
* Dialog to confirm removal
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->
*This page may contain information related to upcoming products, features and functionality.
It is important to note that the information presented is for informational purposes only, so please do not rely on the information for purchasing or planning purposes.
Just like with all projects, the items mentioned on the page are subject to change or delay, and the development, release, and timing of any products, features, or functionality remain at the sole discretion of GitLab Inc.*
<!-- triage-serverless v3 PLEASE DO NOT REMOVE THIS SECTION -->12.1Brett WalkerAnnabel Dunstone GrayKushal Pandyakushal@gitlab.comRussell DickensonBrett Walkerhttps://gitlab.com/gitlab-org/gitlab/-/issues/27675Test plan for "Related merge requests in issue design - New elements"2019-09-25T14:06:24ZWalmyr Lima e Silva FilhoTest plan for "Related merge requests in issue design - New elements"# Test Plan
Below you will find the test plan for the feature "Related merge requests in issue design - New elements", that is part of 11.11 milestone.
## Introduction
More useful information will be added to the "Related merge reques...# Test Plan
Below you will find the test plan for the feature "Related merge requests in issue design - New elements", that is part of 11.11 milestone.
## Introduction
More useful information will be added to the "Related merge requests" widget/component, such as status, path and ID, title (with a link to the merge request), assignees, items left to allow merge, and pipeline status.
This test plan is related to the issue https://gitlab.com/gitlab-org/gitlab-ce/issues/51862
## Scope
### Intuitive
It should be easy to identify the below items of the related MR in a first glance:
* status
* path and ID
* linkable title
* assignees
* items left to allow merge
* pipeline status
### Functional
* It should be possible to see the related MRs in all their [possible status](https://docs.gitlab.com/ee/api/merge_requests.html)
* When hovering over the related MR status, a tooltip should be shown with information such as status text (e.g., opened 1 hour ago), and date and time. https://gitlab-org.gitlab.io/gitlab-design/hosted/pedro/%2383-issue-mr-rows-cards-spec-previews/#artboard0
* When clicking in the linkable title of a related MR, the user should be correctly redirected to the related MR page
* When hovering over the assignee's avatars the information about who they are should be shown
* When clicking the assignee's avatar, the user should be correctly redirected to the user's profile
* When three people are assigned to a related MR, the avatars of all of them should be shown
* When more than three people are assigned to a related MR, the avatars of two of them should be shown, and the third icon should indicate how many more people are assigned (e.g., +2).
* In the case of more than three people assigned to a related MR, when hovering over the icon that indicates that more people are assigned, a tooltip should be shown indicating how many more assignees are (e.g., 2 more assignees). https://gitlab.com/gitlab-org/gitlab-ce/issues/51862#note_157859677
* The count of items left to allow merge should be correctly displayed
* When hovering over the items left to allow merge, and there are items left, a tooltip should be opened, and it should show a text of how many items are left to allow merge (e.g., 7 items left to allow merge); it should show an icon and text about approval required; and it should show an icon and text for the discussions resolved (e.g., 2/8 resolved discussions) https://gitlab.com/gitlab-org/gitlab-ce/issues/51862#note_157862838
* When there are merge conflicts, such information should be shown when hovering over the items left to allow merge. (https://gitlab.com/gitlab-org/gitlab-ce/issues/51862#note_157862838)
* When hovering over the items left to allow merge and all items are resolved, a tooltip should be shown informing that it is good to merge. https://gitlab.com/gitlab-org/gitlab-ce/issues/51862#note_157862838
* When hovering over the items left to allow merge and no items were left to resolve, such information should be shown. https://gitlab.com/gitlab-org/gitlab-ce/issues/51862#note_157862838
* It should be possible to see all the possible [pipeline status](https://docs.gitlab.com/ce/api/pipelines.html) of a related MR
* When clicking in the pipeline status, it should expand so that the user can see the executed jobs, and the pipeline jobs should be clickable. When clicking the pipeline jobs the user should be correctly redirected to the job pipeline page.
## ACC Matrix
Attributes (columns) are adverbs or adjectives that describe (at a high level)
the qualities testing is meant to ensure Components have.
Components (rows) are nouns that define major parts of the product being tested.
Capabilities link Attributes and Components. They are what your product needs to
do to make sure a Component fulfills an Attribute
For more information see the [Google Testing Blog article about the 10 minute
test plan](https://testing.googleblog.com/2011/09/10-minute-test-plan.html) and
[this wiki page from an open-source tool that implements the ACC
model](https://code.google.com/archive/p/test-analytics/wikis/AccExplained.wiki).
| | Intuitive | Functional |
|------------ |:---------:|:----------:|
| Related MRs | 6 | 15 |
## Capabilities
* Related MRs
* See scope info above.
## Test Plan
When adding new automated tests, please keep [testing levels](https://docs.gitlab.com/ce/development/testing_guide/testing_levels.html)
in mind.12.4https://gitlab.com/gitlab-org/gitlab/-/issues/10783Refactor vue-router/vuex synchronisation/persistence in Security Dashboard2019-11-18T15:57:53ZMark Florianmflorian@gitlab.comRefactor vue-router/vuex synchronisation/persistence in Security DashboardCurrently the [router](https://gitlab.com/gitlab-org/gitlab-ee/blob/v11.9.1-ee/ee/app/assets/javascripts/security_dashboard/store/router.js) in the Security Dashboard does not manage any components, which means that synchronising it with...Currently the [router](https://gitlab.com/gitlab-org/gitlab-ee/blob/v11.9.1-ee/ee/app/assets/javascripts/security_dashboard/store/router.js) in the Security Dashboard does not manage any components, which means that synchronising it with the store can be a bit more awkward than it should be. It has standard means of passing query parameters down to components, which we cannot use.
This issue is about exploring a more elegant way to persist state in the URL.12.5Mark Florianmflorian@gitlab.comMark Florianmflorian@gitlab.com