## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/work_items/637347) currently behind the `limit_secrets_managers_per_root_namespace` feature flag. - DRI: @iamricecake - Team Slack channel: `#sec-secrets-manager-application` - MR: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/268549 > [!note] > Process and guidance live in the docs. This issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability. It is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## How enforcement works Enforcement needs **both**: 1. The flag enabled for the top-level group (the actor is the root namespace). 1. The `root_namespace_secrets_managers_limit` application setting above `0`. The default is `0` (no limit). When both are on, a top-level group that has reached the limit can't enable a new secrets manager. Existing secrets managers keep working. ## What could go wrong? - If the limit is too low, real customers can't enable new secrets managers. They see `Secrets manager limit reached for this top-level group.` - Each initialize runs two indexed `COUNT` queries with `LIMIT`. The cost is small. - Two parallel enables can both pass the check, so a group can go over the limit by a small number. This is expected. ## Before enabling - [ ] MR merged and deployed - [ ] Query the current maximum number of secrets managers per top-level group on GitLab.com, and pick a limit above it - [ ] Set `root_namespace_secrets_managers_limit` on staging - [ ] Set `root_namespace_secrets_managers_limit` on production (through a change request if needed) ## Events - [Exceptions with limit_secrets_managers_per_root_namespace:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.exception.feature_flag_states.keyword:%22limit_secrets_managers_per_root_namespace:1%22'),columns:!(json.exception.class,json.exception.message,json.extra.workflow_id,json.meta.caller_id),sort:!(!(json.time,desc)))) - [Events with limit_secrets_managers_per_root_namespace:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.feature_flag_states:%22limit_secrets_managers_per_root_namespace:1%22'),columns:!(json.meta.caller_id,json.feature_flag_states),sort:!(!(json.time,desc)))) - [Error rate and other graphs by modifying the examples in the Visualization Library](https://log.gprd.gitlab.net/app/visualize#/?_g=h@358d019&s=FF%20Observability) Feature Flag events are only logged by default for feature flags marked for the current or future milestones. To enable while the feature flag is active, see https://docs.gitlab.com/development/feature_flags/#logging ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#sec-secrets-manager-application`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set limit_secrets_managers_per_root_namespace 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set limit_secrets_managers_per_root_namespace true --dev --pre --staging --staging-ref ``` **Production**, first for a test group: ``` /chatops gitlab run feature set --group=gitlab-org limit_secrets_managers_per_root_namespace true ``` Then percentage rollout (wait at least 15 minutes between steps, watch dashboards): ``` /chatops gitlab run feature set limit_secrets_managers_per_root_namespace <percentage> --actors ``` ## Before global rollout Confirm the relevant gotchas before going to 100%. See [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle). See [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete limit_secrets_managers_per_root_namespace --dev --pre --staging --staging-ref --production ``` ## Rollback Disabling the flag stops enforcement right away. Setting `root_namespace_secrets_managers_limit` back to `0` does the same. ``` /chatops gitlab run feature set limit_secrets_managers_per_root_namespace false # production /chatops gitlab run feature set limit_secrets_managers_per_root_namespace false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete limit_secrets_managers_per_root_namespace --dev --pre --staging --staging-ref --production # remove entirely ```