## Summary Roll out the Vue group **Settings > General > Naming, description, visibility** form currently behind the `group_general_settings_vue` feature flag. With the flag off, the server-rendered HAML form is used. Introduced by https://gitlab.com/gitlab-org/gitlab/-/merge_requests/262108. Mirrors the project form rollout in https://gitlab.com/gitlab-org/gitlab/-/work_items/608582. - DRI: @seggenberger > [!note] > Process and guidance live in the docs. This issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability. It is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? - Saving the form fails or drops fields (name, description, avatar, repository size limit, visibility level), because the Vue form posts a native multipart form to `GroupsController#update`. - Avatar removal: `Groups::UpdateService` now maps an empty `avatar` param to `remove_avatar`. A regression could remove avatars unexpectedly or fail to remove them. - Visibility levels: disabled levels and their reasons (admin restriction, parent group, organization, less restrictive child) are computed in `GroupsHelper#group_disabled_visibility_levels`. A mismatch with the HAML logic could let users pick a level the server then rejects. - Users without `change_visibility_level` must see the level read-only and must not submit `group[visibility_level]`. - E2E: the save button testid changes from `save-name-visibility-settings-button` to `save-group-general-settings-button`. The QA page object `QA::Page::Group::Settings::General` handles both. Rollback is safe: disabling the flag restores the HAML form with no data migration. ## Blockers Do not enable the flag anywhere until these are merged: - [ ] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/264620: on GitLab.com, the **Public** visibility description showed escaped `<a>` HTML in the Vue form ([review note](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/262108#note_4072067784)). ## Events - [Exceptions with group_general_settings_vue:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.exception.feature_flag_states.keyword:%22group_general_settings_vue:1%22'),columns:!(json.exception.class,json.exception.message,json.extra.workflow_id,json.meta.caller_id),sort:!(!(json.time,desc)))) - [Events with group_general_settings_vue:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.feature_flag_states:%22group_general_settings_vue:1%22'),columns:!(json.meta.caller_id,json.feature_flag_states),sort:!(!(json.time,desc)))) - [Error rate and other graphs by modifying the examples in the Visualization Library](https://log.gprd.gitlab.net/app/visualize#/?_g=h@358d019&s=FF%20Observability) Feature Flag events are only logged by default for feature flags marked for the current or future milestones. To enable while the feature flag is active, see https://docs.gitlab.com/development/feature_flags/#logging ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to the team channel. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). - [ ] Non-production ``` /chatops gitlab run feature set group_general_settings_vue 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set group_general_settings_vue true --dev --pre --staging --staging-ref ``` - [ ] Production, specific actors first: ``` /chatops gitlab run feature set --group=gitlab-org,gitlab-com group_general_settings_vue true ``` - [ ] Production, percentage rollout (wait at least 15 min between steps, watch dashboards): ``` /chatops gitlab run feature set group_general_settings_vue <percentage> --actors ``` ## Before global rollout Confirm the relevant gotchas before going to 100%. See [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle). See [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Remove the flag and its YAML definition (`config/feature_flags/gitlab_com_derisk/group_general_settings_vue.yml`), together with: **Code** - [ ] The HAML form branch in `app/views/groups/settings/_general.html.haml` - [ ] `initGroupNameValidation` wiring for this form - [ ] The `save-name-visibility-settings-button` fallback (and its `TODO`) in `qa/qa/page/group/settings/general.rb` - [ ] Any `shared/` HAML partials that become unused once the group form no longer renders them (for example `shared/_visibility_level` / `shared/_visibility_radios` and `shared/_repository_size_limit_setting*`). Check for other callers first. - [ ] Regenerate `locale/gitlab.pot` for strings that only the HAML form used. **Specs** (every spec that stubs `group_general_settings_vue`): - [ ] `spec/views/groups/settings/_general.html.haml_spec.rb`: drop the flag-off contexts and the flag-on wrapper, keep the Vue mount point assertions. - [ ] `spec/features/groups/settings/general_spec.rb`: `edit group avatar` tests HAML-only fields. Delete it (the Vue path is covered in `user_uploads_avatar_to_group_spec.rb`) or rewrite it against the Vue form. - [ ] `spec/features/groups/settings/general_visibility_levels_spec.rb`: delete the flag-off examples that test the HAML popovers, keep the flag-on context and remove its stub. - [ ] `spec/features/uploads/user_uploads_avatar_to_group_spec.rb`: delete the `with the HAML form` context, keep `with the Vue form` and remove its stub. - [ ] `spec/features/groups_spec.rb`: remove the stub in the `group edit` examples and update them for the Vue form. - [ ] Confirm nothing else references the flag: `git grep group_general_settings_vue` returns no results. Then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete group_general_settings_vue --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set group_general_settings_vue false # production /chatops gitlab run feature set group_general_settings_vue false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete group_general_settings_vue --dev --pre --staging --staging-ref --production # remove entirely ```