## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/work_items/462686) currently behind the `search_notes_use_query_builder` feature flag. The flag was introduced in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/261095. It is a `gitlab_com_derisk` flag, off by default, owned by group::global search, milestone 19.5. When the flag is on, note search in Advanced Search is built with the new `Search::Elastic::NoteQueryBuilder`. This covers the comments scope and the comment lookups that merge request and issue search use. When the flag is off, the legacy `ApplicationClassProxy` query hash is used. The legacy path stays for rollback. We expect search results to stay the same. We also expect blank or whitespace-only search terms to stop failing with `NoMethodError: undefined method 'concat' for nil` (Sentry GITLABCOM-FJD9). One example is `GET /api/v4/projects/:id/search?scope=merge_requests&search=%20`. Known, intended differences: - The archived filter's named query changes from `note:archived:non_archived` to `filters:non_archived`. - Advanced-syntax detection uses the shared regex that other scopes use. For example, `foo-bar` is no longer treated as advanced syntax. `#` and `!` now are. - DRI: @rkumar555 - Team Slack channel: `#g_global_search` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? - Wrong authorization in note results. Users could see notes they should not see, or miss notes they should see. - Errors when building or running note queries. - Slower note search or merge request search. How to detect problems: - New errors in Sentry for the global_search feature category. Look in particular at `Search::Elastic::NoteQueryBuilder` and `Search::Elastic::Filters`. - Elasticsearch query errors in the search logs. - Search latency for the notes and merge_requests scopes. GITLABCOM-FJD9 should stop recurring once the flag is fully on. To check on staging, run a comments search and a merge request search through the API. Use a normal term and a blank term. Run them with the flag on, then compare the results with the flag off. ## Events - [Exceptions with search_notes_use_query_builder:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.exception.feature_flag_states.keyword:%22search_notes_use_query_builder:1%22'),columns:!(json.exception.class,json.exception.message,json.extra.workflow_id,json.meta.caller_id),sort:!(!(json.time,desc)))) - [Events with search_notes_use_query_builder:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.feature_flag_states:%22search_notes_use_query_builder:1%22'),columns:!(json.meta.caller_id,json.feature_flag_states),sort:!(!(json.time,desc)))) - [Error rate and other graphs by modifying the examples in the Visualization Library](https://log.gprd.gitlab.net/app/visualize#/?_g=h@358d019&s=FF%20Observability) Feature Flag events are only logged by default for feature flags marked for the current or future milestones. To enable while the feature flag is active, see https://docs.gitlab.com/development/feature_flags/#logging ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_global_search`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set search_notes_use_query_builder 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set search_notes_use_query_builder true --dev --pre --staging --staging-ref ``` **Production** — percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set search_notes_use_query_builder <percentage> --actors ``` Or target specific users instead (the flag's actor is the current user, so project and group actors have no effect): ``` /chatops gitlab run feature set --user=rkumar555 search_notes_use_query_builder true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete search_notes_use_query_builder --dev --pre --staging --staging-ref --production ``` ## Rollback Disable the flag. The legacy path is unchanged. ``` /chatops gitlab run feature set search_notes_use_query_builder false # production /chatops gitlab run feature set search_notes_use_query_builder false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete search_notes_use_query_builder --dev --pre --staging --staging-ref --production # remove entirely ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code)