<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/engineering/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Label this issue](https://contributors.gitlab.com/manage-issue?action=label&projectId=278964&issueIid=631503) </details> <!--IssueSummary end--> ## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/work_items/630476) currently behind the `allow_flow_originated_cloud_event_triggers` feature flag. By default, cloud events caused by a flow acting with a composite identity (for example, a work item status change made by a flow) do not start flow triggers. When this flag is enabled for a project, those events start flow triggers as before. Events caused by users are not affected. Introduced in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/258734. This flag is enabled only for selected projects that need a flow's actions to start other flows, until bounded flow chaining (https://gitlab.com/gitlab-org/gitlab/-/work_items/630476) is available. It is not planned for a global rollout. Once chaining is available, remove the flag. - DRI: @igor.drozdov - Team Slack channel: `#s_agent-foundations` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? - In projects where the flag is enabled, a flow's action can start another flow through an event trigger (work item created or status changed, merge request created, ready, approved, merged, or code conflict). Keep the list of enabled projects short and tracked in this issue. - In projects where the flag is disabled, those events skip flow triggers. Search Sidekiq logs for `json.message: "Event caused by a flow, skipping flow triggers."` to find projects that may need the flag. - No data is changed or deleted. Enabling or disabling the flag takes effect immediately. ## Events - [Exceptions with allow_flow_originated_cloud_event_triggers:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.exception.feature_flag_states.keyword:%22allow_flow_originated_cloud_event_triggers:1%22'),columns:!(json.exception.class,json.exception.message,json.extra.workflow_id,json.meta.caller_id),sort:!(!(json.time,desc)))) - [Events with allow_flow_originated_cloud_event_triggers:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.feature_flag_states:%22allow_flow_originated_cloud_event_triggers:1%22'),columns:!(json.meta.caller_id,json.feature_flag_states),sort:!(!(json.time,desc)))) - [Error rate and other graphs by modifying the examples in the Visualization Library](https://log.gprd.gitlab.net/app/visualize#/?_g=h@358d019&s=FF%20Observability) Feature Flag events are only logged by default for feature flags marked for the current or future milestones. To enable while the feature flag is active, see https://docs.gitlab.com/development/feature_flags/#logging ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#s_agent-foundations`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). The actor is the project. **Non-production** — enable for test projects as needed: ``` /chatops gitlab run feature set --project=<project-path> allow_flow_originated_cloud_event_triggers true --dev --pre --staging --staging-ref ``` **Production** — enable only for specific projects, and list each one here: ``` /chatops gitlab run feature set --project=<project-path> allow_flow_originated_cloud_event_triggers true ``` Enabled projects: - [ ] _none yet_ ## Before global rollout Not planned. If that changes, confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once bounded flow chaining is available and [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete allow_flow_originated_cloud_event_triggers --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set --project=<project-path> allow_flow_originated_cloud_event_triggers false # one project /chatops gitlab run feature set allow_flow_originated_cloud_event_triggers false # production, all projects /chatops gitlab run feature set allow_flow_originated_cloud_event_triggers false --dev --pre --staging --staging-ref ```