## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/258638) currently behind the `refresh_member_authorizations_only_on_access_changes` feature flag. - DRI: @hmehra - Team Slack channel: `#g_scss_authorization` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? ### Risk - A code path could change access through a column outside the tracked list (`access_level`, `user_id`, `source_id`, `requested_at`, `state`), so a needed refresh gets skipped. - If a member is saved twice in one transaction, the last save might show no relevant changes and skip the refresh even though earlier changes mattered. - Either case leaves a user with stale `project_authorizations` (too much or too little access) until the next refresh. A low-priority safety-net refresh will eventually correct this for project members. ### Monitor - Sidekiq job volume for `AuthorizedProjectsWorker` and `AuthorizedProjectUpdate::ProjectRecalculatePerUserWorker` should drop (e.g. no jobs from token rotation) ([log link](https://log.gprd.gitlab.net/app/r/s/mBmlY)). - Rails logs: "Refresh member authorized projects on update" shows `previous_changes` for each member update ([log link](https://log.gprd.gitlab.net/app/r/s/ddzHR)). - Safety-net refresh logs the `authorized_projects_refresh` event with `rows_added_count`/`rows_deleted_count`. A rise here would mean refreshes are being missed ([log link](https://log.gprd.gitlab.net/app/r/s/qsdmV)). ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_scss_authorization`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set refresh_member_authorizations_only_on_access_changes 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set refresh_member_authorizations_only_on_access_changes true --dev --pre --staging --staging-ref ``` **Production** — percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set refresh_member_authorizations_only_on_access_changes <percentage> --actors ``` Or target specific actors instead: ``` /chatops gitlab run feature set --user=hmehra refresh_member_authorizations_only_on_access_changes true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete refresh_member_authorizations_only_on_access_changes --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set refresh_member_authorizations_only_on_access_changes false # production /chatops gitlab run feature set refresh_member_authorizations_only_on_access_changes false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete refresh_member_authorizations_only_on_access_changes --dev --pre --staging --staging-ref --production # remove entirely ```