<!-- Title suggestion: [FF] `randomize_notification_email_marker` -- <short description> --> ## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/issues/630361) currently behind the `randomize_notification_email_marker` feature flag. - DRI: @pedropombeiro - Team Slack channel: `#g_work_items` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? <!-- Optional but recommended: blast radius, data-loss risk, and the dashboard(s) you'll watch on https://dashboards.gitlab.net. Delete if not applicable. --> ## Events <!-- Replace feature flag name in the link--> - [Exceptions with randomize_notification_email_marker:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.exception.feature_flag_states.keyword:%22randomize_notification_email_marker:1%22'),columns:!(json.exception.class,json.exception.message,json.extra.workflow_id,json.meta.caller_id),sort:!(!(json.time,desc)))) - [Events with randomize_notification_email_marker:1](https://log.gprd.gitlab.net/app/discover#/?_g=(time:(from:now-1d,to:now))&_a=(index:'7092c4e2-4eb5-46f2-8305-a7da2edad090',query:(language:kuery,query:'json.feature_flag_states:%22randomize_notification_email_marker:1%22'),columns:!(json.meta.caller_id,json.feature_flag_states),sort:!(!(json.time,desc)))) - [Error rate and other graphs by modifying the examples in the Visualization Library](https://log.gprd.gitlab.net/app/visualize#/?_g=h@358d019&s=FF%20Observability) Feature Flag events are only logged by default for feature flags marked for the current or future milestones. To enable while the feature flag is active, see https://docs.gitlab.com/development/feature_flags/#logging ## Rollout ### Rollout coverage `--project` targets notifications with `@project`; percentage `--actors` uses the same project actor. Project-less notifications, such as SSH-expiry emails, retain timestamp markers even at `100 --actors`. Global `true` enables random markers for them too. Validate a representative project-less notification after global enablement in non-production before the production global step. Direct SMTP/Gmail testing passed; Google Groups delivery validation remains pending. The flag now also covers the `mailer` layout notifications (approval, unapproval and auto-merge) from [Add random marker to mailer layout](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/259061). Because the flag is already enabled globally, these go live as soon as that MR deploys. Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_work_items`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set randomize_notification_email_marker 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set randomize_notification_email_marker true --dev --pre --staging --staging-ref ``` **Production** — percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set randomize_notification_email_marker <percentage> --actors ``` Or target specific projects instead: ``` /chatops gitlab run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss randomize_notification_email_marker true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable After validation, enable globally in production: ```text /chatops gitlab run feature set randomize_notification_email_marker true ``` ## Cleanup - [x] Deploy [Add random marker to mailer layout](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/259061). - [x] In Gmail, get two approvals from different approvers on one MR. Check that the second email keeps its details visible. - [x] Update the [flag removal MR](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/257776) to also remove the flag check from `mailer.html.haml`. Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> 19.5 /chatops gitlab run feature delete randomize_notification_email_marker --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set randomize_notification_email_marker false # production /chatops gitlab run feature set randomize_notification_email_marker false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete randomize_notification_email_marker --dev --pre --staging --staging-ref --production # remove entirely ``` <!-- Uncomment the appropriate type label /label ~"type::feature" ~"feature::addition" /label ~"type::maintenance" /label ~"type::bug" -->