## Problem Two admin pages are addressed by the replicable name and resolve `uploads` through the legacy `Geo::UploadReplicator`: - `/admin/geo/sites/:id/replication/uploads`, the replication details page for a site. - `/admin/data_management/uploads`, the Data management page on the primary. Event B (#628308) disables the legacy replicator by default in 19.6. From then on, the replication page redirects to the Geo Sites page with "Replication of Uploads is disabled on this site." (#628311). That notice is misleading, because uploads still replicate through the 23 partitions. The Data management page returns 200, but its Vue app crashes (#633443). Once #628552 removes `Geo::UploadReplicator` in 19.8, both URLs return 404. Both URLs appear in bookmarks and runbooks, and nothing on them points an administrator to the 23 partition pages. This is part of the switchover sub-epic &23525 under &20933. ## Proposal Keep both URLs and make them overview pages: one row per enabled upload partition, linking to that partition's own page. The first iteration is deliberately minimal, a title and a link per row. The `replicable_group` value added by #628122 (`'uploads'` for the partitions) drives the overview, so a future group needs no controller changes. The pages have no client-side behaviour, so they are plain HAML. While the legacy replicator is enabled (dual-run, or a site that re-enables `geo_upload_replication`), `uploads` keeps showing the legacy page. The Geo Sites dashboard follows the same rule: it hides the partitions while the legacy replicable is enabled (!258456). Both pages resolve a name in this order: 1. An enabled replicable with that name renders its own page. 1. Otherwise, a `replicable_group` with at least one enabled member renders the overview. 1. Otherwise, the current behaviour applies: the #628311 redirect on the replication page, the #633443 redirect on the Data management page, or 404 for unknown names. No new feature flag is needed. The overview appears only once the legacy flag is off, which Event B controls. ## Implementation plan **Shared** - [x] Move `replicable_group` from `EE::GeoHelper` to the replicator. `Gitlab::Geo::Replicator.replicable_group` returns `nil`, and `Geo::Concerns::UploadReplicatorBehavior` returns `'uploads'` when `model < ::Upload`, which excludes the legacy replicator. Add `replicable_group_title` (`s_('Geo|Uploads')`) next to it. `replicable_class_data` calls the class method, so the Geo Sites payload is unchanged. - [ ] Add one shared partial, for example `ee/app/views/shared/geo/_replicable_group_overview.html.haml`, that renders a `Layouts::CrudComponent` with one link per row. Both pages pass it the group title and a list of title and path pairs. **Replication page** - [ ] In `Admin::Geo::ReplicablesController`, add an `index`-only `before_action` that runs before `set_replicator_class` and renders the overview when the order above selects it. Running before `set_replicator_class` keeps the overview working in 19.8, when resolving `upload` raises `NotImplementedError`. - [ ] Build the rows from `Gitlab::Geo.replication_enabled_replicator_classes` filtered by `replicable_group`, showing `replicable_title_plural` and linking to `site_replicables_admin_geo_node_path`. - [ ] Keep the current redirect for the legacy route without a site ID (`/admin/geo/replication/uploads`). Extract it from `index` so the group branch reuses it. - [ ] Add request specs in `ee/spec/requests/admin/geo/replicables_controller_spec.rb`: - [ ] `uploads` with the legacy replicator disabled lists the enabled partitions and omits disabled ones. - [ ] `uploads` with the legacy replicator enabled renders the legacy page. - [ ] `uploads` renders the overview when `Geo::UploadReplicator` cannot be resolved. - [ ] `uploads` with every partition disabled keeps the #628311 redirect. - [ ] A partition slug renders its own page, and an unknown slug returns 404. - [ ] The legacy route without a site ID redirects as before. **Data management page** - [ ] In `Admin::DataManagementController`, add an `index`-only `before_action` that runs before `model_found?` and applies the same order, with `Gitlab::Geo::ModelMapper.available_replicable_models` as the list of enabled models. Running first keeps the overview working in 19.8, when `find_from_name('upload')` returns `nil`. #633443 adds a disabled-model redirect to `model_found?`; the group branch must run before it, whichever MR merges first. - [ ] Build the rows from `model_type_data` for the enabled member models, showing `title_plural` and linking to `list_admin_data_management_path`. - [ ] Add request specs in `ee/spec/requests/admin/data_management_controller_spec.rb`: - [ ] `uploads` with the legacy replicator disabled lists the enabled partition models. - [ ] `uploads` with the legacy replicator enabled renders the existing list page. - [ ] `uploads` renders the overview when `find_from_name('upload')` returns `nil`. - [ ] A partition model name, such as `geo_project_uploads`, renders its list page, and an unknown name returns 404. **API documentation, separate docs MR** - [ ] Add the 23 partition model names to the `:model_name` list in `doc/api/admin/data_management.md`. The list has been out of date since Event A enabled the partitions, so this MR can merge now. Keep `uploads` until #628552 removes it. ## Out of scope, possible follow-ups - Linking the grouped Geo Sites dashboard row to the overview. The group title is the expand toggle, so a link needs its own control and a design decision. - Synced and verified progress bars on the overview rows. - Friendlier Data management model names than `geo_project_uploads`, via `Gitlab::Geo::ModelMapper.convert_to_name`. - Grouping the 23 upload entries in the replicable picker dropdown on the details pages. - Redirecting `/admin/geo/sites/:id/replication/uploads/:replicable_id` to the matching partition's details page. ## Dependencies - Blocked by #628122 for the `replicable_group` field. - Blocks #628308. Both pages must work before the legacy replicator is disabled by default.