<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/engineering/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Label this issue](https://contributors.gitlab.com/manage-issue?action=label&projectId=278964&issueIid=628124) - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=628124) </details> <!--IssueSummary end--> ### Summary Managed Settings added a validation that runs during initializer against the Application Settings. When the newly introduced column also has a validation, the migration may fail because before the migration is run, the initializer triggers the validation and we get a `NoMethodError`. This only affects installations with managed settings enabled (a file `config/managed_settings.yml` must be present) ### Steps to reproduce Generic: 1. Add a new migration to the application_settings that includes a new column 2. Add a validation to such column 3. Try to run the migration Specific: 1. Create `config/managed_settings.yml`: ``` installation: managed_by: "GitLab Helm Chart" managed_settings: sidekiq_timezone_override: "Europe/Lisbon" ``` 1. Run `rake db:migrate:down:main VERSION=20260818090000` 2. Run `rake db:migrate` ### What is the current *bug* behavior? The Managed Settings `.apply!` logic, that is run during initialization doesn't check whether there is a pending migration, and therefore, runs its code, which triggers the validation and the exception. ### What is the expected *correct* behavior? Running migration shouldn't fail ### Relevant logs and/or screenshots ``` rake aborted! NoMethodError: undefined method `code_dropdown_custom_clients' for an instance of ApplicationSetting (NoMethodError) Did you mean? code_dropdown_template_labels /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/attribute_methods.rb:512:in `method_missing' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activerecord-7.2.3.1/lib/active_record/attribute_methods.rb:495:in `method_missing' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validator.rb:152:in `block in validate' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validator.rb:151:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validator.rb:151:in `validate' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:385:in `block in make_lambda' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:179:in `block in call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:669:in `block (2 levels) in default_terminator' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:668:in `catch' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:668:in `block in default_terminator' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:180:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:560:in `block in invoke_before' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:560:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:560:in `invoke_before' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:109:in `run_callbacks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:914:in `_run_validate_callbacks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validations.rb:443:in `run_validations!' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validations/callbacks.rb:115:in `block in run_validations!' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:110:in `run_callbacks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/callbacks.rb:914:in `_run_validation_callbacks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validations/callbacks.rb:115:in `run_validations!' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activemodel-7.2.3.1/lib/active_model/validations.rb:368:in `valid?' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activerecord-7.2.3.1/lib/active_record/validations.rb:71:in `valid?' /srv/gitlab/lib/gitlab/managed_settings.rb:88:in `validate!' /srv/gitlab/lib/gitlab/managed_settings.rb:112:in `apply!' /srv/gitlab/config/initializers/managed_settings.rb:7:in `block in <main>' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:94:in `block in execute_hook' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:87:in `with_execution_control' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:92:in `execute_hook' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:78:in `block in run_load_hooks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:77:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/activesupport-7.2.3.1/lib/active_support/lazy_load_hooks.rb:77:in `run_load_hooks' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/application/finisher.rb:94:in `block in <module:Finisher>' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:32:in `instance_exec' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:32:in `run' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:61:in `block in run_initializers' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:231:in `block in tsort_each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:353:in `block (2 levels) in each_strongly_connected_component' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:425:in `block (2 levels) in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:425:in `block (2 levels) in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:425:in `block (2 levels) in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:425:in `block (2 levels) in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:434:in `each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:424:in `block in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `tsort_each_child' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:424:in `block in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `tsort_each_child' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:424:in `block in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `tsort_each_child' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:424:in `block in each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:50:in `tsort_each_child' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:418:in `each_strongly_connected_component_from' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:352:in `block in each_strongly_connected_component' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `call' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:350:in `each_strongly_connected_component' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:229:in `tsort_each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/tsort-0.2.0/lib/tsort.rb:208:in `tsort_each' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/initializable.rb:60:in `run_initializers' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/application.rb:435:in `initialize!' /srv/gitlab/config/environment.rb:7:in `<main>' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/zeitwerk-2.6.18/lib/zeitwerk/kernel.rb:34:in `require' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/application.rb:411:in `require_environment!' /srv/gitlab/vendor/bundle/ruby/3.3.0/gems/railties-7.2.3.1/lib/rails/application.rb:562:in `block in run_tasks_blocks' Tasks: TOP => gitlab:db:configure => environment (See full trace by running task with --trace) ``` ### Possible fixes 1. Managed Settings `.apply!` should skip if there is pending migration. 2. Because we are skipping the migration step, we should trigger it after the migration has finished ### Patch release information for backports If the bug fix needs to be backported in a [patch release](https://handbook.gitlab.com/handbook/engineering/releases/patch-releases) to a version under [the maintenance policy](https://docs.gitlab.com/policy/maintenance/), please follow the steps on the [patch release runbook for GitLab engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md). Refer to the [internal "Release Information" dashboard](https://dashboards.gitlab.net/d/delivery-release_info/delivery3a-release-information?orgId=1) for information about the next patch release, including the targeted versions, expected release date, and current status. #### High-severity bug remediation To remediate high-severity issues requiring an [internal release](https://handbook.gitlab.com/handbook/engineering/releases/internal-releases/) for single-tenant SaaS instances, refer to the [internal release process for engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/internal-releases/engineers.md?ref_type=heads). <!-- If you don't have /label privileges, follow up with an issue comment of `@gitlab-bot label ~"type::bug"` -->