<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Label this issue](https://contributors.gitlab.com/manage-issue?action=label&projectId=278964&issueIid=618757) </details> <!--IssueSummary end--> <!-- Title suggestion: [FF] `vulnerability_read_es_dual_write` -- dual write to vulnerability_reads Elasticsearch index --> ## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/work_items/592362) currently behind the `vulnerability_read_es_dual_write` feature flag. This is a reintroduction of a flag that was previously rolled out to 100% and removed in commit [af6a008b0171](https://gitlab.com/gitlab-org/gitlab/-/commit/af6a008b01711083cf36904f4eb949b881258cdc). The flag is being brought back with a fresh rollout because dual write to the `vulnerability_reads` Elasticsearch index needs to be re-gated. The previous rollout issue is https://gitlab.com/gitlab-org/gitlab/-/work_items/596439 (now closed). - DRI: @bala.kumar - Team Slack channel: `#g_srm_security_infrastructure` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? While the flag is disabled, `Vulnerabilities::Read#elastic_reference` only returns the legacy `vulnerabilities` index reference, so writes to the `vulnerability_reads` Elasticsearch index stop. The `vulnerability_reads` Postgres table keeps changing, so the `vulnerability_reads` Elasticsearch index will drift out of sync with it for as long as the flag stays off. There is no user-facing impact from this drift: vulnerability search and the vulnerability report both still read from the legacy `vulnerabilities` index, not from `vulnerability_reads`. Re-enabling the flag on a project or group that has accumulated drift may require a backfill or reindex of `vulnerability_reads` to close the gap before dual write results are trustworthy again, so watch for that when rolling forward. Deletes from the `vulnerability_reads` index are not gated by this flag (they're guarded only by the `create_vulnerability_reads_index` migration), so rollout state does not change delete behavior. ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_srm_security_infrastructure`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set vulnerability_read_es_dual_write 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set vulnerability_read_es_dual_write true --dev --pre --staging --staging-ref ``` **Production** — percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set vulnerability_read_es_dual_write <percentage> --actors ``` Or target specific actors instead: ``` /chatops gitlab run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss vulnerability_read_es_dual_write true /chatops gitlab run feature set --group=gitlab-org,gitlab-com vulnerability_read_es_dual_write true /chatops gitlab run feature set --user=bala.kumar vulnerability_read_es_dual_write true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete vulnerability_read_es_dual_write --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set vulnerability_read_es_dual_write false # production /chatops gitlab run feature set vulnerability_read_es_dual_write false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete vulnerability_read_es_dual_write --dev --pre --staging --staging-ref --production # remove entirely ```