## Why this issue exists Inline blame in the blob viewer is the only blame experience now. #425273 added the client side redirect from `/-/blame/*id` to the blob viewer. #602273 removes the `inline_blame` flag and the legacy `else` branch of `app/views/projects/blame/show.html.haml`, via !257407. `BlameController#page` and `#streaming` have no flag guard, so they survive that cleanup with no entry point from the UI. This issue retires them and the dead code around them. ## Sequencing This issue depends on !257407 merging first. While the flag existed, the legacy page was the rollback path. !257407 also rewrites the specs that stubbed `inline_blame: false`, so doing this work before that MR merges would mean editing the same specs twice with conflicting expectations. ## Must keep (previous description got these wrong) - **`Gitlab::BlamePresenter`** (`app/presenters/gitlab/blame_presenter.rb`) stays. It presents the GraphQL Blame type. `app/graphql/types/blame/blame_type.rb` line 10 declares `present_using Gitlab::BlamePresenter`, and that type is what inline blame queries through `app/assets/javascripts/vue_shared/components/source_viewer/queries/blame_data.query.graphql`. Removing it removes inline blame, not the legacy page. - **`BlameHelper#age_map_class` and `#age_map_duration`** (`app/helpers/blame_helper.rb`) stay. `Gitlab::BlamePresenter` includes `BlameHelper` and calls both (`blame_presenter.rb` lines 62 and 94). `age_map_class` is exposed as the GraphQL field `ageMapClass` in `app/graphql/types/blame/commit_data_type.rb`. The frontend consumes it in `app/assets/javascripts/vue_shared/components/source_viewer/components/blame_info.vue` line 35 and `chunk.vue` line 167 to pick a color from `BLAME_AGE_COLORS`. After !257407 these two methods are the entire contents of `blame_helper.rb`, so the file is untouched by this issue. - **`Gitlab::Git::BlamePagination` is not a straight delete.** Its `PAGINATION_PER_PAGE` constant is referenced by two live views, `app/views/projects/_files.html.haml` line 15 (tree page) and `app/views/projects/blob/_blob.html.haml` line 22 (blob page). Both emit a `.js-per-page` element carrying `data-blame-per-page`, read by `app/assets/javascripts/blob/utils.js` line 10. The class can only be deleted together with those two attributes. - **The `/-/blame/*id` redirect must survive.** It lives in `BlameController#show` plus the `else` branch of `show.html.haml` that emits `window.location.replace(blob_path + window.location.hash)`. Keep the `get '/blame/*id'` route, `#show`, the `@gitaly_unavailable` branch (evaluated before the redirect), and the `load_blob` and `require_non_binary_blob` before-actions. Changing those before-actions is a behavior change, not incidental cleanup. Also keep `get '/blame/*id', to: 'blame#show', as: :deprecated_blame` in `config/routes/repository_deprecated.rb`, which also lands on `#show`. - **Also keep:** `app/assets/javascripts/blame/preferences/blame_preferences.vue` and `app/assets/javascripts/blame/blame_legend.vue`, both mounted by `app/assets/javascripts/blob/components/blame_header.vue` in the inline experience. Keep the `.file-blame-legend` and `.legend-box-*` SCSS that `blame_legend.vue` uses. Keep the `inline_blame_popover` callout and the analytics events and metric YAMLs for the new experience. ## Already done by !257407 (do not re-plan) - The legacy `else` branch of `app/views/projects/blame/show.html.haml`. - `BlameHelper#blame_pages_streaming_url`, `#entire_blame_path` and `#blame_preferences`. - `qa/qa/page/blame/show.rb`. No files under `qa/` mention blame any more, so the old "QA selector validation fails" risk is closed. ## Resolved risks from the previous description - **`.git-blame-ignore-revs` errors:** closed. `app/graphql/resolvers/blame_resolver.rb` lines 38 to 41 rescue both `Gitlab::Git::Blame::IgnoreRevsFileError` and `IgnoreRevsFormatError` into a `GraphQL::ExecutionError`, which `source_viewer.vue` surfaces with `createAlert`. !257407 already relies on this. - **EE overlay:** not a risk. There is no `ee/app/controllers/projects/blame_controller.rb` and no `EE::Projects::BlameController`. `prepend_mod` resolves through `each_extension_for`, which only yields when the constant exists, so it is a no-op here. - **Vue 3 overlap:** the previous text said #613673 was in review. It is closed (2026-08-25). The `vue3_migrate_repo_read_pages` flag file still exists and both `vue3_migration.yml` files still point at that closed issue, so they go with the page bundles. ## What to remove, grouped as the MRs that will do it ### MR A: drop the legacy `?page=` query param (frontend) The `page` param only ever addressed the paginated legacy page. This removal is a provable no-op, because neither call site has ever produced a page param: - `chunk.vue` calls `getPageParamValue(this.number)`, and `number` is declared as `undefined` in `data()` and never assigned anywhere in the component. - `getAbsolutePermalinkPath` calls `getPageParamValue(hash)` with a hash string such as `#L6`, and `parseInt('#L6', 10)` is `NaN`. In both cases `Math.ceil(NaN / perPage)` is `NaN`, `NaN <= 1` is false so the function returns `NaN`, and `getPageSearchString` then short circuits on its falsy `page` guard and returns the empty string. The helper only works when handed a bare integer, which nothing does. The existing spec coverage hid this by stubbing `getPageParamValue` to return `'2'`. - `getPageParamValue`, `getPageSearchString` and the `blameLinesPerPage` lookup in `app/assets/javascripts/blob/utils.js`. - The `pageSearchString` computed property and its use in the blame link href in `app/assets/javascripts/vue_shared/components/source_viewer/components/chunk.vue`, plus the now unused `number` data property. - The page branch of `getAbsolutePermalinkPath` in `app/assets/javascripts/repository/components/header_area/utils.js`. - Specs: `spec/frontend/blob/utils_spec.js`, `spec/frontend/repository/components/header_area/utils_spec.js`, `spec/frontend/vue_shared/components/source_viewer/components/chunk_spec.js`. ### MR B: retire `#page` and `#streaming` (backend) - `BlameController#page`, `#streaming`, and the `load_blame`, `load_environment`, `ignore_revs`, `blame_attributes` and `blame_params` private methods. - The `handle_gitaly_error` override, which exists only because `#page` and `#streaming` have no templates. `#show` still needs `@gitaly_unavailable`. - `app/views/projects/blame/_page.html.haml`. - Two routes in `config/routes/repository.rb`: `get '/blame_page/*id', to: 'blame#page', as: :blame_page` and `get '/blame/*id/streaming', to: 'blame#streaming', as: :blame_streaming, defaults: { streaming: true }`. - Regenerate **two** committed route artifacts. They have separate generators and separate CI gates, and missing either one fails the pipeline: - `bin/rake gitlab:js:routes` rewrites `app/assets/javascripts/lib/utils/path_helpers/repository.js`. Gated by `gitlab:js:routes:updated_check` in `scripts/static-analysis`. - `bundle exec rake gitlab:cells:routes:generate` rewrites `config/routing/gitlab_routes.json`, the snapshot the Cells HTTP Router mirrors. Gated by `gitlab:cells:routes:updated_check` in `.gitlab/ci/cells.gitlab-ci.yml`. The first task does **not** refresh this file. - `lib/gitlab/git/blame_mode.rb` and `lib/gitlab/git/blame_pagination.rb`, plus `spec/lib/gitlab/git/blame_mode_spec.rb` and `spec/lib/gitlab/git/blame_pagination_spec.rb`. - The `.js-per-page` class and `blame_per_page` data attribute in `app/views/projects/_files.html.haml` and `app/views/projects/blob/_blob.html.haml`. - Specs: the `GET page` and `GET streaming` blocks in `spec/controllers/projects/blame_controller_spec.rb`, the `to #streaming` and `to #page` specs in `spec/routing/project_routing_spec.rb` (lines 577 to 583), and the `#streaming` and `#page` describes in `spec/requests/projects/gitaly_unavailable_spec.rb` (lines 207 to 227). Keep the `#show` coverage in all three. ### MR C: remove the dead frontend entrypoints - `app/assets/javascripts/blame/blame_redirect.js` and `spec/frontend/blame/blame_redirect_spec.js`. It reads `.js-per-page`, which no longer exists on the blame page, so it is already inert. - `app/assets/javascripts/blame/preferences/init_blame_preferences.js`. This is the legacy mount only. `blame_preferences.vue` stays. - `app/assets/javascripts/blame/streaming/index.js` and `spec/frontend/blame/streaming/index_spec.js`. - `app/assets/javascripts/pages/projects/blame/show/index.js` and `app/assets/javascripts/pages/projects/blame/streaming/index.js`. - `ee/app/assets/javascripts/pages/projects/blame/show/index.js`. - `app/assets/javascripts/pages/projects/blame/show/vue3_migration.yml` and `ee/app/assets/javascripts/pages/projects/blame/show/vue3_migration.yml`. - Regenerate `locale/gitlab.pot` with `bin/rake gettext:regenerate`. Deleting the streaming renderer and the redirect orphans three strings (`Blame could not be loaded as a single page.`, `View blame as separate pages`, `Please wait a few moments while we load the file history for this line.`). The `.pot` file is committed and gated by `gettext:updated_check` in `scripts/static-analysis`. - Delete the `vue3_migration.yml` files in the same commit as their sibling `index.js`. `spec/lib/gitlab/vue3_migration_files_spec.rb` fails on a metadata file with no sibling entry file. - Note that deleting the `show` bundle also drops `initBlob()` and `initFindFileShortcut()` from that page. Neither has any markup to act on, because the page renders only a `window.location.replace` or the Gitaly alert. The only loss is global navigation shortcuts on the Gitaly unavailable screen, which is an accepted trade off. ### MR D: leftovers - `app/views/projects/blob/_breadcrumb.html.haml`. It has no caller after !257407 (its only caller was `app/views/projects/blame/show.html.haml` line 29 on master) and it still emits `event_tracking: 'click_blame_control_on_blob_page'` for an event !257407 moves to `config/events/removed/`. - Legacy SCSS in `app/assets/stylesheets/framework/files.scss`: `.blame-table`, `.blame-table-wrapper`, `.blame-stream-container`, `.blame-stream-loading`, `.blame-commit-age-0` through `.blame-commit-age-9`, and the `.blame.file-content` rules. Check `app/assets/stylesheets/print.scss` too. Keep `.file-blame-legend` and `.legend-box-*`. - `doc/user/project/repository/files/git_blame.md` line 43 still says "To open the full blame page, in the upper-right corner, select Blame." That went stale when the flag reached 100 percent and is plainly wrong once the desktop Blame button is gone. ### Separate, not part of the removal Two items raised in review on !257407, tracked together in one follow-up MR: - The redirect drops `?ignore_revs=true`. `source_viewer.vue` line 184 and `simple_viewer.vue` line 163 both read that param off the URL, so the value is meaningful at the destination but never arrives. - The mobile Blame item in `app/assets/javascripts/repository/components/header_area/blob_repository_actions_group.vue` (lines 33 to 41) still hrefs to `blobInfo.blamePath`, so it does a full page load and redirect instead of activating blame in place. ## Dependency shape A, B and C touch no files in common and can go out in parallel. D should follow B, since the SCSS is only provably dead once `_page.html.haml` is gone. All of them depend on !257407. ## Acceptance criteria - [x] `/-/blame/<ref>/<path>#L<n>` still redirects to the blob viewer with blame on and the line fragment preserved. Covered by `spec/controllers/projects/blame_controller_spec.rb` and `spec/features/projects/blobs/blame_spec.rb`. - [x] Missing path and binary blob behaviour on `/-/blame/*id` is unchanged. The `load_blob` and `require_non_binary_blob` before-actions were left untouched. - [x] `/blame_page/*id` and `/blame/*id/streaming` no longer route, with no orphaned routing assertions. `config/routes/repository.rb` is down to `get '/blame/*id', to: 'blame#show'`. - [x] Both route artifacts regenerated. `cells-routes:router-in-sync` was skipped with `pipeline:skip-router-sync`, justified in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/257919, because 7 of the 11 templates it flagged are pre-existing drift that `master` fails on its own. The 4 blame templates still need refreshing in the HTTP Router snapshot. - [x] `locale/gitlab.pot` regenerated and `gettext:updated_check` passes. - [x] Inline blame still renders age colours, the legend, preferences and ignore-revs. Gated on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/258306, which removes the legacy `.blame` styles and re-adds the positioning context as `gl-relative` on `blame_info.vue`. - [x] No orphaned entrypoints, page bundles or `vue3_migration.yml` files remain. - [x] Changelog entries added where warranted: `removed` on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/257919 for the dropped routes and `fixed` on https://gitlab.com/gitlab-org/gitlab/-/merge_requests/258305 for the `ignore_revs` fix. The remaining MRs are internal-only cleanups and carry none, so the original `other` wording does not match what shipped.