## Summary Roll out [the feature](https://gitlab.com/groups/gitlab-org/-/work_items/21610) currently behind the `duo_mr_risk_classification` feature flag. - DRI: @wanpol - Team Slack channel: `#g_code_review` > [!note] > Process and guidance live in the docs - this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability - it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? Turning this flag on today would expose the `risk_classification/v1` foundational flow in the flow catalog and unlock the `riskAssessment` GraphQL field on `MergeRequestType`, but neither has any real effect yet: the orchestration that triggers the flow on merge request events (issue 609292) does not exist, so nothing produces an actual risk assessment, and there is no UI widget (issue 609295) to surface one anyway. Practical blast radius today is effectively zero - an available-but-inert flow entry and a field that resolves to `null`. The real risk is procedural: starting a percentage rollout before orchestration and the UI land would give a false impression that the feature is ready. **Do not begin percentage rollout until the orchestration/trigger wiring and UI widget have shipped.** This issue exists now, at flag-creation time, to track the flag per the feature flag documentation - not because it is ready for a real rollout today. ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_code_review`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set duo_mr_risk_classification 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set duo_mr_risk_classification true --dev --pre --staging --staging-ref ``` **Production** - percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set duo_mr_risk_classification <percentage> --actors ``` Or target specific actors instead: ``` /chatops gitlab run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss duo_mr_risk_classification true /chatops gitlab run feature set --group=gitlab-org,gitlab-com duo_mr_risk_classification true /chatops gitlab run feature set --user=wanpol duo_mr_risk_classification true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% - see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [ ] Orchestration/trigger wiring (https://gitlab.com/gitlab-org/gitlab/-/work_items/609292) has shipped - [ ] UI widget (https://gitlab.com/gitlab-org/gitlab/-/work_items/609295) has shipped - [ ] [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [ ] [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [ ] [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [ ] [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) - see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/issues/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check <merge-request-url> <milestone> /chatops gitlab run feature delete duo_mr_risk_classification --dev --pre --staging --staging-ref --production ``` ## Rollback ``` /chatops gitlab run feature set duo_mr_risk_classification false # production /chatops gitlab run feature set duo_mr_risk_classification false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete duo_mr_risk_classification --dev --pre --staging --staging-ref --production # remove entirely ```