## Summary This issue is to roll out [Include the authorizing user on dynamic OAuth application names](https://gitlab.com/gitlab-org/gitlab/-/work_items/605884) on production, currently behind the `stamp_authorizing_user_on_dynamic_oauth_app` feature flag. Once enabled, when a user approves authorization of a dynamically-registered (DCR) OAuth application, their username is appended to the application name (e.g. `[Unverified Dynamic Application] kiro — authorized by @jessieay`). This allows admins to identify which user is behind an otherwise-anonymous dynamic app in the Admin UI. ## Owners - Most appropriate Slack channel to reach out to: `#g_agent_execution` - Best individual to reach out to: @jessieay ## Expectations ### What are we expecting to happen? When a user approves authorization of a dynamic OAuth application for the first time, their sanitized username is appended to the application name. The stamp is applied only once (idempotent), only on genuine approvals (not denials or errors), and only for dynamic applications. Non-dynamic applications are never modified. ### What can go wrong and how would we detect it? - `application.update` fails (e.g. validation error on the name column) → authorization still succeeds but the name is not stamped. Detection: errors in `Oauth::AuthorizationsController#stamp_authorizing_user_on_dynamic_application`, increased `500` responses on `POST /oauth/authorize`. - Unexpected characters in username bypass sanitization → unlikely given the `gsub(/[^A-Za-z0-9_.-]/, '')` guard, but monitor for unexpected name values in the admin UI. - Performance regression on the authorization endpoint → the feature adds one `UPDATE` on the already-loaded `oauth_applications` record; monitor p99 latency on `POST /oauth/authorize`. Relevant dashboards on https://dashboards.gitlab.net: - Rails request rate / error rate: https://dashboards.gitlab.net/d/rails-main - Sidekiq / background jobs: https://dashboards.gitlab.net/d/sidekiq-main **Kibana — production:** https://log.gprd.gitlab.net **Kibana — non-prod / staging:** https://nonprod-log.gitlab.net Suggested searches (open Kibana → Discover, then paste into the search bar): - Errors in the stamping after_action: `json.controller : "Oauth::AuthorizationsController" AND json.action : "create" AND json.status : [500 TO 599]` - OAuth authorization errors broadly: `json.path : "/oauth/authorize" AND json.status : [400 TO 599]` ## Rollout Steps Note: Please make sure to run the chatops commands in the Slack channel that gets impacted by the command. ### Prerequisites - [ ] MR introducing the feature flag merged: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/244666 ### Rollout on non-production environments - Verify the MR with the feature flag is merged to `master` and has been deployed to non-production environments with `/chatops gitlab run auto_deploy status <merge-commit-of-your-feature>` - [x] Enable on staging for a test user: `/chatops gitlab run feature set --user=<staging-test-user> stamp_authorizing_user_on_dynamic_oauth_app true --dev --pre --staging --staging-ref` - [x] Monitor that error rates did not increase. - [x] Verify that the feature works as expected. The best environment to validate the feature in is [`staging-canary`](https://about.gitlab.com/handbook/engineering/infrastructure/environments/#staging-canary) as this is the first environment deployed to. Make sure you are [configured to use canary](https://next.gitlab.com/). - [x] If the feature flag causes end-to-end tests to fail, disable the feature flag on staging to avoid blocking [deployments](https://about.gitlab.com/handbook/engineering/deployments-and-releases/deployments/). - See [`#e2e-run-staging` Slack channel](https://gitlab.enterprise.slack.com/archives/CBS3YKMGD) and look for the following messages: - test kicked off: `Feature flag stamp_authorizing_user_on_dynamic_oauth_app has been set to true on **gstg**` - test result: `This pipeline was triggered due to toggling of stamp_authorizing_user_on_dynamic_oauth_app feature flag` If you encounter end-to-end test failures and are unable to diagnose them, you may reach out to the [`#s_developer_experience` Slack channel](https://gitlab.enterprise.slack.com/archives/C07TWBRER7H) for assistance. Note that end-to-end test failures on `staging-ref` [don't block deployments](https://about.gitlab.com/handbook/engineering/infrastructure/environments/staging-ref/#how-to-use-staging-ref). ### Before production rollout - [x] If the change is significant and you wanted to announce in [#whats-happening-at-gitlab](https://gitlab.enterprise.slack.com/archives/C0259241C), it best to do it before rollout to `gitlab-org/gitlab-com`. ### Specific rollout on production For visibility, all `/chatops` commands that target production must be executed in the [`#production` Slack channel](https://gitlab.slack.com/archives/C101F3796) and cross-posted (with the command results) to the responsible team's Slack channel. - Ensure that the feature MRs have been deployed to both production and canary with `/chatops gitlab run auto_deploy status <merge-commit-of-your-feature>` - [x] Enable for a small set of internal users first: `/chatops gitlab run feature set --feature-group=gitlab_team_members stamp_authorizing_user_on_dynamic_oauth_app true` - [x] Verify that the feature works for the specific actors. ### Preparation before global rollout - [ ] Set a milestone to this rollout issue to signal for enabling and removing the feature flag when it is stable. - [ ] Check if the feature flag change needs to be accompanied with a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process). Cross link the issue here if it does. - [ ] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias. - [ ] Ensure that documentation exists for the feature, and the [version history text](https://docs.gitlab.com/development/documentation/feature_flags/#add-history-text) has been updated. - [ ] Ensure that any breaking changes have been announced following the [release post process](https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations-removals-and-breaking-changes) to ensure GitLab customers are aware. - [ ] Notify the [`#support_gitlab-com` Slack channel](https://gitlab.slack.com/archives/C4XFU81LG) and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/development/feature_flags/controls/#communicate-the-change)). ### Global rollout on production For visibility, all `/chatops` commands that target production must be executed in the [`#production` Slack channel](https://gitlab.slack.com/archives/C101F3796) and cross-posted (with the command results) to the responsible team's Slack channel. - [x] [Incrementally roll out](https://docs.gitlab.com/development/feature_flags/controls/#process) the feature on production. - Example: `/chatops gitlab run feature set stamp_authorizing_user_on_dynamic_oauth_app <rollout-percentage> --actors`. - Between every step wait for at least 15 minutes and monitor the appropriate graphs on https://dashboards.gitlab.net. - [x] After the feature has been 100% enabled, wait for [at least one day before releasing the feature](#release-the-feature). ### Release the feature After the feature has been [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release), the [clean up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up) should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase. - [ ] Create a merge request to remove the `stamp_authorizing_user_on_dynamic_oauth_app` feature flag. Ask for review/approval/merge as usual. The MR should include the following changes: - Remove all references to the feature flag from the codebase (`Oauth::AuthorizationsController#stamp_authorizing_user_on_dynamic_application` and the `Feature.enabled?` guard). - Remove the YAML definition for the feature from the repository. - [ ] Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before [the monthly release was tagged](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post: `/chatops gitlab run release check <merge-request-url> <milestone>` - [ ] Close [the feature issue](https://gitlab.com/gitlab-org/gitlab/-/work_items/605884) to indicate the feature will be released in the current milestone. - [ ] Once the cleanup MR has been deployed to production, clean up the feature flag from all environments by running these chatops command in `#production` channel: `/chatops gitlab run feature delete stamp_authorizing_user_on_dynamic_oauth_app --dev --pre --staging --staging-ref --production` - [ ] Close this rollout issue. ## Rollback Steps - [ ] This feature can be disabled on production by running the following Chatops command: ``` /chatops gitlab run feature set stamp_authorizing_user_on_dynamic_oauth_app false ``` - [ ] Disable for a specific user: ``` /chatops gitlab run feature set --user=<username> stamp_authorizing_user_on_dynamic_oauth_app false ``` - [ ] Disable the feature flag on non-production environments: ``` /chatops gitlab run feature set stamp_authorizing_user_on_dynamic_oauth_app false --dev --pre --staging --staging-ref ``` - [ ] Delete feature flag from all environments: ``` /chatops gitlab run feature delete stamp_authorizing_user_on_dynamic_oauth_app --dev --pre --staging --staging-ref --production ```