<!-- Title suggestion: [FF] `ci_runners_count_traversal_ids_index` -- <short description> --> ## Summary Roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/work_items/601877) currently behind the `ci_runners_count_traversal_ids_index` feature flag. - DRI: @pedropombeiro, @narendran-kannan - Team Slack channel: `#g_ci-platform` > [!note] > Process and guidance live in the docs — this issue is just the commands and a place to track the rollout. > "Rolling out" means incrementally enabling the flag on GitLab.com to validate stability — it is not the same as releasing the feature, which happens when the flag is removed. > [Feature flag controls](https://docs.gitlab.com/development/feature_flags/controls/) · [Feature flag lifecycle](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) ## What could go wrong? <!-- Optional but recommended: blast radius, data-loss risk, and the dashboard(s) you'll watch on https://dashboards.gitlab.net. Delete if not applicable. --> ## Rollout Run all production `/chatops` in [`#production`](https://gitlab.slack.com/archives/C101F3796) and cross-post the results to `#g_ci-platform`. Background: [incremental rollout process](https://docs.gitlab.com/development/feature_flags/controls/#process), [feature actors](https://docs.gitlab.com/development/feature_flags/#feature-actors). **Non-production** ``` /chatops gitlab run feature set ci_runners_count_traversal_ids_index 50 --actors --dev --pre --staging --staging-ref /chatops gitlab run feature set ci_runners_count_traversal_ids_index true --dev --pre --staging --staging-ref ``` **Production** — percentage rollout (wait ≥15 min between steps, watch dashboards): ``` /chatops gitlab run feature set ci_runners_count_traversal_ids_index <percentage> --actors ``` Or target specific actors instead: ``` /chatops gitlab run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss ci_runners_count_traversal_ids_index true /chatops gitlab run feature set --group=gitlab-org,gitlab-com ci_runners_count_traversal_ids_index true /chatops gitlab run feature set --user=pedropombeiro ci_runners_count_traversal_ids_index true ``` ## Before global rollout Confirm the relevant gotchas before going to 100% — see [enabling a feature for GitLab.com](https://docs.gitlab.com/development/feature_flags/controls/#enabling-a-feature-for-gitlabcom): - [Docs + version history](https://docs.gitlab.com/development/documentation/feature_flags/) updated - [Breaking changes](https://docs.gitlab.com/development/documentation/release_notes/#deprecations-removals-and-breaking-changes) announced, if any - [Change management issue](https://handbook.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process) opened, if required - [External API consumers](https://docs.gitlab.com/development/feature_flags/#do-not-use-feature-flags-in-external-api-consumers) handled with a fail-open mechanism, if applicable ## Cleanup Remove the flag once [deemed stable](https://handbook.gitlab.com/handbook/product-development/how-we-work/product-development-flow/feature-flag-lifecycle/#feature-flag-lifecycle) — see [cleaning up](https://docs.gitlab.com/development/feature_flags/controls/#cleaning-up). Track it here, or open a follow-up [Feature Flag Cleanup issue](https://gitlab.com/gitlab-org/gitlab/-/issues/new?description_template=Feature%20Flag%20Cleanup). Remove the flag and its YAML definition from the codebase, then: ``` /chatops gitlab run release check https://gitlab.com/gitlab-org/gitlab/-/merge_requests/242978 19.2 /chatops gitlab run feature delete ci_runners_count_traversal_ids_index --dev --pre --staging --staging-ref --production ``` ### Code cleanup Once the flag is removed, finish replacing the GIN `traversal_ids @>` path with the covering-index path: - [ ] Make `Ci::Runner.belonging_to_group_or_project_descendants` call `Ci::NamespaceMirror.by_group_and_descendants_using_covering_index` unconditionally (drop the `if ci_runners_count_traversal_ids_index_enabled?` branch and the `ci_runners_count_traversal_ids_index_enabled?` helper). - [ ] Migrate `Organizations::Transfer::CiRunnersService#execute` (`app/services/organizations/transfer/ci_runners_service.rb`) — the other single-id caller — to the covering-index scope. - [ ] Remove `EE::User#ci_namespace_mirrors_permitted_to` (`ee/app/models/ee/user.rb`). It is the only caller that passes an **array** to `by_group_and_descendants`, it has no callers (already flagged in `scripts/lint/potential_methods_to_remove.yml`), and the array form relies on per-row `traversal_ids @>` ancestry semantics that the single-group covering-index scope does not reproduce. - [ ] Delete the now-unused `Ci::NamespaceMirror.by_group_and_descendants` scope. ## Rollback ``` /chatops gitlab run feature set ci_runners_count_traversal_ids_index false # production /chatops gitlab run feature set ci_runners_count_traversal_ids_index false --dev --pre --staging --staging-ref # non-production /chatops gitlab run feature delete ci_runners_count_traversal_ids_index --dev --pre --staging --staging-ref --production # remove entirely ``` <!-- Uncomment the appropriate type label /label ~"type::feature" ~"feature::addition" /label ~"type::maintenance" /label ~"type::bug" -->