## Description This issue tracks the work to flip `let_it_be`'s default to `freeze: true` (the goal of #600267) **at the spec level**, by adding `freeze: false` or switching to `let_it_be_with_reload`/`let_it_be_with_refind` on the specific declarations that get mutated. > **Direction change from the original framing of this issue.** The initial framing proposed refactoring production code (e.g. replacing `Note#touch_noteable`'s `noteable_object.touch` with a raw SQL UPDATE). Reviewer feedback on the first such MRs (!236545, !236547) was that this introduces a test/prod behavioural split, even when the audited callbacks show the swap is semantically equivalent. We've pivoted to **spec-side** fixes: each declaration that gets mutated is opted out by adding `freeze: false` or switching to `let_it_be_with_reload` / `let_it_be_with_refind`. Production code stays unchanged. ## Current probe and progress - **Probe MR**: !237833 (PROBE v2) — supersedes the closed !236505. - Most recent run (post-rollup, post-fixes): **480 FrozenError occurrences** across **8 spec files** (down from 696/13 at the start). All of those are addressed by the open spec-side MRs below. ## Spec-side fix MRs (open) Each one fixes the FrozenError site(s) the probe surfaced in a specific spec file or shared example. Most are 1–9 line changes. | MR | Spec / shared example | Site | Failures | |----|------------------------|------|----------| | !237840 | AST template shared contexts | `Ci::CreatePipelineService` cached service | 440 | | !237842 | `group_member_policy_spec.rb` | `user.rb:2655 update_two_factor_requirement` | 12 | | !237859 | `ee/spec/requests/api/members_spec.rb` | `user.rb:2655` + `member.rb:576` | 76 | | !237861 | `git_access_snippet_spec.rb` | `project_features_compatibility.rb:152` + `respond_to_terms_service.rb:26` | 48 | | !237863 | `_sidebar.html.haml_spec.rb` | `wiki.rb:395` `@repository ivar` | 18 | | !237864 | `jira_connect/client_spec.rb` | `pipeline.rb:1696 ensure_ci_ref!` | 14 | | !237883 | `merge_requests/update_service_spec.rb` | `issuable_base_service.rb:548` | 8 | | !237885 | `hangouts_chat` shared examples | `project_wiki.rb:26 after_wiki_activity` | 6 | | !237888 | `generic/create_package_file_service_spec.rb` | `create_package_file_service.rb:52` | 6 | | !237891 | `issues/create_service_spec.rb` | `graphql_triggers.rb:125` | 4 | | !237918 | `update_service_spec.rb` (`MergeRequestsClosingIssues already exist`) | `before_all` + `refind: true` timing | 2 | | !237944 | `custom_role_examples` shared contexts | `user.rb:2655` + member factory | 44 | | !237955 | `project_policy_shared_context.rb` | `:owner_namespace` mutation through factory chain | ~1700+ | | !237979 | `project_spec.rb` (runners_token shared example) | `token_authenticatable.rb:61` | 12 | ## Approach 1. Run a PROBE MR (latest: !237833) that flips the let_it_be default to `true` and re-aliases `let_it_be_with_reload` / `let_it_be_with_refind` to keep `freeze: false`. 2. Capture failed-job traces. For each FrozenError block, identify (spec_file, mutation site) via the harness. 3. For each affected spec, pick the minimal opt-out: - **`freeze: false`** if the cached record's attribute hash is mutated in-place (e.g. `record.update_column`, `member.update_columns`, `set_runners_token`, `add_owner` cascading into the user) - **`let_it_be_with_reload`** if examples need a refreshed copy each time - **`let_it_be_with_refind`** if a new instance per example is preferable 4. After each batch lands, re-run the probe to find newly surfaced cases (some are masked by earlier failures). ## Known fast-quarantines | Quarantine MR | Why | |----|----| | https://gitlab.com/gitlab-org/quality/engineering-productivity/fast-quarantine/-/merge_requests/529 | `granular_token_permissions` shared example: `PG::ForeignKeyViolation` on `namespace_settings` (#600471) — unrelated master flake, surfaces in any MR whose predictive batch picks it up. | | https://gitlab.com/gitlab-org/quality/engineering-productivity/fast-quarantine/-/merge_requests/532 | `ee/spec/services/concerns/security/scan_result_policies/related_pipelines_spec.rb:131` — deterministic master regression (`expand_security_scan_comparison_commits` FF flipped on, test expectations not updated, #600432). | ## Probe artifacts - Probe MR: !237833 (v2) - Per-run analyses captured in https://gitlab.com/pedropombeiro/let-it-be-frozen-cleanup-harness/-/tree/master/logs (probe_monitor_v1, probe_monitor_v2_run1, probe_monitor_v2_run2, probe_monitor_v2_run3, probe_monitor — most recent). ## Sites surfaced by the probe (latest data, run 4) | Site | Failures | Specs affected | Status | |------|---------|-----------------|--------| | `app/services/ci/create_pipeline_service.rb:143` | 400 | 4 EE template specs | !237840 | | `app/models/user.rb:2655` | 48 | members_spec, group_member_policy_spec | !237842, !237859 | | `app/models/wiki.rb:395` | 18 | wiki sidebar view spec | !237863 | | `app/models/concerns/token_authenticatable.rb:61` | 12 | project_spec runners_token | !237979 | | `app/models/member.rb:576` | 2 | members_spec (`accept_invite!`) | !237859 | ## Related - #600267 (parent rollout) - #600471 (master flake — fast-quarantined) - #600432 (master flake — fast-quarantined) - !71373 (original 2021 freeze-default attempt) - !234596 (`RSpec/LetItBeImmutable` cop)