## Summary This issue is to roll out [the feature](https://gitlab.com/gitlab-org/gitlab/-/issues/590584) on production, that is currently behind the `package_metadata_sync_using_labels` feature flag. This flag gates the new fast path in the GCP connector for package metadata sync, which reads bucket labels to determine available deltas instead of calling `listObjects`. The old `listObjects` path remains as a fallback when the flag is disabled or labels are absent. ## Owners - Most appropriate Slack channel to reach out to: `#g_composition_analysis` - Best individual to reach out to: @azaydan ## Expectations ### What are we expecting to happen? When enabled, the package metadata sync worker will read GCP bucket labels to determine which delta files to fetch, skipping the expensive `listObjects` API call for registries that have labels available. This reduces GCP API costs and speeds up sync for large registries (e.g. maven, npm, pypi). In case of errors when using the ### What can go wrong and how would we detect it? **What can go wrong:** If label code errors in a way that's not caught and execution never reaches `listObjects`, the instance will not be able to sync advisory and license data. **How can we detect it:** in Sentry, filter by: `Gitlab::PackageMetadata::Connector::Gcp::MissingChunkFileError` . On instance, grep structured logs: `grep 'package_metadata_sync' /var/log/gitlab/gitlab-rails/application_json.log | jq '{msg: .message, purl: .purl_type, path: .message}'` ## Rollout Steps Note: Please make sure to run the chatops commands in the Slack channel that gets impacted by the command. ### Rollout on non-production environments - [x] Verify the MR with the feature flag is merged to `master` and has been deployed to non-production environments with `/chatops gitlab run auto_deploy status <merge-commit-of-your-feature>` - [x] Deploy the feature flag at a percentage (recommended percentage: 50%) with `/chatops gitlab run feature set package_metadata_sync_using_labels 50 --actors --dev --pre --staging --staging-ref` - [x] Monitor that the error rates did not increase (repeat with a different percentage as necessary). - [x] Enable the feature globally on non-production environments with `/chatops gitlab run feature set package_metadata_sync_using_labels true --dev --pre --staging --staging-ref` - [x] Verify that the feature works as expected. The best environment to validate the feature in is [`staging-canary`](https://about.gitlab.com/handbook/engineering/infrastructure/environments/#staging-canary) as this is the first environment deployed to. Make sure you are [configured to use canary](https://next.gitlab.com/). - [x] If the feature flag causes end-to-end tests to fail, disable the feature flag on staging to avoid blocking [deployments](https://about.gitlab.com/handbook/engineering/deployments-and-releases/deployments/). ### Before production rollout - [x] If the change is significant and you wanted to announce in [#whats-happening-at-gitlab](https://gitlab.enterprise.slack.com/archives/C0259241C), it best to do it before rollout to `gitlab-org/gitlab-com`. ### Specific rollout on production For visibility, all `/chatops` commands that target production must be executed in the [`#production` Slack channel](https://gitlab.slack.com/archives/C101F3796) and cross-posted (with the command results) to the responsible team's Slack channel. - [x] Ensure that the feature MRs have been deployed to both production and canary with `/chatops gitlab run auto_deploy status <merge-commit-of-your-feature>` - [x] Enable globally (this flag has no per-actor scoping since it's an instance-wide Sidekiq worker): `/chatops gitlab run feature set package_metadata_sync_using_labels true` - [x] Verify that the feature works (monitor sync job logs and Sentry for errors). ### Preparation before global rollout - [x] Set a milestone to this rollout issue to signal for enabling and removing the feature flag when it is stable. - [x] Check if the feature flag change needs to be accompanied with a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure-platforms/change-management/#feature-flags-and-the-change-management-process). Cross link the issue here if it does. - [x] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. - [x] Ensure that documentation exists for the feature, and the [version history text](https://docs.gitlab.com/development/documentation/feature_flags/#add-history-text) has been updated. - [ ] Notify the [`#support_gitlab-com` Slack channel](https://gitlab.slack.com/archives/C4XFU81LG) and your team channel. ### Global rollout on production For visibility, all `/chatops` commands that target production must be executed in the [`#production` Slack channel](https://gitlab.slack.com/archives/C101F3796) and cross-posted (with the command results) to the responsible team's Slack channel. - [x] After the feature has been 100% enabled, wait for at least one day before releasing the feature. ### Release the feature with the feature flag (set default_enabled: true) Per the agreed rollout plan: deploy with FF disabled, enable on .com, then set `default_enabled: true` so self-hosted instances get it in the next milestone with a kill-switch. - [x] Create a merge request with the following changes: - [x] Ensure the feature has been enabled globally on production: `/chatops gitlab run feature get package_metadata_sync_using_labels` - [x] Set `default_enabled: true` in `config/feature_flags/beta/package_metadata_sync_using_labels.yml`. - [x] Add a changelog entry. - [x] Ensure that the default-enabling MR has been included in the release package. - [ ] After the default-enabling MR has been deployed, clean up the feature flag from all environments: `/chatops gitlab run feature delete package_metadata_sync_using_labels --dev --pre --staging --staging-ref --production` - [x] Close [the feature issue](https://gitlab.com/gitlab-org/gitlab/-/issues/590584). - [x] Set the next milestone to this rollout issue for scheduling the flag removal. ### Release the feature (full cleanup) - [ ] Create a merge request to remove the `package_metadata_sync_using_labels` feature flag: - Remove all references to the feature flag from the codebase. - Remove `config/feature_flags/beta/package_metadata_sync_using_labels.yml`. - [ ] Ensure that the cleanup MR has been included in the release package. - [ ] Close [the feature issue](https://gitlab.com/gitlab-org/gitlab/-/issues/590584). - [ ] Once the cleanup MR has been deployed to production, clean up the feature flag: `/chatops gitlab run feature delete package_metadata_sync_using_labels --dev --pre --staging --staging-ref --production` - [ ] Close this rollout issue. ## Rollback Steps - [ ] This feature can be disabled on production by running the following Chatops command: ``` /chatops gitlab run feature set package_metadata_sync_using_labels false ``` - [ ] Disable the feature flag on non-production environments: ``` /chatops gitlab run feature set package_metadata_sync_using_labels false --dev --pre --staging --staging-ref ``` - [ ] Delete feature flag from all environments: ``` /chatops gitlab run feature delete package_metadata_sync_using_labels --dev --pre --staging --staging-ref --production ```