<!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "type::bug" label: - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=type::bug and verify the issue you're about to submit isn't a duplicate. ---> ### Summary A large ~Ultimate ~self-managed customer reports in [ZD#708643](https://gitlab.zendesk.com/agent/tickets/708643) that 2 approval rules remain on merge requests after compliance frameworks are rapidly changed from projects. ### Steps to reproduce <!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. --> 1. Create a project with two compliance framework that includes a approval rule policy 2. Create a merge request in the project 3. In the project, go Security -> Compliance center -> Project (`-/security/compliance_dashboard/projects`) 4. Using the Pencil icon button and toggle fast by deselecting one and selecting other: 5. Observe the merge request approval rules ### Example Project <!-- If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report. If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version. --> ### What is the current *bug* behavior? <!-- Describe what actually happens. --> Merge requests have stale approval rules even when the compliance framework is no longer associated with the project. The approval rules persist and cannot be removed via UI or API. Customer logs show `PG::UniqueViolation` errors when duplicate approval rules are attempted by overlapping stale jobs. ### What is the expected *correct* behavior? <!-- Describe what you should see instead. --> Only the project's current compliance framework associated approval rules should be applied to the MRs. If the framework is no longer associated with the project, the approval rules associated with the framework should be discarded in MR. ### Relevant logs and/or screenshots <!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise. --> {width=788 height=390} ``` PG::UniqueViolation: ERROR: duplicate key value violates unique constraint "index_approval_project_rules_groups_1" DETAIL: Key (approval_project_rule_id, group_id)=(733513, 35784) already exists. PG::ForeignKeyViolation: ERROR: insert or update on table "scan_result_policy_violations" violates foreign key constraint "fk_f53706dbdd" DETAIL: Key (scan_result_policy_id)=(733991) is not present in table "scan_result_policies". ``` ### Output of checks <!-- If you are reporting a bug on GitLab.com, uncomment below --> <!-- This bug happens on GitLab.com --> <!-- and uncomment below if you have /label privileges --> <!-- /label ~"reproduced on GitLab.com" --> <!-- or follow up with an issue comment of `@gitlab-bot label ~"reproduced on GitLab.com"` if you do not --> #### Results of GitLab environment info <!-- Input any relevant GitLab environment information if needed. --> <details> <summary>Expand for output related to GitLab environment info</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`) </pre> </details> * GitLab version: 18.9.3 * Deployment: Helm chart (self-managed) * Also reproduced on 18.9.2 Docker. #### Results of GitLab application Check <!-- Input any relevant GitLab application check information if needed. --> <details> <summary>Expand for output related to the GitLab application check</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`) (we will only investigate if the tests are passing) </pre> </details> ### Possible fixes <!-- If you can, link to the line of code that might be responsible for the problem. --> ### Patch release information for backports If the bug fix needs to be backported in a [patch release](https://handbook.gitlab.com/handbook/engineering/releases/patch-releases) to a version under [the maintenance policy](https://docs.gitlab.com/policy/maintenance/), please follow the steps on the [patch release runbook for GitLab engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/patch/engineers.md). Refer to the [internal "Release Information" dashboard](https://dashboards.gitlab.net/d/delivery-release_info/delivery3a-release-information?orgId=1) for information about the next patch release, including the targeted versions, expected release date, and current status. #### High-severity bug remediation To remediate high-severity issues requiring an [internal release](https://handbook.gitlab.com/handbook/engineering/releases/internal-releases/) for single-tenant SaaS instances, refer to the [internal release process for engineers](https://gitlab.com/gitlab-org/release/docs/-/blob/master/general/internal-releases/engineers.md?ref_type=heads). <!-- If you don't have /label privileges, follow up with an issue comment of `@gitlab-bot label ~"type::bug"` -->