<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Label this issue](https://contributors.gitlab.com/manage-issue?action=label&projectId=278964&issueIid=594402) </details> <!--IssueSummary end--> ## Problem to solve Any user that is part of the `*` codeowner rule will have their approvals reset {width=812 height=449} -- [source](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229710#note_3213995334) Part of https://gitlab.com/groups/gitlab-org/-/work_items/21409 Rather than resetting approvals everytime, we should only reset approvals **if** the relevant files for that maintainer has been changed (e.g. *.rb files for backend) ## Proposal From https://gitlab.com/groups/gitlab-org/-/work_items/21409#note_3178492834: > From a security and compliance perspective we want changes to be reviewed and approved by team members that have appropriate authority and competence to validate the change Therefore, we want to iteratively transform the `*` rule into separate domains for each set of approvers (Backend, Frontend, etc) We will start with **Backend** first, followed by the Frontend as these two groups are likely the most involved set of maintainers that is involved in multi-approver resets. - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/228991+ - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229399+ - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229401+ - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229612+ - [x] Combine Frontend and Backend sections in mandatory section, and removes Backend from the `[Maintainers]` group fallback - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/228392+ - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229415+ **Frontend** - [ ] Add necessary files, e.g. `*.vue`, and so on - [ ] Figure out what do to with uncovered top-level directories and files - [ ] Remove Frontend from the `[Maintainers]` group fallback **Fallback** - [x] https://gitlab.com/gitlab-org/gitlab/-/merge_requests/229415+ to prevent `*` from being mis-used - [ ] Add something like `@gitlab-org/development-leaders` to the `*` rule to serve as emergency fallback. Especially when major groups have been removed from the `*` rule. ## Metrics Increase in ~frontend + ~backend MRs being [merged](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/?sort=created_date&state=merged&label_name%5B%5D=backend&label_name%5B%5D=frontend&milestone_title=19.0&first_page_size=20). * 18.11 - 409