<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/engineering/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Label this issue](https://contributors.gitlab.com/manage-issue?action=label&projectId=278964&issueIid=587029) - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=587029) </details> <!--IssueSummary end--> ### Summary When adding an `url_variable` to a project webhook with the project API, the sensitive url part is not masked. This works fine with the UI. This happens when creating and updating a webhook. ### Steps to reproduce * Create a project webhook with a sensitive information in the url * Update `url_variable` through the api to mask the sensitive info * See that the URL is still in plain Text Or * Create a project webhook through the API with `url_variable` set * See that the URL is registered in plain Text ### What is the current *bug* behavior? The Webhook URL is not redacted : https://example.com/webhook/gitlab?key=this_is_a_sample ### What is the expected *correct* behavior? The Webhook URL should be redacted with the key in its place : https://example.com/webhook/gitlab?key={access_token} ### Output of checks #### Results of GitLab environment info <details> <summary>Expand for output related to GitLab environment info</summary> <pre> platylabus@git-app1:~$ sudo gitlab-rake gitlab:env:info System information System: Debian 12 Current User: git Using RVM: no Ruby Version: 3.2.8 Gem Version: 3.7.1 Bundler Version:2.7.1 Rake Version: 13.0.6 Redis Version: 7.2.11 Sidekiq Version:7.3.9 Go Version: unknown GitLab information Version: 18.8.1 Revision: d0311b03573 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 16.11 URL: https://git.platy.bzh HTTP Clone URL: https://git.platy.bzh/some-group/some-project.git SSH Clone URL: git@git.platy.bzh:some-group/some-project.git Using LDAP: yes Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 14.45.5 Repository storages: - default: unix:/var/opt/gitlab/gitaly/gitaly.socket GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Gitaly - default Address: unix:/var/opt/gitlab/gitaly/gitaly.socket - default Version: 18.8.1 - default Git Version: 2.52.GIT </pre> </details> #### Results of GitLab application Check <details> <summary>Expand for output related to the GitLab application check</summary> <pre> platylabus@git-app1:~$ sudo gitlab-rake gitlab:check SANITIZE=true Checking GitLab subtasks ... Checking GitLab Shell ... GitLab Shell: ... GitLab Shell version >= 14.45.5 ? ... OK (14.45.5) Running /opt/gitlab/embedded/service/gitlab-shell/bin/gitlab-shell-check Internal API available: OK Redis available via internal API: OK gitlab-shell self-check successful Checking GitLab Shell ... Finished Checking Gitaly ... Gitaly: ... default ... OK Checking Gitaly ... Finished Checking Sidekiq ... Sidekiq: ... Running? ... yes Number of Sidekiq processes (cluster/worker) ... 1/1 Checking Sidekiq ... Finished Checking Incoming Email ... Incoming Email: ... Reply by email is disabled in config/gitlab.yml Checking Incoming Email ... Finished Checking LDAP ... LDAP: ... Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results) User output sanitized. Found 7 users of 100 limit. Checking LDAP ... Finished Checking GitLab App ... Database config exists? ... yes Tables are truncated? ... skipped All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Cable config exists? ... yes Resque config exists? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Systemd unit files or init script exist? ... skipped (omnibus-gitlab has neither init script nor systemd units) Systemd unit files or init script up-to-date? ... skipped (omnibus-gitlab has neither init script nor systemd units) Projects have namespace: ... 5/1 ... yes 7/2 ... yes 5/3 ... yes 14/5 ... yes 18/6 ... yes 17/8 ... yes 18/9 ... yes 10/10 ... yes 10/13 ... yes 18/14 ... yes 17/15 ... yes 18/16 ... yes 18/17 ... yes 18/18 ... yes 57/19 ... yes 18/20 ... yes 56/22 ... yes 13/23 ... yes 56/26 ... yes 17/27 ... yes 72/28 ... yes 72/29 ... yes 76/30 ... yes 76/31 ... yes 78/32 ... yes 18/35 ... yes 17/36 ... yes 94/37 ... yes 97/38 ... yes 97/39 ... yes 100/40 ... yes 100/41 ... yes 100/42 ... yes 5/43 ... yes 78/44 ... yes 94/45 ... yes 5/46 ... yes Redis version >= 6.2.14? ... yes Ruby version >= 3.0.6 ? ... yes (3.2.8) Git user has default SSH configuration? ... yes Active users: ... 15 Is authorized keys file accessible? ... yes GitLab configured to store new projects in hashed storage? ... yes All projects are in hashed storage? ... yes Checking GitLab App ... Finished Checking GitLab subtasks ... Finished </pre> </details>