Sign in or sign up before continuing. Don't have an account yet? Register now to get started.
Register now
Remove `ancestor_inherited -> ancestor_inherited` transitions on namespace states
In https://gitlab.com/gitlab-org/gitlab/-/merge_requests/214801+, we allowed state transition from `ancestor_inherited` to `ancestor_inherited` when restoring a project or group from deletion. This was necessary for backwards compatibility. We can remove this once the backfills has been completed https://gitlab.com/gitlab-org/gitlab/-/work_items/545975. ### Implementation Guide Changes must be done in `/app/models/concerns/namespaces/stateful.rb` 1. Remove `transition ancestor_inherited: :ancestor_inherited` from `cancel_deletion` event 2. Remove `transition ancestor_inherited: :ancestor_inherited` from `unarchive` event 3. Remove TODO comment: https://gitlab.com/gitlab-org/gitlab/-/blob/master/app/models/concerns/namespaces/stateful.rb#L39 **Optional:** Depending on our confidence with the backfill, we could consider rolling out this change with a ~"feature flag" for easier rollback if any issue arises.
issue