Related to https://gitlab.com/gitlab-org/gitlab/-/issues/537214 ## Summary I tried to setup Cisco's duo_api as as a 2FA provider with OTP but it does not work with GDK (master or any of the gem's versions) See the docs: https://docs.gitlab.com/user/profile/account/two_factor_authentication/#enable-a-one-time-password-authenticator-using-cisco-duo ## Current Behaviour * 2FA is immediately enforced * All users are redirected to a 2FA page after successful authentication to setup OTP with the duo_api * OTP code always fails if correct ## Expected Behaviour * 2FA is immediately enforced * All users are redirected to a 2FA page after successful authentication to setup OTP with the duo_api * OTP code always passes if correct ## Discussion I think they introduced a breaking change in v1.5.0 (only RubyGems.org, not their [github repo](https://github.com/duosecurity/duo_api_ruby)) that broke reverse compatibility with previous versions. The feature might be completely broken & would need a strategy refactor. The following discussion from !192587 should be addressed: - [ ] @project_278964_bot_079be3103ed333565a8fbea3be7252f4 started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/192587#note_2561199912): (+7 comments) > <!-- allure --> > # E2E Test Result Summary > [`allure-report-publisher`](https://github.com/andrcuns/allure-report-publisher) generated test report! > > <!-- jobs --> > <!-- e2e-test-on-cng --> > **e2e-test-on-cng**: ✅ [test report](http://gitlab-qa-allure-reports.s3.amazonaws.com/e2e-test-on-cng/renovate-gems/duo_api/1868632847/index.html) for [e4b129fb](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/192587/diffs?commit_id=e4b129fbb2316e7f6bd6c9dd29635dd727f1734e) > <details> > <summary>expand test summary</summary> > > ```markdown > +-------------------------------------------------------------------------------------+ > | suites summary | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | | passed | failed | skipped | flaky | total | result | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Plan | 85 | 0 | 9 | 0 | 94 | ✅ | > | Package | 29 | 0 | 15 | 0 | 44 | ✅ | > | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | > | Security Risk Management | 26 | 0 | 8 | 0 | 34 | ✅ | > | Tenant Scale | 29 | 0 | 12 | 0 | 41 | ✅ | > | Verify | 50 | 0 | 23 | 0 | 73 | ✅ | > | Create | 121 | 0 | 16 | 0 | 137 | ✅ | > | Software Supply Chain Security | 49 | 0 | 11 | 0 | 60 | ✅ | > | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | > | Deploy | 5 | 0 | 4 | 0 | 9 | ✅ | > | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | > | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | > | Ai-powered | 0 | 0 | 3 | 0 | 3 | ➖ | > | Analytics | 0 | 0 | 2 | 0 | 2 | ➖ | > | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Total | 408 | 0 | 135 | 0 | 543 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > ``` > </details> > <!-- e2e-test-on-cng --> > > <!-- e2e-test-on-gdk --> > **e2e-test-on-gdk**: ✅ [test report](http://gitlab-qa-allure-reports.s3.amazonaws.com/e2e-test-on-gdk/renovate-gems-duo-api/1868665347/index.html) for [e4b129fb](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/192587/diffs?commit_id=e4b129fbb2316e7f6bd6c9dd29635dd727f1734e) > <details> > <summary>expand test summary</summary> > > ```markdown > +-------------------------------------------------------------------------------------+ > | suites summary | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | | passed | failed | skipped | flaky | total | result | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Create | 117 | 0 | 16 | 0 | 133 | ✅ | > | Verify | 49 | 0 | 24 | 0 | 73 | ✅ | > | Package | 24 | 0 | 14 | 0 | 38 | ✅ | > | Manage | 1 | 0 | 9 | 0 | 10 | ✅ | > | Plan | 81 | 0 | 9 | 0 | 90 | ✅ | > | Software Supply Chain Security | 47 | 0 | 11 | 0 | 58 | ✅ | > | Security Risk Management | 26 | 0 | 8 | 0 | 34 | ✅ | > | Tenant Scale | 29 | 0 | 12 | 0 | 41 | ✅ | > | Monitor | 8 | 0 | 12 | 0 | 20 | ✅ | > | Growth | 0 | 0 | 2 | 0 | 2 | ➖ | > | Deploy | 5 | 0 | 4 | 0 | 9 | ✅ | > | Secure | 3 | 0 | 2 | 0 | 5 | ✅ | > | Analytics | 1 | 0 | 1 | 0 | 2 | ✅ | > | Ai-powered | 0 | 0 | 3 | 0 | 3 | ➖ | > | Fulfillment | 2 | 0 | 7 | 0 | 9 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Total | 393 | 0 | 134 | 0 | 527 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > ``` > </details> > <!-- e2e-test-on-gdk --> > > <!-- e2e-test-on-omnibus --> > **e2e-test-on-omnibus**: ✅ [test report](http://gitlab-qa-allure-reports.s3.amazonaws.com/e2e-test-on-omnibus/renovate-gems-duo-api/1868632864/index.html) for [e4b129fb](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/192587/diffs?commit_id=e4b129fbb2316e7f6bd6c9dd29635dd727f1734e) > <details> > <summary>expand test summary</summary> > > ```markdown > +-------------------------------------------------------------------------------------+ > | suites summary | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | | passed | failed | skipped | flaky | total | result | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Software Supply Chain Security | 2 | 0 | 0 | 0 | 2 | ✅ | > | Create | 4 | 0 | 0 | 0 | 4 | ✅ | > | Plan | 4 | 0 | 0 | 0 | 4 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > | Total | 10 | 0 | 0 | 0 | 10 | ✅ | > +--------------------------------+--------+--------+---------+-------+-------+--------+ > ``` > </details> > <!-- e2e-test-on-omnibus --> > <!-- jobs --> > <!-- allurestop -->