MR: Pending <!--NOTE: For context on MR heading, see: https://handbook.gitlab.com/handbook/engineering/development/dev/create/remote-development/index.html#relationship-of-issues-to-mrs--> ## Description All workspace components must have labels that are static across all workspaces in a cluster. This will enable Kubernetes cluster admins to manage workspaces better and also help team to run diagnostics on components with specific pairs of labels. We have conditionally added a label(`workspaces.gitlab.com/id`) as part of https://gitlab.com/gitlab-org/gitlab/-/merge_requests/189441+ since we needed it to wrap up https://gitlab.com/groups/gitlab-org/-/epics/12327+ . The reason we added it conditionally is because not doing so would mean we have to manage two versions of `devfile_parser` and `desired_config_generator` and also manage a DB migration to migrate the old config to the new one. This would complicate things as we work on https://gitlab.com/groups/gitlab-org/-/epics/17483+ . So this issue pertain to adding this label unconditionally once we wrap up https://gitlab.com/groups/gitlab-org/-/epics/17483+ . <!--TODO: What kind of issue is this? Please uncomment and include one of the following: /label ~"type::feature" /label ~"type::bug" /label ~"type::maintenance"--> <!--OPTIONAL: Is this a feature/enhancement? - Please describe the impact this feature/enhancement will have on the user experience and/or the product as a whole. - Provide a user story to illustrate the use case for this feature/enhancement. Include examples to help communicate the intended functionality.--> <!--OPTIONAL: Is this a bug? Please uncomment and include the following: - **Current behavior:** - **Expected behavior:** - **Steps to reproduce:** - **Additional information:** please include VSCode version, browser dev tool logs, etc that might be helpful to debug the issue!--> ## Acceptance criteria - [ ] Unconditionally add the label `workspaces.gitlab.com/id` to the workspace resources - [ ] Make relevant changes in the spec and clean it up ## Implementation plan - Update `ee/lib/remote_development/workspace_operations/reconcile/output/config_values_extractor.rb` to unconditionally add the label `workspaces.gitlab.com/id` in all workspace resources. - Update `ee/lib/remote_development/workspace_operations/reconcile/output/desired_config_generator.rb` to remove the condition checking the existence of the label `workspaces.gitlab.com/id` in the function generating the network policy. - Update `ee/spec/lib/remote_development/workspace_operations/reconcile/output/config_values_extractor_spec.rb` to remove the `describe "devfile_parser_params[:labels]"` block since we always add this label now. - Update `ee/spec/lib/remote_development/workspace_operations/reconcile/output/desired_config_generator_spec.rb` to remove the check for pod selector labels in the `context 'when shared_namespace is not empty'` block. - Update `ee/spec/support/shared_contexts/remote_development/remote_development_shared_contexts.rb` accordingly. <!--NOTE: Feel free to expand with more sections and headers as needed--> <!--DO NOT TOUCH BELOW-->