<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=513415) </details> <!--IssueSummary end--> This issue came from this discussion https://gitlab.com/gitlab-org/gitlab/-/merge_requests/177803#note_2298582249. ### About In the docs being added in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/177803, it explains how system hooks [are executed]((https://gitlab.com/gitlab-org/gitlab/-/blob/95be4945b1fcfe247599d94a60cc6a4a657a3ecf/app/models/project.rb#L1974)) when project webhooks are triggered (when `Project#execute_hooks` is called). ### Problem However, the same does not happen when `Group#execute_hooks` is called. From what I can see, for example, in `Member` and its EE-appended module we need to [manually trigger system hooks](https://gitlab.com/gitlab-org/gitlab/-/blob/c31eaf774d3780888d10361cbc5d8df230789b3a/app/models/member.rb#L679) in addition to [triggering group hooks](https://gitlab.com/gitlab-org/gitlab/-/blob/061a21e078d5473dac17c8a2dabb59f27f026e87/ee/app/models/ee/member.rb#L288), when if `Group#execute_hooks` had the same logic as `Project#execute_hooks` to [execute system hooks](https://gitlab.com/gitlab-org/gitlab/-/blob/95be4945b1fcfe247599d94a60cc6a4a657a3ecf/app/models/project.rb#L1974) at the same time we wouldn't need to do this. ### Proposal As part of issue refinement, we need to first verify that this change should happen, by inspecting current calls to `Group#execute_hooks` and to check that the logic of also executing system hooks at the same time should indeed happen. **If we determine that it should _not_ happen** We should update the section of `#execute_hooks` being added in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/177803 to explain why this is the case. **If we determine that it should happen** We should update the FOSS `Group#execute_hooks` method to execute system hooks (system hooks is FOSS feature). We must also then update existing areas that manually call system hooks in addition to group hooks - for example `Member` model mentioned above, and there may be others - so we don't end up having system hooks execute twice in this case. We should update the section of `#execute_hooks` being added in https://gitlab.com/gitlab-org/gitlab/-/merge_requests/177803 to mention that when called on a group, system hooks also automatically execute. We should wrap all changes in a feature flag.