<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/engineering/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=502245) </details> <!--IssueSummary end--> ## Background ## How to reproduce 1. Run GDK with a license and `FOSS_ONLY=0` 2. Go to http://gdk.test:3000/-/graphql-explorer 3. Run the following query ```graphql query getProjects { projects { nodes { name } } } ``` 4. Copy the `correlationId` 5. Paste into the performance bar in another GDK tab 6. Notice the N+1 ```sql SELECT "saml_providers".* FROM "saml_providers" WHERE "saml_providers"."group_id" = 35 LIMIT 1 SELECT "saml_providers".* FROM "saml_providers" WHERE "saml_providers"."group_id" = 197 LIMIT 1 ``` ## Trace ``` USE eager loading detected: Project => [:group] Add to your query: .includes([:group]) Project => [:group] Add to your query: .includes([:group]) Call stack /Users/peterhegman/Work/gitlab-development-kit/gitlab/ee/lib/gitlab/auth/group_saml/sso_enforcer.rb:20:in `access_restricted?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/ee/app/policies/ee/project_policy.rb:668:in `block (2 levels) in <module:ProjectPolicy>' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/models/ability.rb:89:in `allowed?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/allowable.rb:6:in `can?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/allowable.rb:11:in `block in can_all?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/allowable.rb:10:in `all?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/allowable.rb:10:in `can_all?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/object_authorization.rb:34:in `abilities_ok?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/object_authorization.rb:25:in `ok?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/graphql/types/base_object.rb:39:in `authorized?' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/field_extension.rb:44:in `block in remove_unauthorized' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/field_extension.rb:44:in `keep_if' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/field_extension.rb:44:in `remove_unauthorized' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/authorize/field_extension.rb:18:in `redact' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/connection_redaction.rb:16:in `redacted' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/connection_redaction.rb:23:in `nodes' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/graphql/tracers/instrumentation_tracer.rb:19:in `execute_multiplex' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/graphql/gitlab_schema.rb:44:in `multiplex' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/graphql_controller.rb:223:in `execute_query' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/graphql_controller.rb:67:in `execute' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/ip_address_state.rb:11:in `with' /Users/peterhegman/Work/gitlab-development-kit/gitlab/ee/app/controllers/ee/application_controller.rb:45:in `set_current_ip_address' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/application_controller.rb:497:in `set_current_admin' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/session.rb:11:in `with_session' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/application_controller.rb:488:in `set_session_storage' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/i18n.rb:114:in `with_locale' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/i18n.rb:120:in `with_user_locale' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/application_controller.rb:479:in `set_locale' /Users/peterhegman/Work/gitlab-development-kit/gitlab/app/controllers/application_controller.rb:472:in `set_current_context' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/action_controller_static_context.rb:23:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/metrics/elasticsearch_rack_middleware.rb:16:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/sidekiq_shard_awareness_validation.rb:20:in `block in call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/sidekiq_sharding/validator.rb:42:in `enabled' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/sidekiq_shard_awareness_validation.rb:20:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/memory_report.rb:13:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/speedscope.rb:13:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/query_limiting/middleware.rb:17:in `block in call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/query_limiting/transaction.rb:48:in `run' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/query_limiting/middleware.rb:16:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/database/load_balancing/rack_middleware.rb:23:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/rails_queue_duration.rb:33:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/etag_caching/middleware.rb:21:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/metrics/rack_middleware.rb:16:in `block in call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/metrics/web_transaction.rb:46:in `run' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/metrics/rack_middleware.rb:16:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/go.rb:21:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/query_analyzer.rb:11:in `block in call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/database/query_analyzer.rb:83:in `within' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/query_analyzer.rb:11:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/ci/job_token/middleware.rb:11:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/multipart.rb:173:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/read_only/controller.rb:50:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/read_only.rb:18:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/unauthenticated_session_expiry.rb:18:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/strip_cookies.rb:29:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/same_site_cookies.rb:27:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/path_traversal_check.rb:35:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/handle_malformed_strings.rb:21:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/basic_health_check.rb:25:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/handle_ip_spoof_attack_error.rb:25:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/request_context.rb:15:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/webhook_recursion_detection.rb:15:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/config/initializers/fix_local_cache_middleware.rb:11:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/compressed_json.rb:44:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/static.rb:11:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/rack_multipart_tempfile_factory.rb:19:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/sidekiq_web_static.rb:20:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/metrics/requests_rack_middleware.rb:79:in `call' /Users/peterhegman/Work/gitlab-development-kit/gitlab/lib/gitlab/middleware/release_env.rb:12:in `call' ```