MR edit page: Click on approver avatar should assign them as reviewer
<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=481971) </details> <!--IssueSummary end--> <!-- This issue template can be used as a great starting point for feature requests. Learn more about the process: https://handbook.gitlab.com/handbook/product/how-to-engage/#customer-feature-requests. The section "Release notes" can be used as a summary of the feature and is also required if you want to have your release post blog MR auto generated using the release post item generator: https://about.gitlab.com/handbook/marketing/blog/release-posts/#release-post-item-generator. The remaining sections are the backbone for every feature in GitLab. The goal of this template is brevity for quick/smaller iterations. For a more thorough list of considerations for larger features or feature sets, you can leverage the detailed [feature proposal](https://gitlab.com/gitlab-org/gitlab/-/blob/master/.gitlab/issue_templates/Feature%20proposal%20-%20detailed.md). --> ### Release notes When Code Owners are configured and approval rules are defined, the Merge Request form contains a table with projects members who can approve. Clicking on a user avatar in this table now assigns them as a reviewer. Before, a click would open their profile page, potentially losing the MR form data. ### Problem to solve In the `/merge_requests/:id/edit` form, user/member avatars are shown under `Code owner approval is required` if any such rules are configured. The avatars are linked to the `/:username` profile page, so that clicking them accidentally can abort the MR form and potentially lose edits. Browsers can help retain/restore those, but still. ### Proposal Assuming that the most likely scenario in that `/merge_requests/:id/edit` form is _wanting to complete_ the form: - we could implement a click action on the avatars that assign them as reviewers, - instead of linking the avatars to another page. It seems unlikely that anyone editing an MR would in that moment want to not assign the approvers, but see their profile page. ![image](/uploads/fae1c1e50292ca8be6c922f9ad20b82e/image.png) ### Intended users Anyone who creates MRs. * [Sasha (Software Developer)](https://handbook.gitlab.com/handbook/product/personas/#sasha-software-developer) * [Allison (Application Ops)](https://handbook.gitlab.com/handbook/product/personas/#allison-application-ops) * [Eddie (Content Editor)](https://handbook.gitlab.com/handbook/product/personas/#eddie-content-editor) ### Feature Usage Metrics <!-- How are you going to track usage of this feature? Think about user behavior and their interaction with the product. What indicates someone is getting value from it? Explore (../../doc/development/internal_analytics/internal_event_instrumentation/quick_start.md) for a guide. --> ### Does this feature require an audit event? <!--- Checkout these docs to know more https://docs.gitlab.com/ee/development/audit_event_guide/#what-are-audit-events https://docs.gitlab.com/ee/administration/audit_events.html ---> <!-- Label reminders Make sure to add the appropriate labels for the product stage and/or group (e.g ~"devops::plan") if known and add a comment tagging the appropriate Product Manager. Use the following resources to find the appropriate labels: - Use only one tier label choosing the lowest tier this is intended for - https://gitlab.com/gitlab-org/gitlab/-/labels - https://about.gitlab.com/handbook/product/categories/features/ Examples: /label ~group:: ~section:: ~Category: /label ~"GitLab Free" ~"GitLab Premium" ~"GitLab Ultimate" -->
issue