Frontend : about "toolbar" on the merge request's commit page
<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=477847) </details> <!--IssueSummary end--> ## Summary Let's look at the "toolbar" on the [merge request's commit page](https://gitlab.xfce.org/xfce/xfce4-dev-tools/-/merge_requests/98/diffs?commit_id=74c3c0541d82af719275b3883557d430886d455a): ![image](/uploads/4afee6ae76ba1410850b8f7287397c45/image.png) We have (from the left to the right): | No | item | object | | ------ | ------ | ------ | | 1. | `Hide file browser` toggle | view regulation | | 2. | `Viewing commit <commit SHA>` | current commit | | 3. | `< Prev` button | current commit | | 4. | `Next >` button | current commit | | 5. | `Show latest version` button | whole merge request | | 6. | Gap | - | | 7. | Stat hint | current commit | | 8. | `Preferences` button | view regulation | So: 1. There are many _different_ items in _one_ visual line. 2. The `current commit`/`whole merge request`/`view regulation` items are _mixed_. * Which includes the `Show latest version` button being misrepresented as the commit-switcher-like button (but it shows the whole merge request diff instead). See also https://gitlab.com/gitlab-org/gitlab/-/commit/3e66795ef1ff1228906239763910b051d8afcc37#note_2025786503. ### Why this matters and how we measure It _confuses_ the user. ## Proposal _Separate_ the `current commit`/`whole merge request`/`view regulation` items. Like: 1. Rearrange items. 2. Insert more gaps. 3. Introduce the second "toolbar", 4. etc. Thanks!
issue