Auto Merge button load time temporarily allows unauthorised immediate merge
<!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "type::bug" label: - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=type::bug and verify the issue you're about to submit isn't a duplicate. ---> ### Summary <!-- Summarize the bug encountered concisely. --> In the MR window, the merge button appears for a moment before being replaced by the "Set to auto merge" button appears. This button is clickable and allows users who would not be permitted to "merge immediately" to do so in a window of time that has caused unauthorised merges to occur. ### Steps to reproduce <!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. --> 1. Configure auto-merge. Be a user without permission to merge immediately. 2. Start a MR 3. On the resulting screen, the "Set to auto-merge button" may be "Merge" for a small ammount of time, during which time it will be clickable 4. Click this button and see that the request is merged ### Example Project <!-- If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report. If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version. --> On a customer project so I am not currently able to show project ### What is the current *bug* behavior? <!-- Describe what actually happens. --> Button says merge is temporarily clickable ### What is the expected *correct* behavior? <!-- Describe what you should see instead. --> Button should say "Set to auto-merge" at all times ### Relevant logs and/or screenshots <!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise. --> N/A ### Output of checks <!-- If you are reporting a bug on GitLab.com, uncomment below --> <!-- This bug happens on GitLab.com --> <!-- /label ~"reproduced on GitLab.com" --> N/A #### Results of GitLab environment info <!-- Input any relevant GitLab environment information if needed. --> N/A <details> <summary>Expand for output related to GitLab environment info</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`) </pre> </details> #### Results of GitLab application Check <!-- Input any relevant GitLab application check information if needed. --> N/A <details> <summary>Expand for output related to the GitLab application check</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`) (we will only investigate if the tests are passing) </pre> </details> ### Possible fixes <!-- If you can, link to the line of code that might be responsible for the problem. -->
issue