<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=415294) </details> <!--IssueSummary end--> The following discussion from !120770 should be addressed: - [ ] @iamphill started a [discussion](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/120770#note_1428330185): (+1 comment) > For this component we should use `<state-container />` like the other state components so it would end up something like: > > ```vue > <script> > import StateContainer from '../state_container.vue'; > import { MR_WIDGET_PREPARING_ASYNCHRONOUSLY } from '../../i18n'; > > export default { > name: 'MRWidgetPreparing', > i18n: { > preparing: MR_WIDGET_PREPARING_ASYNCHRONOUSLY, > }, > components: { > StateContainer, > }, > }; > </script> > <template> > <state-container status="loading"> > {{ $options.i18n.preparing }} > </state-container> > </template> > > ``` ### Problem The spinner in the MR isn't the standard size we use for most of the rest of the widgets. ### Possible Solutions 1. Do nothing. Allow some custom variants. 1. Use `state-container` as-is. 1. Update the `state-container` (and it's nested child components) to take a size parameter. 1. Bring in design to take a look at the unified approach and see if there's a middle ground. ### Associated Notes 1. We should document the boundary rules, like "spinner sizes may vary when only one can be visible at a time" (as with the preparing widget) 1. Design explicitly chose to not use the `sm` spinner size that `state-container` renders 1. Allowing for sizes may subvert the intent of a single component that unifies the look of the available spinners 1. They've already looked at small versus medium spinners in this context and felt that medium was better.