<!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "type::bug" label: - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=type::bug and verify the issue you're about to submit isn't a duplicate. ---> ### Summary <!-- Summarize the bug encountered concisely. --> Webhook payload data for Merge Request Approved events contain an incorrect `updated_at` field in the `object_attributes`. It seems that the `updated_at` timestamp is updated in the `MergeRequest` model record after the Webhook is sent. A customer engaged Support regarding this behaviour. ZenDesk ticket refers ([internal](https://gitlab.zendesk.com/agent/tickets/414665)). They expect the `updated_at` timestamp in the Webhook payload to contain the timestamp resulting from the approval action. Example timings from my testing: ``` Webhook received: 2023-06-07 05:14:11 UTC Webhook payload updated_at: 2023-06-07 05:08:09 UTC Rails Model updated_at: 2023-06-07 05:14:11.244585000 UTC +00:001 ``` ### Steps to reproduce <!-- Describe how one can reproduce the issue - this is very important. Please use an ordered list. --> 1. Setup a Webhook for Merge Request events 1. Create a new branch 1. Create an MR for the new branch 1. Wait 60s 1. Add a file/change to the source branch. Confirm `updated_at` in Webhook payload is the same as `updated_at` in the `MergeRequest` model record 1. Wait 60s 1. Add a Reviewer to the MR. Confirm `updated_at` in Webhook payload is the same as `updated_at` in the `MergeRequest` model record 1. Wait 60s 1. Approve the MR. `updated_at` in the Webhook payload is **not** the same as `updated_at` in the `MergeRequest` model record 1. Wait 60s 1. Unapprove the MR. Confirm `updated_at` in Webhook payload is the same as `updated_at` in the `MergeRequest` model record ### Example Project <!-- If possible, please create an example project here on GitLab.com that exhibits the problematic behavior, and link to it here in the bug report. If you are using an older version of GitLab, this will also determine whether the bug is fixed in a more recent version. --> ### What is the current *bug* behavior? <!-- Describe what actually happens. --> The Webhook for Merge Request Approved action event contains the `updated_at` timestamp from **before** the approval. This is not consistent with other actions and their Webhook payloads. ### What is the expected *correct* behavior? <!-- Describe what you should see instead. --> The `updated_at` for each action should ideally contain the timestamp of the update corresponding to the action ### Relevant logs and/or screenshots <!-- Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise. --> ### Output of checks <!-- If you are reporting a bug on GitLab.com, uncomment below --> <!-- This bug happens on GitLab.com --> <!-- /label ~"reproduced on GitLab.com" --> #### Results of GitLab environment info <!-- Input any relevant GitLab environment information if needed. --> <details> <summary>Expand for output related to GitLab environment info</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:env:info`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:env:info RAILS_ENV=production`) </pre> </details> #### Results of GitLab application Check <!-- Input any relevant GitLab application check information if needed. --> <details> <summary>Expand for output related to the GitLab application check</summary> <pre> (For installations with omnibus-gitlab package run and paste the output of: `sudo gitlab-rake gitlab:check SANITIZE=true`) (For installations from source run and paste the output of: `sudo -u git -H bundle exec rake gitlab:check RAILS_ENV=production SANITIZE=true`) (we will only investigate if the tests are passing) </pre> </details> ### Possible fixes <!-- If you can, link to the line of code that might be responsible for the problem. -->