Rename `strong_memoize_attr` to `strong_memoize`
<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=385062) </details> <!--IssueSummary end--> The use `_attr` suffix is confusing since it's we are memoizing a method not an attribute. So instead ```ruby def expensive_method end strong_memoize_attr :expensive_method ``` it's ```ruby def expensive_method end strong_memoize :expensive_method ``` and potentially (out of scope) ```ruby strong_memoize def expensive_method end ``` ## Tasks - [ ] Rename method to `strong_memoize` adding a "grace period" :point_down: - [ ] Keep old method and emit a warning to avoid broken master - [ ] Rename :cop: rule `Gitlab/StrongMemoizeAttr` to `Gitlab/StrongMemoize` or `Gitlab/StrongMemoizeAnnotation` (seperate issue) ## Risks The method name might be confused with the instance method `strong_memoize` but that should be a problem since we are migrating (see :cop: `Gitlab/StrongMemomizeAttr`) to class level memoization anyway.
issue