<!-- Title suggestion: [Feature flag] Enable description of feature --> #### Current `.com` FF status - Dev: Enabled - Staging: Enabled - Prod: Enabled fully (see [specific proposal for timeframe](https://gitlab.com/gitlab-org/gitlab/-/issues/363445#calendar-clock10-arrow_forward-specific-proposal-arrow_backward-clock10-calendar) below) ## Summary This issue is to rollout [blocking weak passwords](https://gitlab.com/gitlab-org/gitlab/-/issues/23610) on production, that will be behind the default-disabled `block_weak_passwords` feature flag when https://gitlab.com/gitlab-org/gitlab/-/merge_requests/86310+ is merged. https://gitlab.com/gitlab-org/gitlab/-/issues/23610+ provides an overview, but in short when `block_weak_passwords` is enabled a user cannot register with a weak password nor can they change their password to a weak one. Same applies to admins creating/updating users via the API or rails console commands. Weak is defined as: * Matching, case-insensitive, one of statically defined set of 4500 weak passwords (`config/weak_passwords.yml`) * *Containing*, case-insensitive, a static set of forbidden words (https://gitlab.com/gitlab-org/gitlab/-/merge_requests/86310/diffs#81e6a5480565c2b30ab6c2ca07e7f5495a69e2c4_0_4) * *Containing*, case-insensitive, elements of the following which are `>= 4` characters long: * The user's name * The user's username * The user's email address This feature flag SHOULD NOT be enabled until all the issues in "Is blocked by" below have been closed. ## High level plan - Enable the feature flag on .com - Measure impact for `X time` - Ship a release which enables the feature flag for self-managed + Add a release post notes on how to disable it, and our intention to remove the ability to disable it + Will cause a "brown out", i.e. self-managed deployments that have automation creating users with weak passwords will start exploding + Avoid a scenario like https://gitlab.com/gitlab-org/gitlab/-/issues/340848#note_1085667027 + Self-managed admins can toggle the feature flag off if needed - Ship a release with the feature flag code removed + TBC what release this is, and whether it needs to wait for %"16.0". + https://docs.gitlab.com/ee/development/deprecation_guidelines/ ## Owners - Team: ~"group::authentication and authorization" - Most appropriate slack channel to reach out to: `#g_manage_auth` - Best individual to reach out to: @nmalcolm - PM: @hsutor ## Stakeholders - ~"devops::growth" as changes to signup flows may impact conversion - AppSec ## Expectations ### What are we expecting to happen? Users, or administrators creating & updating users, can no longer choose a weak password. ### When is the feature viable? When the "Is blocked by" issues below are resolved. ### What might happen if this goes wrong? It is easy and non-destructive to DISABLE the feature flag if needed. - **User registration metrics may decrease** + Potential Prevention: identify how many new users currently choose weak passwords, to gauge impact + Potential Prevention: warn users beforehand + Potential Detection: implement metrics + Potential Mitigation: inform stakeholders at GitLab - **Automations** which create users / bots and give them weak passwords **will break** + Potential Prevention: The best bet here is comms, before and after rollout - If there is a bug + e.g. User registrations may be blocked, even those using social sign ons + e.g. User updates may be blocked, even those where they aren't changing their password + Potential Detection: monitor error rates + Potential Remediation: Disabling the feature flag should resolve this until the bug is better understood ### What can we monitor to detect problems with this? Snowplow metrics: https://gitlab.com/gitlab-org/gitlab/-/issues/363535+ Visit https://app.periscopedata.com/app/gitlab/539181/Snowplow-Event-Exploration---last-30-days and filter for `action = track_weak_password_error` or `category = Gitlab::Tracking::Helpers::WeakPasswordErrorEvent`. ### What can we check for monitoring production after rollouts? As above ## Rollout Steps ### Rollout on non-production environments - Ensure that the feature MRs have been deployed to non-production environments. - [x] `/chatops run auto_deploy status <merge-commit-of-your-feature>` - [x] Enable the feature globally on non-production environments. - [x] `/chatops run feature set block_weak_passwords true --dev` - [x] `/chatops run feature set block_weak_passwords true --staging` - [x] Verify that the feature works as expected. Posting the QA result in this issue is preferable. The best environment to validate the feature in is [staging-canary](https://about.gitlab.com/handbook/engineering/infrastructure/environments/#staging-canary) as this is the first environment deployed to. Note you will need to make sure you are configured to use canary as outlined [here](https://about.gitlab.com/handbook/engineering/infrastructure/environments/canary-stage/) when accessing the staging environment in order to make sure you are testing appropriately. ### ~~Specific rollout on production~~ > we can skip the `Specific rollout on production` because the feature flag does not have any actor. <details> <summary>Checklist</summary> - Ensure that the feature MRs have been deployed to both production and canary. - [ ] `/chatops run auto_deploy status <merge-commit-of-your-feature>` - If you're using [project-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --project=gitlab-org/gitlab,gitlab-org/gitlab-foss,gitlab-com/www-gitlab-com block_weak_passwords true` - If you're using [group-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --group=gitlab-org,gitlab-com block_weak_passwords true` - If you're using [user-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --user=<your-username> block_weak_passwords true` - [ ] Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable. </details> ### Preparation before global rollout - [x] Check if the feature flag change needs to be accompanied with a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process). Cross link the issue here if it does. - N/A: https://gitlab.com/gitlab-org/gitlab/-/issues/363445#note_1160666531 - [x] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias. + @nmalcolm - [x] Ensure that documentation has been updated ([More info](https://docs.gitlab.com/ee/development/documentation/feature_flags.html#features-that-became-enabled-by-default)). + https://gitlab.com/gitlab-org/gitlab/-/merge_requests/103278+ - [x] Announce on [the feature issue](ISSUE LINK) an estimated time this will be enabled on GitLab.com. - [x] Ensure that any breaking changes have been announced following the [release post process](https://about.gitlab.com/handbook/marketing/blog/release-posts/#deprecations-removals-and-breaking-changes) to ensure GitLab customers are aware. - N/A: https://gitlab.com/gitlab-org/gitlab/-/issues/363445#note_1160666531 - [x] Notify `#support_gitlab-com` and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#communicate-the-change)). + https://gitlab.slack.com/archives/C4XFU81LG/p1667864591705999 ### Global rollout on production For visibility, all `/chatops` commands that target production should be executed in the `#production` slack channel and cross-posted (with the command results) to the responsible team's slack channel (`#g_TEAM_NAME`). - [x] [Incrementally roll out](https://docs.gitlab.com/ee/development/feature_flags/controls.html#process) the feature. - If the feature flag in code has [an actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), perform **actor-based** rollout. - [ ] `/chatops run feature set block_weak_passwords <rollout-percentage> --actors` - If the feature flag in code does **NOT** have [an actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), perform time-based rollout (**random** rollout). - [x] `/chatops run feature set block_weak_passwords <rollout-percentage> --random` - Enable the feature globally on production environment. - [ ] `/chatops run feature set block_weak_passwords true` - [x] Announce on [the feature issue](ISSUE LINK) that the feature has been globally enabled. - [ ] Wait for [at least one day for the verification term](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release). #### :calendar: :clock10: :arrow_forward: Specific proposal :arrow_backward: :clock10: :calendar: - [x] `2022-11-08T0200Z` (or earlier) `@nmalcolm` post to `#support_gitlab-com` to give 24hrs notice, linking to this issue. Also create a documentation MR about the FF state. - https://gitlab.slack.com/archives/C4XFU81LG/p1667864591705999 - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/103278+ - [x] `2022-11-10T0130Z` `@nmalcolm` enable 10% random rollout. Monitor SiSense. - [x] `2022-11-10T1100Z`(ish) `@ifarkas` or ~"group::authentication and authorization" enable 50% random rollout. Monitor SiSense. - [x] `2022-11-11T0000Z` `@nmalcolm` enable 100% production rollout. Monitor SiSense. Ask for the FF doc MR to be merged. - Docs MR was already merged - Slack message: https://gitlab.slack.com/archives/C101F3796/p1668124977960969 :arrow_up: :arrow_up: :arrow_up: :arrow_up: ### (Optional) Release the feature with the feature flag We won't be doing this step. See https://gitlab.com/gitlab-com/www-gitlab-com/-/merge_requests/110858#note_1166106827 <details> <summary>Checklist</summary> If you're still unsure whether the feature is [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release) but want to release it in the current milestone, you can change the default state of the feature flag to be enabled. To do so, follow these steps: - [ ] Create a merge request with the following changes. Ask for review and merge it. - [ ] Set the `default_enabled` attribute in [the feature flag definition](https://docs.gitlab.com/ee/development/feature_flags/#feature-flag-definition-and-validation) to `true`. - [ ] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog). - [ ] Ensure that the default-enabling MR has been included in the release package. If the merge request was deployed before [the monthly release was tagged](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post. - [ ] `/chatops run release check <merge-request-url> <milestone>` - [ ] Consider cleaning up the feature flag from all environments by running these chatops command in `#production` channel. Otherwise these settings may override the default enabled. - [ ] `/chatops run feature delete block_weak_passwords --dev` - [ ] `/chatops run feature delete block_weak_passwords --staging` - [ ] `/chatops run feature delete block_weak_passwords` - [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [ ] Set the next milestone to this rollout issue for scheduling [the flag removal](#release-the-feature). - [ ] (Optional) You can [create a separate issue](https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Feature%20Flag%20Cleanup) for scheduling the steps below to [Release the feature](#release-the-feature). - [ ] Set the title to "[Feature flag] Cleanup `block_weak_passwords`". - [ ] Execute the `/copy_metadata <this-rollout-issue-link>` quick action to copy the labels from this rollout issue. - [ ] Link this rollout issue as a related issue. - [ ] Close this rollout issue. **WARNING:** This approach has the downside that it makes it difficult for us to [clean up](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) the flag. For example, on-premise users could disable the feature on their GitLab instance. But when you remove the flag at some point, they suddenly see the feature as enabled and they can't roll it back to the previous behavior. To avoid this potential breaking change, use this approach only for urgent matters. </details> ### Release the feature After the feature has been [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release), the [clean up](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase. You can either [create a follow-up issue for Feature Flag Cleanup](https://gitlab.com/gitlab-org/gitlab/-/issues/new?issuable_template=Feature%20Flag%20Cleanup) or use the checklist below in this same issue. <!-- The checklist here is to help stakeholders keep track of the feature flag status --> - [x] Create a merge request to remove `block_weak_passwords` feature flag. Ask for review and merge it. - [x] Remove all references to the feature flag from the codebase. - [x] Remove the YAML definitions for the feature from the repository. - [x] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog). - https://gitlab.com/gitlab-org/gitlab/-/merge_requests/103702+ - [x] Ensure that the cleanup MR has been included in the release package. If the merge request was deployed before [the monthly release was tagged](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post. - [x] `/chatops run release check <merge-request-url> <milestone>` - https://gitlab.slack.com/archives/C101F3796/p1669951297059539 - [x] Close [the feature issue](https://gitlab.com/gitlab-org/gitlab/-/issues/23610) to indicate the feature will be released in the current milestone. - [x] If not already done, clean up the feature flag from all environments by running these chatops command in `#production` channel: - [x] `/chatops run feature delete block_weak_passwords --dev` - [x] `/chatops run feature delete block_weak_passwords --staging` - [x] `/chatops run feature delete block_weak_passwords` - [x] Close this rollout issue. ## Rollback Steps - [ ] This feature can be disabled by running the following Chatops command: ``` /chatops run feature set block_weak_passwords false ``` ## Customer Support If a customer is experiencing the error message `Password must not contain commonly used combinations of words and letters`, then they are attempting to choose a weak or breached password. We should encourage them to choose a unique password. https://docs.gitlab.com/ee/user/profile/user_passwords.html#block-weak-passwords