<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=352411) </details> <!--IssueSummary end--> <!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "type::bug" label: - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab/issues?label_name%5B%5D=type::bug and verify the issue you're about to submit isn't a duplicate. ---> ### Summary It looks like synchronizing build data with Jira is inconsistent. We use the [`/rest/builds/0.1/bulk`](https://developer.atlassian.com/cloud/jira/software/rest/api-group-builds/) endpoint to send data to Jira Looking at the [background worker logs](https://log.gprd.gitlab.net/goto/68d900e0-7e9d-11ec-a649-b7cbb8e4f62e) we see some failures, but they don't seem to be related to the missing builds. However, if we check [JiraConnect integration logs](https://log.gprd.gitlab.net/goto/22f41080-891d-11ec-a649-b7cbb8e4f62e) there are some error responses: ``` {"errorMessages":["Instantiation of [simple type, class com.atlassian.jira.plugin.devstatus.devinfo.schema.DevInformationTOImpl] value failed: null"]} ``` (Logged at Feb 8, 2022 @ 10:32:50.868) and **Note:** This has been a bug in our logging where we treaded HTTP `202` responses as `"Unknown error"`. This has been fixed with https://gitlab.com/gitlab-org/gitlab/-/merge_requests/81986. More details [here](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/81986#note_861316567) ``` {"errorMessages":["Unknown error"],"response":{"unknownIssueKeys":[],"acceptedBuilds":[{"pipelineId":"35741210","buildNumber":3}],"rejectedBuilds":[]}} ``` (Logged at Feb 8, 2022 @ 09:46:00.282) ### What should be checked We should, set up the Jira Cloud App and some environment, and try to use combination of Jira keys, namely in: * branch name * commit message * MR title * MR description * combination of both MR (title and description) Validate that it works for all of them, and the builds are displayed under the issue's detail page. ### Steps to reproduce 1. Start a Gitpod for the `gitlab-org/gitlab` project. 1. [Enable runners](https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/gitpod.md#enable-runners). 1. Create a project with a `.gitlab-ci.yml` file. 1. Create an MR on that project and trigger builds until one fails. **In addition to the steps above, we could reproduce the missing deployments/builds problem:** - Branch containing JIRA issue key 1. Create a branch that contains Jira issue key (e.g.: `MYPROJECT-123`) 2. Create an MR without issue keys in the title or description 3. Validate that the correct issue has been linked in the summary page - MR title containing JIRA issue key 1. Create an MR with JIRA issue keys only in the title 2. Validate that the correct issue has been linked in the summary page - MR description containing JIRA issue key 1. Create an MR with JIRA issue keys only in the description 2. Validate that the JIRA issue is **not synchronized** in the summary page _As we can see that issue is only when JIRA issue keys are stored in the MR's description._ **note**: Having an issue key in title and description works as expected. ### Example Project https://gitlab.com/cmutua-free-group/feb7-jira-builds/-/merge_requests/1 ### What is the current *bug* behavior? Sometimes build data doesn't show up in Jira ### What is the expected *correct* behavior? Builds should reliably show up in Jira ### Relevant logs and/or screenshots See summary ### Output of checks This bug happens on GitLab.com ### Possible fixes 1. #390888+ this will probably fix #352411 See [discussion](https://gitlab.com/gitlab-org/gitlab/-/issues/352411#note_1271225923). ### Additional follow-up improvements from our investigation 1. https://gitlab.com/gitlab-org/gitlab/-/issues/354373+ 1. #390887+ I think this will not be visible for users and more of an performance improvement because we don't have to send data that gets rejected by Jira anyway. 1. https://gitlab.com/gitlab-org/gitlab/-/issues/390889+ This is probably also a performance improvement. See [discussion](https://gitlab.com/gitlab-org/gitlab/-/issues/352411#note_1271225923). ### Customer impact - [Ultimate, 113 users](https://gitlab.my.salesforce.com/0014M00001ySB9zQAG) - [Premium, 15 users](https://gitlab.my.salesforce.com/0014M00001sG45mQAC) - [Premium, 8 users](https://gitlab.my.salesforce.com/0014M00001kDyxsQAC) Per our [Prioritization Table](https://app.periscopedata.com/app/gitlab:safe-intermediate-dashboard/970771/User-Request-Issue-Prioritization---Product), this issue ranks 18 with a priority score of 299k, which I would rate as fairly high impact. That said, we do have some higher priority issues in our current plans.