<!-- Title suggestion: [Feature flag] Enable description of feature --> ## Summary This issue is to track the [DestroyAllExpiredService](https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76504), that is currently behind the `ci_destroy_all_expired_service` feature flag, which has been turned off by default and left off in production on gitlab.com. - Turned off by default for self hosted instances in 14.6: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/76504 - Turned off by chatops for gitlab.com on January 19th: https://gitlab.slack.com/archives/C101F3796/p1642639219346000 We've had to turn this service off in order to maintain good service due to https://gitlab.com/gitlab-com/gl-infra/production/-/issues/5952 and https://gitlab.com/groups/gitlab-org/-/epics/7097, and we can turn the service back on for dot-com and self hosted once we fix the expiration timestamps in each environment. - https://gitlab.com/gitlab-org/gitlab/-/issues/353128 will track the expiration cleanup work for self-hosted instances - https://gitlab.com/gitlab-org/gitlab/-/issues/322817 will track the expiration cleanup work for gitlab.com Once those issues are closed, we'll be able to restart the work for the corresponding environment. On an ongoing basis, the worker is running we'd like to be able to turn it on and off directly in chatops without needing to submit cron schedule MRs to the infra team, e.g. https://gitlab.com/gitlab-com/gl-infra/k8s-workloads/gitlab-com/-/merge_requests/1393 until we know we've set up our batching and scheduling in a way that we won't want to modify for the forseeable future. ## Owners - Team: ~"group::pipeline execution" - Most appropriate slack channel to reach out to: `#verify-reliability-engineering-allocation` - Best individual to reach out to: @drew & @mattkasa - PM: @jheimbuck_gl , @jreporter ## Stakeholders <!-- Are there any other stages or teams involved that need to be kept in the loop? - Name of a PM - The Support Team - The Delivery Team --> ## Expectations ### What are we expecting to happen? We're not expecting to use this often. We have another flag that controls the number of records we limit ourselves to removing on each execution, and that will be how we keep granular control over the expiration of job artifacts. But if we need to ever shut off the service completely, this will be here. ### When is the feature viable? Right away. We don't expect this to immediately cause any issues, so we'll turn it on right after deployment. ### What might happen if this goes wrong? <!-- Should the feature flag be turned off? Any MRs that need to be rolled back? Communication that needs to happen? What are some things you can think of that could go wrong - data loss or broken pages? --> ### What can we monitor to detect problems with this? <!-- Which dashboards from https://dashboards.gitlab.net are most relevant? --> _Consider mentioning checks for 5xx errors or other anomalies like an increase in redirects (302 HTTP response status)_ ### What can we check for monitoring production after rollouts? _Consider adding links to check for Sentry errors, Production logs for 5xx, 302s, etc._ ## Rollout Steps ### Rollout on non-production environments - Ensure that the feature MRs have been deployed to non-production environments. - [x] `/chatops run auto_deploy status <merge-commit-of-your-feature>` - [x] Enable the feature globally on non-production environments. - [x] `/chatops run feature set <feature-flag-name> true --dev` - [x] `/chatops run feature set <feature-flag-name> true --staging` - [x] Verify that the feature works as expected. Posting the QA result in this issue is preferable. ### Specific rollout on production - Ensure that the feature MRs have been deployed to both production and canary. - [x] `/chatops run auto_deploy status <merge-commit-of-your-feature>` - If you're using [project-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --project=gitlab-org/gitlab <feature-flag-name> true` - [ ] `/chatops run feature set --project=gitlab-org/gitlab-foss <feature-flag-name> true` - [ ] `/chatops run feature set --project=gitlab-com/www-gitlab-com <feature-flag-name> true` - If you're using [group-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --group=gitlab-org <feature-flag-name> true` - [ ] `/chatops run feature set --group=gitlab-com <feature-flag-name> true` - If you're using [user-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - [ ] `/chatops run feature set --user=<your-username> <feature-flag-name> true` - [x] Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable. ### Preparation before global rollout - [x] Check if the feature flag change needs to be accompanied with a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process). Cross link the issue here if it does. - [x] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias. - [x] Ensure that documentation has been updated ([More info](https://docs.gitlab.com/ee/development/documentation/feature_flags.html#features-that-became-enabled-by-default)). - [x] Announce on [the feature issue](ISSUE LINK) an estimated time this will be enabled on GitLab.com. - [x] Notify `#support_gitlab-com` and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#communicate-the-change)). ### Global rollout on production For visibility, all `/chatops` commands that target production should be executed in the `#production` slack channel and cross-posted (with the command results) to the responsible team's slack channel (`#g_TEAM_NAME`). - [ ] [Incrementally roll out](https://docs.gitlab.com/ee/development/feature_flags/controls.html#process) the feature. - If the feature flag in code has [an actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), perform **actor-based** rollout. - [ ] `/chatops run feature set <feature-flag-name> <rollout-percentage> --actors` - If the feature flag in code does **NOT** have [an actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), perform time-based rollout (**random** rollout). - [ ] `/chatops run feature set <feature-flag-name> <rollout-percentage>` - Enable the feature globally on production environment. - [ ] `/chatops run feature set <feature-flag-name> true` - [x] Announce on [the feature issue](ISSUE LINK) that the feature has been globally enabled. - [x] Wait for [at least one day for the verification term](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release). ### (Optional) Release the feature with the feature flag If you're still unsure whether the feature is [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release) but want to release it in the current milestone, you can change the default state of the feature flag to be enabled. To do so, follow these steps: - [x] Create a merge request with the following changes. Ask for review and merge it. - [ ] Set the `default_enabled` attribute in [the feature flag definition](https://docs.gitlab.com/ee/development/feature_flags/#feature-flag-definition-and-validation) to `true`. - [ ] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog). - [x] Ensure that the default-enabling MR has been deployed to both production and canary. If the merge request was deployed before [the code cutoff](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post. - [ ] `/chatops run auto_deploy status <merge-commit-of-default-enabling-mr>` - [x] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [x] Set the next milestone to this rollout issue for scheduling [the flag removal](#release-the-feature). - [ ] (Optional) You can create a separate issue for scheduling the steps below to [Release the feature](#release-the-feature). - [ ] Set the title to "[Feature flag] Cleanup `<feature-flag-name>`". - [ ] Execute the `/copy_metadata <this-rollout-issue-link>` quick action to copy the labels from this rollout issue. - [ ] Link this rollout issue as a related issue. - [ ] Close this rollout issue. **WARNING:** This approach has the downside that it makes it difficult for us to [clean up](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) the flag. For example, on-premise users could disable the feature on their GitLab instance. But when you remove the flag at some point, they suddenly see the feature as enabled and they can't roll it back to the previous behavior. To avoid this potential breaking change, use this approach only for urgent matters. ### Release the feature After the feature has been [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release), the [clean up](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase. <!-- The checklist here is to help stakeholders keep track of the feature flag status --> - [x] Create a merge request to remove `<feature-flag-name>` feature flag. Ask for review and merge it. - [ ] Remove all references to the feature flag from the codebase. - [ ] Remove the YAML definitions for the feature from the repository. - [ ] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog). - [x] Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before [the code cutoff](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post. - [ ] `/chatops run auto_deploy status <merge-commit-of-cleanup-mr>` - [ ] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [x] Clean up the feature flag from all environments by running these chatops command in `#production` channel: - [x] `/chatops run feature delete <feature-flag-name> --dev` - [x] `/chatops run feature delete <feature-flag-name> --staging` - [x] `/chatops run feature delete <feature-flag-name>` - [x] Close this rollout issue. ## Rollback Steps - [x] This feature can be disabled by running the following Chatops command: ``` /chatops run feature set <feature-flag-name> false ```