<!-- Title suggestion: [Feature flag] Enable description of feature --> ## Summary This issue is to rollout [the feature](https://gitlab.com/gitlab-org/gitlab/-/issues/345055) on production, that is currently behind the `packages_conan_allow_empty_username_channel` feature flag. <!-- Short description of what the feature is about and link to relevant other issues. --> ## Owners - Team: Package - Most appropriate slack channel to reach out to: `#s_package` - Best individual to reach out to: @10io or `#s_package` - PM: @trizzi - EM: @michelletorres ## Stakeholders n / a ## Expectations ### What are we expecting to happen? Conan packages with empty username _and_ empty channel can be pushed to the [GitLab Conan Package Registry](https://docs.gitlab.com/ee/user/packages/conan_repository) ### When is the feature viable? When the ~"feature flag" is fully enabled. ### What might happen if this goes wrong? Conan packages can't be pushed. ### What can we monitor to detect problems with this? * https://dashboards.gitlab.net/d/api-rails-controller/api-rails-controller?orgId=1&var-PROMETHEUS_DS=Global&var-environment=gprd&var-stage=main&var-controller=Grape&var-action=GET%20%2Fapi%2Fprojects&var-action=PUT%20%2Fapi%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fexport%2F:file_name&var-action=PUT%20%2Fapi%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fexport%2F:file_name%2Fauthorize&var-action=PUT%20%2Fapi%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fpackage%2F:conan_package_reference%2F:package_revision%2F:file_name&var-action=PUT%20%2Fapi%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fpackage%2F:conan_package_reference%2F:package_revision%2F:file_name%2Fauthorize&var-action=PUT%20%2Fapi%2Fprojects%2F:id%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fexport%2F:file_name&var-action=PUT%20%2Fapi%2Fprojects%2F:id%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fexport%2F:file_name%2Fauthorize&var-action=PUT%20%2Fapi%2Fprojects%2F:id%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fpackage%2F:conan_package_reference%2F:package_revision%2F:file_name&var-action=PUT%20%2Fapi%2Fprojects%2F:id%2Fpackages%2Fconan%2Fv1%2Ffiles%2F:package_name%2F:package_version%2F:package_username%2F:package_channel%2F:recipe_revision%2Fpackage%2F:conan_package_reference%2F:package_revision%2F:file_name%2Fauthorize * https://log.gprd.gitlab.net/goto/2e17e6b15420895bd16066a00fd1cddc * The amount of `400` responses should be really close to `0` ### What can we check for monitoring production after rollouts? Amount of `400` responses in https://log.gprd.gitlab.net/goto/2e17e6b15420895bd16066a00fd1cddc ## Rollout Steps ### Rollout on non-production environments - Ensure that the feature MRs have been deployed to non-production environments. - [x] `/chatops run auto_deploy status ba0fb5ab994d1759a7f1dc56543a70a5c32595ee` - [x] Enable the feature globally on non-production environments. - [x] `/chatops run feature set packages_conan_allow_empty_username_channel true --dev` - [x] `/chatops run feature set packages_conan_allow_empty_username_channel true --staging` - [x] Verify that the feature works as expected. Posting the QA result in this issue is preferable. ### Specific rollout on production - Ensure that the feature MRs have been deployed to both production and canary. - [x] `/chatops run auto_deploy status ba0fb5ab994d1759a7f1dc56543a70a5c32595ee` - If you're using [project-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - ~~[ ] `/chatops run feature set --project=gitlab-org/gitlab packages_conan_allow_empty_username_channel true`~~ - ~~[ ] `/chatops run feature set --project=gitlab-org/gitlab-foss packages_conan_allow_empty_username_channel true`~~ - ~~[ ] `/chatops run feature set --project=gitlab-com/www-gitlab-com packages_conan_allow_empty_username_channel true`~~ - If you're using [group-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - ~~[ ] `/chatops run feature set --group=gitlab-org packages_conan_allow_empty_username_channel true`~~ - ~~[ ] `/chatops run feature set --group=gitlab-com packages_conan_allow_empty_username_channel true`~~ - If you're using [user-actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), you must enable the feature on these entries: - ~~[ ] `/chatops run feature set --user=<your-username> packages_conan_allow_empty_username_channel true`~~ - ~~[ ] Verify that the feature works on the specific entries. Posting the QA result in this issue is preferable.~~ ### Preparation before global rollout - ~~[ ] Check if the feature flag change needs to be accompanied with a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process).~~ Cross link the issue here if it does. - [x] Ensure that you or a representative in development can be available for at least 2 hours after feature flag updates in production. If a different developer will be covering, or an exception is needed, please inform the oncall SRE by using the `@sre-oncall` Slack alias. - [x] Ensure that documentation has been updated ([More info](https://docs.gitlab.com/ee/development/documentation/feature_flags.html#features-that-became-enabled-by-default)). - [x] Announce on [the feature issue](ISSUE LINK) an estimated time this will be enabled on GitLab.com. - [x] Notify `#support_gitlab-com` and your team channel ([more guidance when this is necessary in the dev docs](https://docs.gitlab.com/ee/development/feature_flags/controls.html#communicate-the-change)). ### Global rollout on production For visibility, all `/chatops` commands that target production should be: - Executed in the `#production` slack channel. - Cross-posted (with the command results) to the responsible team's slack channel (`#g_TEAM_NAME`). - [x] [Incrementally roll out](https://docs.gitlab.com/ee/development/feature_flags/controls.html#process) the feature. - If the feature flag in code does **NOT** have [an actor](https://docs.gitlab.com/ee/development/feature_flags/#feature-actors), perform time-based rollout (**random** rollout). - [x] `/chatops run feature set packages_conan_allow_empty_username_channel 20` - [x] `/chatops run feature set packages_conan_allow_empty_username_channel 50` - [x] `/chatops run feature set packages_conan_allow_empty_username_channel 70` - Enable the feature globally on production environment. - [x] `/chatops run feature set packages_conan_allow_empty_username_channel true` - [x] Announce on [the feature issue](ISSUE LINK) that the feature has been globally enabled. - [ ] Wait for [at least one day for the verification term](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release). ### Release the feature After the feature has been [deemed stable](https://about.gitlab.com/handbook/product-development-flow/feature-flag-lifecycle/#including-a-feature-behind-feature-flag-in-the-final-release), the [clean up](https://docs.gitlab.com/ee/development/feature_flags/controls.html#cleaning-up) should be done as soon as possible to permanently enable the feature and reduce complexity in the codebase. <!-- The checklist here is to help stakeholders keep track of the feature flag status --> - [x] Create a merge request to remove `packages_conan_allow_empty_username_channel` feature flag. Ask for review and merge it. - [x] Remove all references to the feature flag from the codebase. - [x] Remove the YAML definitions for the feature from the repository. - [x] Create [a changelog entry](https://docs.gitlab.com/ee/development/feature_flags/#changelog). - [x] Ensure that the cleanup MR has been deployed to both production and canary. If the merge request was deployed before [the code cutoff](https://about.gitlab.com/handbook/engineering/releases/#self-managed-releases-1), the feature can be officially announced in a release blog post. - [x] `/chatops run auto_deploy status <merge-commit-of-cleanup-mr>` - [x] Close [the feature issue](ISSUE LINK) to indicate the feature will be released in the current milestone. - [x] Clean up the feature flag from all environments by running these chatops command in `#production` channel: - [x] `/chatops run feature delete packages_conan_allow_empty_username_channel --dev` - [x] `/chatops run feature delete packages_conan_allow_empty_username_channel --staging` - [x] `/chatops run feature delete packages_conan_allow_empty_username_channel` - [x] Close this rollout issue. ## Rollback Steps - [ ] This feature can be disabled by running the following Chatops command: ``` /chatops run feature set packages_conan_allow_empty_username_channel false ```