<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=324873) </details> <!--IssueSummary end--> ## Summary Follow up issue from https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/490, upload params are sent twice: 1. as body params 1. as a signed JWT param (1.) can be dropped and let rails read them from (2.) only. ## Improvements * With https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/490, [`saved_file_tacker.go`](https://gitlab.com/gitlab-org/gitlab-workhorse/-/blob/master/internal/upload/saved_file_tracker.go) is setting the same params twice. Removing (1.) from the above will simplify the code. * Uploaded requests forwarded to rails will be lighter. ## Risks * :warning: Before dealing with this issue, make sure that rails exclusively use (2.) (through [`multipart.rb`](https://gitlab.com/gitlab-org/gitlab/-/blob/master/lib/gitlab/middleware/multipart.rb)) * Uploads can be broken by these changes. Make sure to verify them with a good set of different uploads. Here is an example: https://gitlab.com/gitlab-org/gitlab-workhorse/-/merge_requests/490#verification * The use of a ~"feature flag" is advised. ## Involved components * [`saved_file_tacker.go`](https://gitlab.com/gitlab-org/gitlab-workhorse/-/blob/master/internal/upload/saved_file_tracker.go)