Fix docker in docker in our CI templates
We recently had docker in docker problems: - https://gitlab.com/gitlab-org/gitlab-runner/issues/4501 - https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31417 - https://gitlab.com/gitlab-com/gl-infra/production/issues/1023 We probably need to make sure that our docker templates work correctly: ``` lib/gitlab/ci/templates/Security/SAST.gitlab-ci.yml 15: - docker:stable-dind lib/gitlab/ci/templates/Security/Dependency-Scanning.gitlab-ci.yml 15: - docker:stable-dind lib/gitlab/ci/templates/Security/Container-Scanning.gitlab-ci.yml 32: - docker:stable-dind lib/gitlab/ci/templates/Jobs/Code-Quality.gitlab-ci.yml 6: - docker:stable-dind lib/gitlab/ci/templates/Jobs/Build.gitlab-ci.yml 7: - docker:stable-dind lib/gitlab/ci/templates/Jobs/Browser-Performance-Testing.gitlab-ci.yml 8: - docker:stable-dind ``` The following discussion from gitlab-ce!31417 should be addressed: - [ ] @tmaczukin started a [discussion](https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31417#note_199552319): (+3 comments) > @leipert Two suggestions, basing on the problem that we've investigated last week. Let's use explicitly tagged versions of the DinD image. With `19.03.0-dind` that I've proposed, you could leave the `DOCKER_HOST` unchanged. You can also use the latest version (`19.03.1-dind`) but in that case removing `DOCKER_HOST` declaration is required.
issue