Retrying a job doesn't notify the user that triggered that
<!--- Please read this! Before opening a new issue, make sure to search for keywords in the issues filtered by the "regression" or "bug" label. For the Community Edition issue tracker: - https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab-ce/issues?label_name%5B%5D=bug For the Enterprise Edition issue tracker: - https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=regression - https://gitlab.com/gitlab-org/gitlab-ee/issues?label_name%5B%5D=bug and verify the issue you're about to submit isn't a duplicate. ---> ### Summary If you retry a job, you don't get notified when it finishes. ### Steps to reproduce 1. User A configures email notifications for successful or failing pipelines. 1. User A triggers a pipeline. 1. Pipeline exits with :heavy_check_mark:. 1. User A gets notified of pipeline ending status. 1. User B retries a job in that pipeline. 1. The job fails. ### Example Project Any project. ### What is the current *bug* behavior? User B is not notified on pipeline status. ### What is the expected *correct* behavior? Both users A and B should get notified for the new pipeline status. ### Relevant logs and/or screenshots (Paste any relevant logs - please use code blocks (```) to format console output, logs, and code as it's tough to read otherwise.) ### Output of checks (If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com) #### Results of GitLab environment info <details> <summary>Expand for output related to GitLab environment info</summary> <pre> System information System: Current User: git Using RVM: no Ruby Version: 2.5.3p105 Gem Version: 2.7.9 Bundler Version:1.17.3 Rake Version: 12.3.2 Redis Version: 3.2.12 Git Version: 2.21.0 Sidekiq Version:5.2.7 Go Version: unknown GitLab information Version: 11.11.3 Revision: e3eeb779d72 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: PostgreSQL DB Version: 9.6.11 URL: https://** HTTP Clone URL: https://**/some-group/some-project.git SSH Clone URL: git@**:some-group/some-project.git Using LDAP: no Using Omniauth: yes Omniauth Providers: GitLab Shell Version: 9.1.0 Repository storage paths: - default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git </pre> </details> #### Results of GitLab application Check <details> <summary>Expand for output related to the GitLab application check</summary> <pre>Checking <font color="#C4A000">GitLab subtasks</font> ... Checking <font color="#C4A000">GitLab Shell</font> ... GitLab Shell: ... GitLab Shell version &gt;= 9.1.0 ? ... <font color="gitlab-ce#4E9A06">OK (9.1.0)</font> Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK Access to /var/opt/gitlab/.ssh/authorized_keys: OK <font color="gitlab-ce#4E9A06">gitlab-shell self-check successful</font> Checking <font color="#C4A000">GitLab Shell</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">Gitaly</font> ... Gitaly: ... default ... <font color="gitlab-ce#4E9A06">OK</font> Checking <font color="#C4A000">Gitaly</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">Sidekiq</font> ... Sidekiq: ... Running? ... <font color="gitlab-ce#4E9A06">yes</font> Number of Sidekiq processes ... <font color="gitlab-ce#4E9A06">1</font> Checking <font color="#C4A000">Sidekiq</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">Incoming Email</font> ... Incoming Email: ... Reply by email is disabled in config/gitlab.yml Checking <font color="#C4A000">Incoming Email</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">LDAP</font> ... LDAP: ... LDAP is disabled in config/gitlab.yml Checking <font color="#C4A000">LDAP</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">GitLab App</font> ... Git configured correctly? ... <font color="gitlab-ce#4E9A06">yes</font> Database config exists? ... <font color="gitlab-ce#4E9A06">yes</font> All migrations up? ... <font color="gitlab-ce#4E9A06">yes</font> Database contains orphaned GroupMembers? ... <font color="gitlab-ce#4E9A06">no</font> GitLab config exists? ... <font color="gitlab-ce#4E9A06">yes</font> GitLab config up to date? ... <font color="gitlab-ce#4E9A06">yes</font> Log directory writable? ... <font color="gitlab-ce#4E9A06">yes</font> Tmp directory writable? ... <font color="gitlab-ce#4E9A06">yes</font> Uploads directory exists? ... <font color="gitlab-ce#4E9A06">yes</font> Uploads directory has correct permissions? ... <font color="gitlab-ce#4E9A06">yes</font> Uploads directory tmp has correct permissions? ... <font color="gitlab-ce#4E9A06">yes</font> Init script exists? ... <font color="#75507B">skipped (omnibus-gitlab has no init script)</font> Init script up-to-date? ... <font color="#75507B">skipped (omnibus-gitlab has no init script)</font> Projects have namespace: ... <font color="#C4A000">2</font>/<font color="#C4A000">2</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">3</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">4</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">6</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">7</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">8</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">9</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">12</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">13</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">14</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">15</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">17</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">18</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">19</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">20</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">21</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">22</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">23</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">24</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">25</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">26</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">27</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">28</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">17</font>/<font color="#C4A000">29</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">30</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">31</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">32</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">33</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">34</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">35</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">36</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">37</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">37</font>/<font color="#C4A000">38</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">39</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">41</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">42</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">44</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">45</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">46</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">47</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">48</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">49</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">50</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">51</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">52</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">53</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">54</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">55</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">55</font>/<font color="#C4A000">56</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">57</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">58</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">59</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">61</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">62</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">63</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">64</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">65</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">66</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">67</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">68</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">70</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">71</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">72</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">73</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">74</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">75</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">76</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">42</font>/<font color="#C4A000">79</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">81</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">82</font> ... <font color="gitlab-ce#4E9A06">yes</font> <font color="#C4A000">2</font>/<font color="#C4A000">83</font> ... <font color="gitlab-ce#4E9A06">yes</font> Redis version &gt;= 2.8.0? ... <font color="gitlab-ce#4E9A06">yes</font> Ruby version &gt;= 2.5.3 ? ... <font color="gitlab-ce#4E9A06">yes (2.5.3)</font> Git version &gt;= 2.21.0 ? ... <font color="gitlab-ce#4E9A06">yes (2.21.0)</font> Git user has default SSH configuration? ... <font color="gitlab-ce#4E9A06">yes</font> Active users: ... <font color="gitlab-ce#4E9A06">43</font> Checking <font color="#C4A000">GitLab App</font> ... <font color="gitlab-ce#4E9A06">Finished</font> Checking <font color="#C4A000">GitLab subtasks</font> ... <font color="gitlab-ce#4E9A06">Finished</font> </pre> </details> ### Possible fixes No idea.
issue