Base64 embedding of images in notification mails
<!--IssueSummary start--> <details> <summary> Everyone can contribute. [Help move this issue forward](https://handbook.gitlab.com/handbook/marketing/developer-relations/contributor-success/community-contributors-workflows/#contributor-links) while earning points, leveling up and collecting rewards. </summary> - [Close this issue](https://contributors.gitlab.com/manage-issue?action=close&projectId=278964&issueIid=24179) </details> <!--IssueSummary end--> Images in notification E-Mails are not embedded but only link to the uploaded file which 1. Is a privacy issue and some email clients block them 2. Does not work for non-publicly available gitlab instances behind firewalls 3. ~~Frankly, I consider it a security issue that an email client can display them without being logged in: gitlab-ce#51503 (and logging in in the email client would not be possible)~~ Edit: though this is still my personal opinion, this has been determined to "work as expected" by Gitlab engineers 4. Also does not work for Gitlab-specific **assets** of an instance between a firewall like e.g. icons: gitlab-ce#24859 The solution would be to embed all images into the mails directly. * This feature seems to have been implemented in gitlab-ce!373 but it is broken again. * The request has already been posted here some time ago: https://forum.gitlab.com/t/images-arent-showing-in-emails/6836
issue