Move and collapse approval rules under "reviewers" section on merge requests
## Problem With the introduction of a dedicated reviewers section on merge requests https://gitlab.com/gitlab-org/gitlab/-/issues/216054, it's confusing to have an "approvers" section in addition. Since "approver" is not an official role in our model, having both approvers and reviewers becomes confusing. ## Proposal Move approval rules to be a sub-section of the "reviewers" section | Conditions | Image | |-|-| | Approvals optional | ![image](/uploads/2a678aff6bce4be37457f4800da5ac2d/image.png)<br>In this case, if approvals are **not overridable**, we hide the `Show approval rules` accordion, as there's no use in it. | | Anyone can approve, X approvals required | ![image](/uploads/514da04528a3af12bf82e9fa075b2a53/image.png) | | Single rule, only some people can approve | ![image](/uploads/d77003a9fc47f9253b24d4c084a4e245/image.png) | | Multiple rules | ![image](/uploads/349c2551775c52880c4b2d90d652bc2c/image.png) | ### Further details 1. Approval rules on Starter tier should only allow for one rule as currently supported 2. Approval rules on Premium tier should allow multiple approval rules ### Testing - [ ] Run `package-and-qa` to check if the existing tests are affected.
issue